)]}'
{"id":"openvpn~1955","triplet_id":"openvpn~master~I44d7171c7e4f8497bf8b902380df92a58bf8a79a","project":"openvpn","branch":"master","full_branch":"refs/heads/master","topic":"cppcheck","attention_set":{},"removed_from_attention_set":{"1000053":{"account":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"last_update":"2026-10-04 08:56:37.000000000","reason":"Change was submitted"},"1000003":{"account":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2026-10-04 08:56:37.000000000","reason":"Change was submitted"},"1000001":{"account":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2026-10-04 08:56:37.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I44d7171c7e4f8497bf8b902380df92a58bf8a79a","subject":"Build against Windows 10 API and remove some backwards compatility code","status":"MERGED","created":"2026-09-28 12:47:48.000000000","updated":"2026-10-04 08:56:37.000000000","submitted":"2026-10-04 08:56:37.000000000","submitter":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":8,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"1955-cppcheck","meta_rev_id":"a52bbb61c9b7786a00904765676122c108aa9e78","_number":1955,"virtual_id_number":1955,"owner":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},{"value":0,"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"reviewers":{"REVIEWER":[{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-09-28 12:47:49.000000000","updated_by":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"real_updated_by":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2026-09-28 12:47:49.000000000","updated_by":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"real_updated_by":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2026-09-28 13:36:29.000000000","updated_by":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"real_updated_by":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"reviewer":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"state":"CC"},{"updated":"2026-09-28 14:41:55.000000000","updated_by":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"real_updated_by":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"reviewer":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"state":"REVIEWER"},{"updated":"2026-10-03 17:56:56.000000000","updated_by":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"real_updated_by":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"state":"REVIEWER"}],"messages":[{"id":"4903df654acc1cd69faf1841aa6a03fcd06501d7","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-09-28 12:47:48.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"9d7185d777516cae1e22fdbe265ac00c795678ce","author":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"date":"2026-09-28 13:36:29.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"7bc3ca23e8a603ae145246fa014b88c02b122047","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-09-28 14:08:55.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"8532d28af152d01f39374c4e4b427837ecb6b6c6","author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-09-28 14:11:52.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"f17fe8cff88d38a18f216926c99688669babc37c","author":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"date":"2026-09-28 14:21:30.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"220de9f4e2c132372c1433135d5955f22647b254","author":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"date":"2026-09-28 14:22:04.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"833f5394fa4a6375ba691a49f0bd7e3d1885f431","author":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"date":"2026-09-28 14:41:55.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"7791ed932815172134b90f7eca10d271342eba6c","author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-09-28 14:53:17.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"71b076d38cb5e322b0d7266f8444a913fdebddfd","author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-09-29 11:02:27.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"f421efbae464a8d5d84026609c8c0296b29047bb","tag":"autogenerated:gerrit:setWorkInProgress","author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-09-29 11:02:35.000000000","message":"Set Work In Progress","accounts_in_message":[],"_revision_number":2},{"id":"34e7d362db1859fad3c8a2e1057fd6483c6b91a1","tag":"autogenerated:gerrit:newWipPatchSet","author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-09-30 13:22:03.000000000","message":"Uploaded patch set 3.\n\nOutdated Votes:\n* Code-Review+2 (copy condition: \"changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR is:MIN\")\n","accounts_in_message":[],"_revision_number":3},{"id":"41c6e46c58b804e5fb20fd0273a399d2772c391e","author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-09-30 13:22:39.000000000","message":"Patch Set 3:\n\n(1 comment)\n\nThis change is ready for review.","accounts_in_message":[],"_revision_number":3},{"id":"e2dd9022bf73f98310a8de59f6487cba0dc4753b","author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-09-30 13:22:55.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"49941578a49e7711dd93e330ff97591e228fc758","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-09-30 15:04:50.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"775242a0e8671c02a14b51f845598a8eef06a262","author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2026-10-03 17:56:56.000000000","message":"Patch Set 4: Code-Review+2","accounts_in_message":[],"_revision_number":4},{"id":"a52bbb61c9b7786a00904765676122c108aa9e78","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2026-10-04 08:56:37.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":5}],"current_revision_number":5,"current_revision":"624f08b120a119ac730ce6e09c2abc59495c069d","revisions":{"5021b5a573c2cf4d791c625689bd920c94916de3":{"kind":"REWORK","_number":1,"created":"2026-09-28 12:47:48.000000000","uploader":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/55/1955/1","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/55/1955/1","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/55/1955/1 \u0026\u0026 git checkout -b change-1955 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/55/1955/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/55/1955/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/55/1955/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/55/1955/1","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/55/1955/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"09dc80cc77d4d22b1204a1ca8ef62bc05ddf6245","subject":"Fix various issues found by cppcheck 2.21.0"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-09-28 11:43:25.000000000","tz":120},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-09-28 12:46:49.000000000","tz":120},"subject":"Build against Windows 10 API and remove some backwards compatility code","message":"Build against Windows 10 API and remove some backwards compatility code\n\nOriginally prompted by some cppcheck complaint about\nwin32_get_arch(). Looking at the code I decided to\npropose removing the various work-arounds from pre-Win10\ntimes. Microsoft certainly doesn\u0027t support these\nversions anymore, so let\u0027s also remove that.\n\nNote that this does not remove all instances of GetProcAddress:\n- One is required due to a issue in MinGW toolchain (DiInstallDevice)\n- One is used to avoid a dependency on WDK headers (RtlGetVersion)\n- One is required due to using an undocumented function that is\n  not available in MinGW (RtlPublishWnfStateData)\n\nChange-Id: I44d7171c7e4f8497bf8b902380df92a58bf8a79a\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"7f48516ea1d96c7a8545cbdb1292def401ac411e":{"kind":"REWORK","_number":2,"created":"2026-09-28 14:08:55.000000000","uploader":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/55/1955/2","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/55/1955/2","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/55/1955/2 \u0026\u0026 git checkout -b change-1955 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/55/1955/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/55/1955/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/55/1955/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/55/1955/2","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/55/1955/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"94fb95498d8c52fa3b219f91edad2f81240def9c","subject":"cppcheck: Fix handling of likely() on Windows"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-09-28 11:43:25.000000000","tz":120},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-09-28 14:08:23.000000000","tz":120},"subject":"Build against Windows 10 API and remove some backwards compatility code","message":"Build against Windows 10 API and remove some backwards compatility code\n\nOriginally prompted by some cppcheck complaint about\nwin32_get_arch(). Looking at the code I decided to\npropose removing the various work-arounds from pre-Win10\ntimes. Microsoft certainly doesn\u0027t support these\nversions anymore, so let\u0027s also remove that.\n\nNote that this does not remove all instances of GetProcAddress:\n- One is required due to a issue in MinGW toolchain (DiInstallDevice)\n- One is used to avoid a dependency on WDK headers (RtlGetVersion)\n- One is required due to using an undocumented function that is\n  not available in MinGW (RtlPublishWnfStateData)\n\nChange-Id: I44d7171c7e4f8497bf8b902380df92a58bf8a79a\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"5f771fbfdf43a76d572bd3eb510e88358f56b7e8":{"kind":"REWORK","_number":3,"created":"2026-09-30 13:22:03.000000000","uploader":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/55/1955/3","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/55/1955/3","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/55/1955/3 \u0026\u0026 git checkout -b change-1955 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/55/1955/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/55/1955/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/55/1955/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/55/1955/3","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/55/1955/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"cc339dbf62f25ad08c277862348b8bf071fb3793","subject":"Fix various issues found by cppcheck 2.21.0"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-09-28 11:43:25.000000000","tz":120},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-09-30 13:21:08.000000000","tz":120},"subject":"Build against Windows 10 API and remove some backwards compatility code","message":"Build against Windows 10 API and remove some backwards compatility code\n\nOriginally prompted by some cppcheck complaint about\nwin32_get_arch(). Looking at the code I decided to\npropose removing the various work-arounds from pre-Win10\ntimes. Microsoft certainly doesn\u0027t support these\nversions anymore, so let\u0027s also remove that.\n\nNote that this does not remove all instances of GetProcAddress:\n- One is required due to a issue in MinGW toolchain (DiInstallDevice)\n- One is used to avoid a dependency on WDK headers (RtlGetVersion)\n- One is required due to using an undocumented function that is\n  not available in MinGW (RtlPublishWnfStateData)\n\nChange-Id: I44d7171c7e4f8497bf8b902380df92a58bf8a79a\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"2bbb6f5c84bbb83c2bfb791879f7f6193638cd29":{"kind":"REWORK","_number":4,"created":"2026-09-30 15:04:50.000000000","uploader":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/55/1955/4","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/55/1955/4","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/55/1955/4 \u0026\u0026 git checkout -b change-1955 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/55/1955/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/55/1955/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/55/1955/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/55/1955/4","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/55/1955/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"cc339dbf62f25ad08c277862348b8bf071fb3793","subject":"Fix various issues found by cppcheck 2.21.0"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-09-28 11:43:25.000000000","tz":120},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-09-30 15:03:40.000000000","tz":120},"subject":"Build against Windows 10 API and remove some backwards compatility code","message":"Build against Windows 10 API and remove some backwards compatility code\n\nOriginally prompted by some cppcheck complaint about\nwin32_get_arch(). Looking at the code I decided to\npropose removing the various work-arounds from pre-Win10\ntimes. Microsoft certainly doesn\u0027t support these\nversions anymore, so let\u0027s also remove that.\n\nNote that this does not remove all instances of GetProcAddress:\n- One is required due to a issue in MinGW toolchain (DiInstallDevice)\n- One is used to avoid a dependency on WDK headers (RtlGetVersion)\n- One is required due to using an undocumented function that is\n  not available in MinGW (RtlPublishWnfStateData)\n\nChange-Id: I44d7171c7e4f8497bf8b902380df92a58bf8a79a\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"624f08b120a119ac730ce6e09c2abc59495c069d":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":5,"created":"2026-10-04 08:56:37.000000000","uploader":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/55/1955/5","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/55/1955/5","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/55/1955/5 \u0026\u0026 git checkout -b change-1955 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/55/1955/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/55/1955/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/55/1955/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/55/1955/5","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/55/1955/5 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"7f1dfa99fd1e7e609abeff7f331face61dbcbeaa","subject":"Fix various issues found by cppcheck 2.21.0"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-10-03 17:57:12.000000000","tz":120},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2026-10-04 08:49:17.000000000","tz":120},"subject":"Build against Windows 10 API and remove some backwards compatility code","message":"Build against Windows 10 API and remove some backwards compatility code\n\nOriginally prompted by some cppcheck complaint about\nwin32_get_arch(). Looking at the code I decided to\npropose removing the various work-arounds from pre-Win10\ntimes. Microsoft certainly doesn\u0027t support these\nversions anymore, so let\u0027s also remove that.\n\nNote that this does not remove all instances of GetProcAddress:\n- One is required due to a issue in MinGW toolchain (DiInstallDevice)\n- One is used to avoid a dependency on WDK headers (RtlGetVersion)\n- One is required due to using an undocumented function that is\n  not available in MinGW (RtlPublishWnfStateData)\n\nChange-Id: I44d7171c7e4f8497bf8b902380df92a58bf8a79a\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\nAcked-by: Gert Doering \u003cgert@greenie.muc.de\u003e\nGerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1955\nMessage-Id: \u003c20261003175718.6544-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg39673.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[]}