)]}'
{"id":"openvpn~1957","triplet_id":"openvpn~master~I3b835558451414d8a4e8058114643555be69d391","project":"openvpn","branch":"master","full_branch":"refs/heads/master","topic":"cppcheck","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2026-09-28 14:14:55.000000000","reason":"removed on reply"},"1000001":{"account":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2026-09-28 21:11:32.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I3b835558451414d8a4e8058114643555be69d391","subject":"cppcheck: Fix handling of likely() on Windows","status":"MERGED","created":"2026-09-28 14:08:55.000000000","updated":"2026-09-28 21:11:32.000000000","submitted":"2026-09-28 21:11:32.000000000","submitter":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"1957-cppcheck","meta_rev_id":"c6e63486d8d7b9bf8a021abb202c8fc62efde26b","_number":1957,"virtual_id_number":1957,"owner":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"value":0,"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-09-28 14:08:57.000000000","updated_by":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"real_updated_by":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2026-09-28 14:08:57.000000000","updated_by":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"real_updated_by":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"}],"messages":[{"id":"bc9acc85cd413189fa7cd502bc6e54ae3a4ed06c","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-09-28 14:08:55.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"d338612b37e4f2b7e3837e43c9a59cb4789b95e4","author":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2026-09-28 14:14:55.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"c6e63486d8d7b9bf8a021abb202c8fc62efde26b","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2026-09-28 21:11:32.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"fe1162561c67e036e03bf07276d67d1b05d42cda","revisions":{"94fb95498d8c52fa3b219f91edad2f81240def9c":{"kind":"REWORK","_number":1,"created":"2026-09-28 14:08:55.000000000","uploader":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/57/1957/1","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/57/1957/1","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/57/1957/1 \u0026\u0026 git checkout -b change-1957 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/57/1957/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/57/1957/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/57/1957/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/57/1957/1","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/57/1957/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"09dc80cc77d4d22b1204a1ca8ef62bc05ddf6245","subject":"Fix various issues found by cppcheck 2.21.0"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-09-28 14:05:14.000000000","tz":120},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-09-28 14:08:23.000000000","tz":120},"subject":"cppcheck: Fix handling of likely() on Windows","message":"cppcheck: Fix handling of likely() on Windows\n\nSince we do not force __GNUC__ to undefined on Windows\n(since we want to support MinGW) cppcheck might stumble\nupon __builtin_expect(). When running with gnu.cfg (which\nwe do not want to do for Windows code) then that has an\nexisting override. But for our Windows checks we need to\nadd our own override.\n\nThis caused false-positives in buffer code.\n\nChange-Id: I3b835558451414d8a4e8058114643555be69d391\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"fe1162561c67e036e03bf07276d67d1b05d42cda":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":2,"created":"2026-09-28 21:11:32.000000000","uploader":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/57/1957/2","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/57/1957/2","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/57/1957/2 \u0026\u0026 git checkout -b change-1957 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/57/1957/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/57/1957/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/57/1957/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/57/1957/2","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/57/1957/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"2f76d3aac55a5347273013d60eb86aa17c8b8941","subject":"dco: remove iroute at client exit time instead of delayed exit"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-09-28 14:15:53.000000000","tz":120},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2026-09-28 21:10:27.000000000","tz":120},"subject":"cppcheck: Fix handling of likely() on Windows","message":"cppcheck: Fix handling of likely() on Windows\n\nSince we do not force __GNUC__ to undefined on Windows\n(since we want to support MinGW) cppcheck might stumble\nupon __builtin_expect(). When running with gnu.cfg (which\nwe do not want to do for Windows code) then that has an\nexisting override. But for our Windows checks we need to\nadd our own override.\n\nThis caused false-positives in buffer code.\n\nChange-Id: I3b835558451414d8a4e8058114643555be69d391\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\nAcked-by: Arne Schwabe \u003carne-openvpn@rfc2549.org\u003e\nGerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1957\nMessage-Id: \u003c20260928141559.11880-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg39555.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[]}