)]}'
{"id":"openvpn~1962","triplet_id":"openvpn~master~I165c632da6a837d0cca55bee4c2cc390b91d1e54","project":"openvpn","branch":"master","full_branch":"refs/heads/master","attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2026-09-28 16:12:15.000000000","reason":"Reviewer was added"}},"removed_from_attention_set":{},"hashtags":[],"change_id":"I165c632da6a837d0cca55bee4c2cc390b91d1e54","subject":"multi_io: drop IOW_MBUF","status":"NEW","created":"2026-09-28 16:12:15.000000000","updated":"2026-09-28 16:12:15.000000000","submit_type":"CHERRY_PICK","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"23072cbada10205cc57072936a6834ca77f25690","_number":1962,"virtual_id_number":1962,"owner":{"_account_id":1000034,"name":"Gianmarco De Gregori","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-09-28 16:12:15.000000000","updated_by":{"_account_id":1000034,"name":"Gianmarco De Gregori","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"real_updated_by":{"_account_id":1000034,"name":"Gianmarco De Gregori","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2026-09-28 16:12:15.000000000","updated_by":{"_account_id":1000034,"name":"Gianmarco De Gregori","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"real_updated_by":{"_account_id":1000034,"name":"Gianmarco De Gregori","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"}],"messages":[{"id":"3bcaac2620003c72725e2b2a50eb0006c4cbcba4","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000034,"name":"Gianmarco De Gregori","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"date":"2026-09-28 16:12:15.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"40a2f1f4b5d59defe28d8e9b091f4580c4e3114a","revisions":{"40a2f1f4b5d59defe28d8e9b091f4580c4e3114a":{"kind":"REWORK","_number":1,"created":"2026-09-28 16:12:15.000000000","uploader":{"_account_id":1000034,"name":"Gianmarco De Gregori","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"ref":"refs/changes/62/1962/1","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/62/1962/1","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/62/1962/1 \u0026\u0026 git checkout -b change-1962 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/62/1962/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/62/1962/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/62/1962/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/62/1962/1","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/62/1962/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"ee54ec4336d8a6fd39ebe77b38efef8eb4a56bec","subject":"mbuf: don\u0027t count dereferenced items in the queue length"}],"author":{"name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","date":"2026-09-04 15:01:35.000000000","tz":120},"committer":{"name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","date":"2026-09-28 13:40:31.000000000","tz":120},"subject":"multi_io: drop IOW_MBUF","message":"multi_io: drop IOW_MBUF\n\nBefore the UDP and TCP server loops were merged, each drained the\nbcast/mcast/client-to-client queue its own way: UDP armed EVENT_WRITE\nthrough IOW_MBUF, TCP used the flush loop at the end of\nmulti_io_process_io().  The merge kept both, leaving two consumers with\ndifferent disciplines.\n\nNeither checks the protocol of the instance it picks up, but only the\nTCP side copes: it tests proto_is_dgram() and tcp_link_out_deferred\nbefore writing.  The UDP one takes whatever heads the queue, TCP\ninstances included, and writes straight to that instance\u0027s socket,\nbypassing the deferred queue TCP needs for backpressure.\n\nDrain the queue from the flush loop alone and drop the UDP consumer.\nIOW_MBUF only existed to arm the socket for it, so it goes as well.\n\nChange-Id: I165c632da6a837d0cca55bee4c2cc390b91d1e54\nSigned-off-by: Gianmarco De Gregori \u003cgianmarco@mandelbit.com\u003e\n"},"branch":"refs/heads/master"}},"requirements":[{"status":"NOT_READY","fallback_text":"All required checks must pass","type":"checks_pass"}],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"NOT_READY","labels":[{"label":"Code-Review","status":"NEED"}]},{"rule_name":"checks~ChecksSubmitRule","status":"NOT_READY","requirements":[{"status":"NOT_READY","fallback_text":"All required checks must pass","type":"checks_pass"}]}]}