)]}'
{"src/openvpn/control_msg.c":[{"author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"d68f72c418cb311b7a98483210246aae47b67604","unresolved":true,"context_lines":[{"line_number":31,"context_line":"bool"},{"line_number":32,"context_line":"ctrl_msg_tlv_write_header(struct buffer *buf, uint16_t type, bool optional, uint16_t value_len)"},{"line_number":33,"context_line":"{"},{"line_number":34,"context_line":"    uint16_t field \u003d type \u0026 CTRL_MSG_TLV_TYPE_MASK;"},{"line_number":35,"context_line":"    if (optional)"},{"line_number":36,"context_line":"    {"},{"line_number":37,"context_line":"        field |\u003d CTRL_MSG_TLV_OPTIONAL_FLAG;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"fd568f0b_59ce8397","line":34,"updated":"2026-09-30 14:35:50.000000000","message":"Is there a valid reason why type might be different from field here? I wonder whether we should ASSERT?","commit_id":"09ca456f4fe87a0c765407eecd86e2b0f944a300"},{"author":{"_account_id":1000008,"name":"Lev Stipakov","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"change_message_id":"af3a402559755941272de0997301beee7a7afc65","unresolved":false,"context_lines":[{"line_number":31,"context_line":"bool"},{"line_number":32,"context_line":"ctrl_msg_tlv_write_header(struct buffer *buf, uint16_t type, bool optional, uint16_t value_len)"},{"line_number":33,"context_line":"{"},{"line_number":34,"context_line":"    uint16_t field \u003d type \u0026 CTRL_MSG_TLV_TYPE_MASK;"},{"line_number":35,"context_line":"    if (optional)"},{"line_number":36,"context_line":"    {"},{"line_number":37,"context_line":"        field |\u003d CTRL_MSG_TLV_OPTIONAL_FLAG;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"5bba6d37_4f3a205c","line":34,"in_reply_to":"fd568f0b_59ce8397","updated":"2026-10-01 07:36:51.000000000","message":"no reason. Will add an assert.","commit_id":"09ca456f4fe87a0c765407eecd86e2b0f944a300"},{"author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"d68f72c418cb311b7a98483210246aae47b67604","unresolved":true,"context_lines":[{"line_number":73,"context_line":"        return false; /* fewer than 4 bytes left: truncated header */"},{"line_number":74,"context_line":"    }"},{"line_number":75,"context_line":"    /* Advance past the value; fails if buf is shorter than the header claims. */"},{"line_number":76,"context_line":"    uint8_t *v \u003d buf_read_alloc(buf, hdr-\u003evalue_len);"},{"line_number":77,"context_line":"    if (!v)"},{"line_number":78,"context_line":"    {"},{"line_number":79,"context_line":"        return false;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"df6ec7b6_9c4db79c","line":76,"updated":"2026-09-30 14:35:50.000000000","message":"cppcheck says this should be const","commit_id":"09ca456f4fe87a0c765407eecd86e2b0f944a300"},{"author":{"_account_id":1000008,"name":"Lev Stipakov","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"change_message_id":"af3a402559755941272de0997301beee7a7afc65","unresolved":false,"context_lines":[{"line_number":73,"context_line":"        return false; /* fewer than 4 bytes left: truncated header */"},{"line_number":74,"context_line":"    }"},{"line_number":75,"context_line":"    /* Advance past the value; fails if buf is shorter than the header claims. */"},{"line_number":76,"context_line":"    uint8_t *v \u003d buf_read_alloc(buf, hdr-\u003evalue_len);"},{"line_number":77,"context_line":"    if (!v)"},{"line_number":78,"context_line":"    {"},{"line_number":79,"context_line":"        return false;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"2e2643a2_eeb32d45","line":76,"in_reply_to":"df6ec7b6_9c4db79c","updated":"2026-10-01 07:36:51.000000000","message":"added cppcheck to the workflow and added const.","commit_id":"09ca456f4fe87a0c765407eecd86e2b0f944a300"}],"tests/unit_tests/openvpn/test_control_msg.c":[{"author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"d68f72c418cb311b7a98483210246aae47b67604","unresolved":true,"context_lines":[{"line_number":104,"context_line":"    assert_true(ctrl_msg_tlv_next(\u0026buf, \u0026hdr, \u0026value));"},{"line_number":105,"context_line":"    assert_int_equal(hdr.type, 0x7ff);"},{"line_number":106,"context_line":"    assert_true(hdr.optional);"},{"line_number":107,"context_line":"    assert_int_equal(BLEN(\u0026value), 4);"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    assert_true(ctrl_msg_tlv_next(\u0026buf, \u0026hdr, \u0026value));"},{"line_number":110,"context_line":"    assert_int_equal(hdr.type, 0x5);"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"0ed3b34d_0ab7fd43","line":107,"updated":"2026-09-30 14:35:50.000000000","message":"Any specific reason why you do not verify the content of the buffer here?","commit_id":"09ca456f4fe87a0c765407eecd86e2b0f944a300"},{"author":{"_account_id":1000008,"name":"Lev Stipakov","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"change_message_id":"af3a402559755941272de0997301beee7a7afc65","unresolved":false,"context_lines":[{"line_number":104,"context_line":"    assert_true(ctrl_msg_tlv_next(\u0026buf, \u0026hdr, \u0026value));"},{"line_number":105,"context_line":"    assert_int_equal(hdr.type, 0x7ff);"},{"line_number":106,"context_line":"    assert_true(hdr.optional);"},{"line_number":107,"context_line":"    assert_int_equal(BLEN(\u0026value), 4);"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    assert_true(ctrl_msg_tlv_next(\u0026buf, \u0026hdr, \u0026value));"},{"line_number":110,"context_line":"    assert_int_equal(hdr.type, 0x5);"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"e258e02e_7d50c895","line":107,"in_reply_to":"0ed3b34d_0ab7fd43","updated":"2026-10-01 07:36:51.000000000","message":"Acknowledged","commit_id":"09ca456f4fe87a0c765407eecd86e2b0f944a300"}]}