)]}'
{"id":"openvpn~1966","triplet_id":"openvpn~master~I76c310f9e69276d4f21a4ad31a24490553d6d5c4","project":"openvpn","branch":"master","full_branch":"refs/heads/master","topic":"cppcheck","attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2026-09-30 13:22:07.000000000","reason":"Reviewer was added"},"1000001":{"account":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2026-10-03 17:53:51.000000000","reason":"Someone else replied on the change"}},"removed_from_attention_set":{},"hashtags":[],"change_id":"I76c310f9e69276d4f21a4ad31a24490553d6d5c4","subject":"cppcheck: Review suppressions for constParameter and constParameterCallback","status":"NEW","created":"2026-09-30 13:22:03.000000000","updated":"2026-10-07 15:30:00.000000000","submit_type":"CHERRY_PICK","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"7cf4041d5315346a1fb1057d9446cbc178dd5f16","_number":1966,"virtual_id_number":1966,"owner":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"actions":{},"labels":{"Code-Review":{"approved":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"all":[{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"value":2,"date":"2026-10-07 15:30:00.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-09-30 13:22:07.000000000","updated_by":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"real_updated_by":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2026-09-30 13:22:07.000000000","updated_by":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"real_updated_by":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2026-10-03 17:53:51.000000000","updated_by":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"real_updated_by":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"state":"REVIEWER"}],"messages":[{"id":"9651d590d99380661da812c43ef0f40bf2debf93","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-09-30 13:22:03.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"7a1b211d373a50a88d9f4438b1ebd84238851167","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-09-30 15:04:50.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.","accounts_in_message":[],"_revision_number":2},{"id":"db62695dd0a5cb4915c6f64037677ceb94a37a05","author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2026-10-03 17:53:51.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"adc79dc59220ad1e406add115f5f1c8e50e953f4","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-10-05 16:33:01.000000000","message":"Uploaded patch set 3: Patch Set 2 was rebased.\n\nCopied Votes:\n* Code-Review+2 (copy condition: \"changekind:NO_CHANGE OR **changekind:TRIVIAL_REBASE** OR is:MIN\")\n","accounts_in_message":[],"_revision_number":3},{"id":"a0a8b3201af943955b8d8cb1ef4f9deaac5c66a3","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-10-06 12:18:56.000000000","message":"Uploaded patch set 4: Patch Set 3 was rebased.\n\nCopied Votes:\n* Code-Review+2 (copy condition: \"changekind:NO_CHANGE OR **changekind:TRIVIAL_REBASE** OR is:MIN\")\n","accounts_in_message":[],"_revision_number":4},{"id":"7cf4041d5315346a1fb1057d9446cbc178dd5f16","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-10-07 15:30:00.000000000","message":"Uploaded patch set 5: Patch Set 4 was rebased.\n\nCopied Votes:\n* Code-Review+2 (copy condition: \"changekind:NO_CHANGE OR **changekind:TRIVIAL_REBASE** OR is:MIN\")\n","accounts_in_message":[],"_revision_number":5}],"current_revision_number":5,"current_revision":"7ef264b91e555791cc7fa6d1e83375968e6652df","revisions":{"7b017fd67a29249571bdddc41589f4993a97d004":{"kind":"REWORK","_number":1,"created":"2026-09-30 13:22:03.000000000","uploader":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/66/1966/1","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/66/1966/1","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/66/1966/1 \u0026\u0026 git checkout -b change-1966 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/66/1966/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/66/1966/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/66/1966/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/66/1966/1","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/66/1966/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"891afd79b6e27f1df7ad629615351709eff57e83","subject":"Fix (almost) all occurrences of cppcheck variableScope"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-09-29 15:32:46.000000000","tz":120},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-09-30 13:21:08.000000000","tz":120},"subject":"cppcheck: Review suppressions for constParameter and constParameterCallback","message":"cppcheck: Review suppressions for constParameter and constParameterCallback\n\nI reviewed all the occurrences of the two cppcheck\nerrors constParameter and constParameterCallback.\n\nAll of constParameterCallback occurences were bogus and\nI think in most cases they will be. So continue to ignore\nit completely but document that we considered it and it\nis not useful.\n\nAll existing cases of constParameter were bogus, but\nthere might be useful hits in the future so I only\nsuppress the existing occurrences.\n\nChange-Id: I76c310f9e69276d4f21a4ad31a24490553d6d5c4\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"3f42df7820f5da15192a73daa5d767531a590e34":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2026-09-30 15:04:50.000000000","uploader":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/66/1966/2","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/66/1966/2","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/66/1966/2 \u0026\u0026 git checkout -b change-1966 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/66/1966/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/66/1966/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/66/1966/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/66/1966/2","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/66/1966/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"b8548e8f99857caba8925425dbfdeec18b0c1d4c","subject":"Fix (almost) all occurrences of cppcheck variableScope"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-09-29 15:32:46.000000000","tz":120},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-09-30 15:03:40.000000000","tz":120},"subject":"cppcheck: Review suppressions for constParameter and constParameterCallback","message":"cppcheck: Review suppressions for constParameter and constParameterCallback\n\nI reviewed all the occurrences of the two cppcheck\nerrors constParameter and constParameterCallback.\n\nAll of constParameterCallback occurences were bogus and\nI think in most cases they will be. So continue to ignore\nit completely but document that we considered it and it\nis not useful.\n\nAll existing cases of constParameter were bogus, but\nthere might be useful hits in the future so I only\nsuppress the existing occurrences.\n\nChange-Id: I76c310f9e69276d4f21a4ad31a24490553d6d5c4\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"abedf686ff07f8b314a0caf63867014a5b24533b":{"kind":"TRIVIAL_REBASE","_number":3,"created":"2026-10-05 16:33:01.000000000","uploader":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/66/1966/3","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/66/1966/3","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/66/1966/3 \u0026\u0026 git checkout -b change-1966 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/66/1966/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/66/1966/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/66/1966/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/66/1966/3","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/66/1966/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"16fca091150b2954a89c7140f846c21189372008","subject":"Remove instances of constParameterPointer cppcheck warnings"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-09-29 15:32:46.000000000","tz":120},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-10-05 16:32:46.000000000","tz":120},"subject":"cppcheck: Review suppressions for constParameter and constParameterCallback","message":"cppcheck: Review suppressions for constParameter and constParameterCallback\n\nI reviewed all the occurrences of the two cppcheck\nerrors constParameter and constParameterCallback.\n\nAll of constParameterCallback occurences were bogus and\nI think in most cases they will be. So continue to ignore\nit completely but document that we considered it and it\nis not useful.\n\nAll existing cases of constParameter were bogus, but\nthere might be useful hits in the future so I only\nsuppress the existing occurrences.\n\nChange-Id: I76c310f9e69276d4f21a4ad31a24490553d6d5c4\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"710326961896a1878828a3b134e4ad176de37b12":{"kind":"TRIVIAL_REBASE","_number":4,"created":"2026-10-06 12:18:56.000000000","uploader":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/66/1966/4","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/66/1966/4","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/66/1966/4 \u0026\u0026 git checkout -b change-1966 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/66/1966/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/66/1966/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/66/1966/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/66/1966/4","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/66/1966/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"bb42ebff0e89714804fc9e73a6ca70d831e23218","subject":"Remove instances of constParameterPointer cppcheck warnings"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-09-29 15:32:46.000000000","tz":120},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-10-06 11:59:34.000000000","tz":120},"subject":"cppcheck: Review suppressions for constParameter and constParameterCallback","message":"cppcheck: Review suppressions for constParameter and constParameterCallback\n\nI reviewed all the occurrences of the two cppcheck\nerrors constParameter and constParameterCallback.\n\nAll of constParameterCallback occurences were bogus and\nI think in most cases they will be. So continue to ignore\nit completely but document that we considered it and it\nis not useful.\n\nAll existing cases of constParameter were bogus, but\nthere might be useful hits in the future so I only\nsuppress the existing occurrences.\n\nChange-Id: I76c310f9e69276d4f21a4ad31a24490553d6d5c4\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"7ef264b91e555791cc7fa6d1e83375968e6652df":{"kind":"TRIVIAL_REBASE","_number":5,"created":"2026-10-07 15:30:00.000000000","uploader":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/66/1966/5","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/66/1966/5","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/66/1966/5 \u0026\u0026 git checkout -b change-1966 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/66/1966/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/66/1966/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/66/1966/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/66/1966/5","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/66/1966/5 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"d26fb6d4a2ad7f59269b568c80419bc18bbca028","subject":"Remove instances of constParameterPointer cppcheck warnings"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-09-29 15:32:46.000000000","tz":120},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-10-07 15:29:54.000000000","tz":120},"subject":"cppcheck: Review suppressions for constParameter and constParameterCallback","message":"cppcheck: Review suppressions for constParameter and constParameterCallback\n\nI reviewed all the occurrences of the two cppcheck\nerrors constParameter and constParameterCallback.\n\nAll of constParameterCallback occurences were bogus and\nI think in most cases they will be. So continue to ignore\nit completely but document that we considered it and it\nis not useful.\n\nAll existing cases of constParameter were bogus, but\nthere might be useful hits in the future so I only\nsuppress the existing occurrences.\n\nChange-Id: I76c310f9e69276d4f21a4ad31a24490553d6d5c4\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"}},"requirements":[{"status":"NOT_READY","fallback_text":"All required checks must pass","type":"checks_pass"}],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"OK","labels":[{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}}]},{"rule_name":"checks~ChecksSubmitRule","status":"NOT_READY","requirements":[{"status":"NOT_READY","fallback_text":"All required checks must pass","type":"checks_pass"}]}]}