)]}'
{"id":"openvpn~1984","triplet_id":"openvpn~master~I33b246dea9eb9383e1ca928e1330ba840b7f990c","project":"openvpn","branch":"master","full_branch":"refs/heads/master","topic":"cppcheck","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2026-10-07 17:17:38.000000000","reason":"Change was submitted"},"1000001":{"account":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2026-10-07 17:17:38.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I33b246dea9eb9383e1ca928e1330ba840b7f990c","subject":"Add missing includes for C files and their own headers","status":"MERGED","created":"2026-10-06 12:18:56.000000000","updated":"2026-10-07 17:17:38.000000000","submitted":"2026-10-07 17:17:38.000000000","submitter":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"1984-cppcheck","meta_rev_id":"1fb53f368f225e3ef30d15d4c7434217347c5a85","_number":1984,"virtual_id_number":1984,"owner":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},{"value":0,"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"reviewers":{"REVIEWER":[{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-10-06 12:18:59.000000000","updated_by":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"real_updated_by":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2026-10-06 12:18:59.000000000","updated_by":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"real_updated_by":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2026-10-06 13:15:04.000000000","updated_by":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"real_updated_by":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"reviewer":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"state":"REVIEWER"}],"messages":[{"id":"d52763dbedbdafc80ddf661361a4a68297c72e9c","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-10-06 12:18:56.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"4eb0c7f1d1ee99b31796c7108b7c7cf4ea39cd03","author":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"date":"2026-10-06 13:15:04.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"7f32d5b381898d634d136a0bc5d34b1789cc949f","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-10-07 15:30:00.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.\n\nCopied Votes:\n* Code-Review+2 (copy condition: \"changekind:NO_CHANGE OR **changekind:TRIVIAL_REBASE** OR is:MIN\")\n","accounts_in_message":[],"_revision_number":2},{"id":"1fb53f368f225e3ef30d15d4c7434217347c5a85","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2026-10-07 17:17:38.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"a1c4187364f14dc267becbcbdf60f16354d9d70b","revisions":{"93486a08242cea5ca542ef1af4957bac518a0e70":{"kind":"REWORK","_number":1,"created":"2026-10-06 12:18:56.000000000","uploader":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/84/1984/1","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/84/1984/1","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/84/1984/1 \u0026\u0026 git checkout -b change-1984 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/84/1984/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/84/1984/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/84/1984/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/84/1984/1","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/84/1984/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"10bc348ce70008bb150d37ad2ce4c5891117f299","subject":"mbuf: don\u0027t count dereferenced items in the queue length"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-10-06 11:51:24.000000000","tz":120},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-10-06 11:56:29.000000000","tz":120},"subject":"Add missing includes for C files and their own headers","message":"Add missing includes for C files and their own headers\n\nWe don\u0027t strictly need those, but it is much better to\nhave them since the compiler will then ensure that we\ndo not have subtle differences between declarations and\ndefinitions.\n\nAlso fix\n- socks.h not being able to be included on its own\n- open_tun_afunix stub for Windows having wrong\n  parameters\n\nChange-Id: I33b246dea9eb9383e1ca928e1330ba840b7f990c\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"84f915fba8ac11629f5a9845013a41e0ec000dd5":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2026-10-07 15:30:00.000000000","uploader":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/84/1984/2","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/84/1984/2","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/84/1984/2 \u0026\u0026 git checkout -b change-1984 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/84/1984/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/84/1984/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/84/1984/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/84/1984/2","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/84/1984/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"bf2d472c88654f859d806a9341e3ac9eba8caba6","subject":"multi_io: drop IOW_MBUF"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-10-06 11:51:24.000000000","tz":120},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-10-07 15:15:30.000000000","tz":120},"subject":"Add missing includes for C files and their own headers","message":"Add missing includes for C files and their own headers\n\nWe don\u0027t strictly need those, but it is much better to\nhave them since the compiler will then ensure that we\ndo not have subtle differences between declarations and\ndefinitions.\n\nAlso fix\n- socks.h not being able to be included on its own\n- open_tun_afunix stub for Windows having wrong\n  parameters\n\nChange-Id: I33b246dea9eb9383e1ca928e1330ba840b7f990c\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"a1c4187364f14dc267becbcbdf60f16354d9d70b":{"kind":"NO_CODE_CHANGE","_number":3,"created":"2026-10-07 17:17:38.000000000","uploader":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/84/1984/3","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/84/1984/3","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/84/1984/3 \u0026\u0026 git checkout -b change-1984 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/84/1984/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/84/1984/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/84/1984/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/84/1984/3","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/84/1984/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"bf2d472c88654f859d806a9341e3ac9eba8caba6","subject":"multi_io: drop IOW_MBUF"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-10-06 13:20:06.000000000","tz":120},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2026-10-07 17:14:11.000000000","tz":120},"subject":"Add missing includes for C files and their own headers","message":"Add missing includes for C files and their own headers\n\nWe don\u0027t strictly need those, but it is much better to\nhave them since the compiler will then ensure that we\ndo not have subtle differences between declarations and\ndefinitions.\n\nAlso fix\n- socks.h not being able to be included on its own\n- open_tun_afunix stub for Windows having wrong\n  parameters\n\nChange-Id: I33b246dea9eb9383e1ca928e1330ba840b7f990c\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\nAcked-by: Razvan Cojocaru \u003crazvanc@mailbox.org\u003e\nGerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1984\nMessage-Id: \u003c20261006132012.30845-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg39737.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[]}