)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000035,"name":"Steffan Karger","display_name":"Steffan Karger","email":"steffan@karger.me","username":"syzzer","status":"Commits and comments are my own views, not those of my employer."},"change_message_id":"3ca45d8f11202f0abb7013aabe18c16bfdb1bc02","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"dea56c88_bdbf1c59","updated":"2026-10-06 19:27:36.000000000","message":"A few whitespace nits and one change that looks accidental to check before merging. \n\nReviewed using git range-diff to check where this differs from the commit in release/2.6 and ran local smoke tests. That all looks good.\n\nWould be good if @arne-openvpn@rfc2549.org could check this too, since it\u0027s originally his patch.","commit_id":"839053fc589d76782e799c427b5f9cce59aa2221"}],"src/openvpn/ssl.c":[{"author":{"_account_id":1000035,"name":"Steffan Karger","display_name":"Steffan Karger","email":"steffan@karger.me","username":"syzzer","status":"Commits and comments are my own views, not those of my employer."},"change_message_id":"3ca45d8f11202f0abb7013aabe18c16bfdb1bc02","unresolved":true,"context_lines":[{"line_number":2273,"context_line":"         * push request, also signal that the client wants"},{"line_number":2274,"context_line":"         * to get push-reply messages without without requiring a round"},{"line_number":2275,"context_line":"         * trip for a push request message*/"},{"line_number":2276,"context_line":"        if (session-\u003eopt-\u003epull)"},{"line_number":2277,"context_line":"        {"},{"line_number":2278,"context_line":"            iv_proto |\u003d IV_PROTO_REQUEST_PUSH;"},{"line_number":2279,"context_line":"        }"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"bac2a286_9d1390a6","line":2276,"updated":"2026-10-06 19:27:36.000000000","message":"Whitespace-only change. Not needed, but doesn\u0027t hurt either.","commit_id":"839053fc589d76782e799c427b5f9cce59aa2221"},{"author":{"_account_id":1000035,"name":"Steffan Karger","display_name":"Steffan Karger","email":"steffan@karger.me","username":"syzzer","status":"Commits and comments are my own views, not those of my employer."},"change_message_id":"cbdeab8d4206b84d6aa61f97d03fcf6f9664515d","unresolved":false,"context_lines":[{"line_number":2273,"context_line":"         * push request, also signal that the client wants"},{"line_number":2274,"context_line":"         * to get push-reply messages without without requiring a round"},{"line_number":2275,"context_line":"         * trip for a push request message*/"},{"line_number":2276,"context_line":"        if (session-\u003eopt-\u003epull)"},{"line_number":2277,"context_line":"        {"},{"line_number":2278,"context_line":"            iv_proto |\u003d IV_PROTO_REQUEST_PUSH;"},{"line_number":2279,"context_line":"        }"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"4c4d9cbd_ee4d234c","line":2276,"in_reply_to":"6c2ee96f_dfd03e49","updated":"2026-10-13 18:29:35.000000000","message":"Acknowledged","commit_id":"839053fc589d76782e799c427b5f9cce59aa2221"},{"author":{"_account_id":1000030,"name":"Max Fillinger","email":"max@max-fillinger.net","username":"MaxF"},"change_message_id":"74053a1f4d48c96a7e93ee89e065afe51691ca5a","unresolved":true,"context_lines":[{"line_number":2273,"context_line":"         * push request, also signal that the client wants"},{"line_number":2274,"context_line":"         * to get push-reply messages without without requiring a round"},{"line_number":2275,"context_line":"         * trip for a push request message*/"},{"line_number":2276,"context_line":"        if (session-\u003eopt-\u003epull)"},{"line_number":2277,"context_line":"        {"},{"line_number":2278,"context_line":"            iv_proto |\u003d IV_PROTO_REQUEST_PUSH;"},{"line_number":2279,"context_line":"        }"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"6c2ee96f_dfd03e49","line":2276,"in_reply_to":"bac2a286_9d1390a6","updated":"2026-10-06 21:53:30.000000000","message":"The uncrustify hook wouldn\u0027t let me commit it without this change.","commit_id":"839053fc589d76782e799c427b5f9cce59aa2221"},{"author":{"_account_id":1000035,"name":"Steffan Karger","display_name":"Steffan Karger","email":"steffan@karger.me","username":"syzzer","status":"Commits and comments are my own views, not those of my employer."},"change_message_id":"3ca45d8f11202f0abb7013aabe18c16bfdb1bc02","unresolved":true,"context_lines":[{"line_number":2450,"context_line":"     * NCP options are processed and we have no extra state for NCP finished."},{"line_number":2451,"context_line":"     */"},{"line_number":2452,"context_line":"    if (session-\u003eopt-\u003eserver \u0026\u0026 (session-\u003eopt-\u003emode !\u003d MODE_SERVER"},{"line_number":2453,"context_line":"                                 || multi-\u003emulti_state \u003d\u003d CAS_SUCCEEDED))"},{"line_number":2454,"context_line":"    {"},{"line_number":2455,"context_line":"        if (ks-\u003eauthenticated \u003e KS_AUTH_FALSE)"},{"line_number":2456,"context_line":"        {"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"07f8dfa4_6bbb559d","line":2453,"updated":"2026-10-06 19:27:36.000000000","message":"Another whitespace-only change.","commit_id":"839053fc589d76782e799c427b5f9cce59aa2221"},{"author":{"_account_id":1000030,"name":"Max Fillinger","email":"max@max-fillinger.net","username":"MaxF"},"change_message_id":"74053a1f4d48c96a7e93ee89e065afe51691ca5a","unresolved":true,"context_lines":[{"line_number":2450,"context_line":"     * NCP options are processed and we have no extra state for NCP finished."},{"line_number":2451,"context_line":"     */"},{"line_number":2452,"context_line":"    if (session-\u003eopt-\u003eserver \u0026\u0026 (session-\u003eopt-\u003emode !\u003d MODE_SERVER"},{"line_number":2453,"context_line":"                                 || multi-\u003emulti_state \u003d\u003d CAS_SUCCEEDED))"},{"line_number":2454,"context_line":"    {"},{"line_number":2455,"context_line":"        if (ks-\u003eauthenticated \u003e KS_AUTH_FALSE)"},{"line_number":2456,"context_line":"        {"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"9afd2831_7b00a2d6","line":2453,"in_reply_to":"07f8dfa4_6bbb559d","updated":"2026-10-06 21:53:30.000000000","message":"Uncrustify, again.","commit_id":"839053fc589d76782e799c427b5f9cce59aa2221"},{"author":{"_account_id":1000035,"name":"Steffan Karger","display_name":"Steffan Karger","email":"steffan@karger.me","username":"syzzer","status":"Commits and comments are my own views, not those of my employer."},"change_message_id":"cbdeab8d4206b84d6aa61f97d03fcf6f9664515d","unresolved":false,"context_lines":[{"line_number":2450,"context_line":"     * NCP options are processed and we have no extra state for NCP finished."},{"line_number":2451,"context_line":"     */"},{"line_number":2452,"context_line":"    if (session-\u003eopt-\u003eserver \u0026\u0026 (session-\u003eopt-\u003emode !\u003d MODE_SERVER"},{"line_number":2453,"context_line":"                                 || multi-\u003emulti_state \u003d\u003d CAS_SUCCEEDED))"},{"line_number":2454,"context_line":"    {"},{"line_number":2455,"context_line":"        if (ks-\u003eauthenticated \u003e KS_AUTH_FALSE)"},{"line_number":2456,"context_line":"        {"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"31c52804_38af62f4","line":2453,"in_reply_to":"9afd2831_7b00a2d6","updated":"2026-10-13 18:29:35.000000000","message":"Acknowledged","commit_id":"839053fc589d76782e799c427b5f9cce59aa2221"},{"author":{"_account_id":1000035,"name":"Steffan Karger","display_name":"Steffan Karger","email":"steffan@karger.me","username":"syzzer","status":"Commits and comments are my own views, not those of my employer."},"change_message_id":"3ca45d8f11202f0abb7013aabe18c16bfdb1bc02","unresolved":true,"context_lines":[{"line_number":3103,"context_line":"    if (session-\u003etls_wrap.work.data \u003d\u003d dataptr)"},{"line_number":3104,"context_line":"    {"},{"line_number":3105,"context_line":"        msg(M_INFO, \"Warning buffer of freed TLS session is \""},{"line_number":3106,"context_line":"            \"still in use (tls_wrap.work.data)\");"},{"line_number":3107,"context_line":"        goto used;"},{"line_number":3108,"context_line":"    }"},{"line_number":3109,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":1,"id":"56f38879_ef0dee78","line":3106,"updated":"2026-10-06 19:27:36.000000000","message":"Whitespace-only","commit_id":"839053fc589d76782e799c427b5f9cce59aa2221"},{"author":{"_account_id":1000030,"name":"Max Fillinger","email":"max@max-fillinger.net","username":"MaxF"},"change_message_id":"74053a1f4d48c96a7e93ee89e065afe51691ca5a","unresolved":true,"context_lines":[{"line_number":3103,"context_line":"    if (session-\u003etls_wrap.work.data \u003d\u003d dataptr)"},{"line_number":3104,"context_line":"    {"},{"line_number":3105,"context_line":"        msg(M_INFO, \"Warning buffer of freed TLS session is \""},{"line_number":3106,"context_line":"            \"still in use (tls_wrap.work.data)\");"},{"line_number":3107,"context_line":"        goto used;"},{"line_number":3108,"context_line":"    }"},{"line_number":3109,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":1,"id":"af10120b_b214ca1d","line":3106,"in_reply_to":"56f38879_ef0dee78","updated":"2026-10-06 21:53:30.000000000","message":"Uncrustify, again.","commit_id":"839053fc589d76782e799c427b5f9cce59aa2221"},{"author":{"_account_id":1000035,"name":"Steffan Karger","display_name":"Steffan Karger","email":"steffan@karger.me","username":"syzzer","status":"Commits and comments are my own views, not those of my employer."},"change_message_id":"cbdeab8d4206b84d6aa61f97d03fcf6f9664515d","unresolved":false,"context_lines":[{"line_number":3103,"context_line":"    if (session-\u003etls_wrap.work.data \u003d\u003d dataptr)"},{"line_number":3104,"context_line":"    {"},{"line_number":3105,"context_line":"        msg(M_INFO, \"Warning buffer of freed TLS session is \""},{"line_number":3106,"context_line":"            \"still in use (tls_wrap.work.data)\");"},{"line_number":3107,"context_line":"        goto used;"},{"line_number":3108,"context_line":"    }"},{"line_number":3109,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":1,"id":"f83287b0_82fba0d9","line":3106,"in_reply_to":"af10120b_b214ca1d","updated":"2026-10-13 18:29:35.000000000","message":"Acknowledged","commit_id":"839053fc589d76782e799c427b5f9cce59aa2221"},{"author":{"_account_id":1000035,"name":"Steffan Karger","display_name":"Steffan Karger","email":"steffan@karger.me","username":"syzzer","status":"Commits and comments are my own views, not those of my employer."},"change_message_id":"3ca45d8f11202f0abb7013aabe18c16bfdb1bc02","unresolved":true,"context_lines":[{"line_number":3247,"context_line":"        move_session(multi, TM_ACTIVE, TM_UNTRUSTED, true, to_link);"},{"line_number":3248,"context_line":"        tas \u003d tls_authentication_status(multi, TLS_MULTI_AUTH_STATUS_INTERVAL);"},{"line_number":3249,"context_line":"        msg(D_TLS_DEBUG_LOW, \"TLS: tls_multi_process: initial untrusted \""},{"line_number":3250,"context_line":"            \"session promoted to %strusted\","},{"line_number":3251,"context_line":"            tas \u003d\u003d TLS_AUTHENTICATION_SUCCEEDED ? \"\" : \"semi-\");"},{"line_number":3252,"context_line":"    }"},{"line_number":3253,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":1,"id":"10450665_3180dcea","line":3250,"updated":"2026-10-06 19:27:36.000000000","message":"This changes the log message and logic around it. Is that needed or useful? Or just accidental result of resolving a merge conflict?","commit_id":"839053fc589d76782e799c427b5f9cce59aa2221"},{"author":{"_account_id":1000030,"name":"Max Fillinger","email":"max@max-fillinger.net","username":"MaxF"},"change_message_id":"74053a1f4d48c96a7e93ee89e065afe51691ca5a","unresolved":true,"context_lines":[{"line_number":3247,"context_line":"        move_session(multi, TM_ACTIVE, TM_UNTRUSTED, true, to_link);"},{"line_number":3248,"context_line":"        tas \u003d tls_authentication_status(multi, TLS_MULTI_AUTH_STATUS_INTERVAL);"},{"line_number":3249,"context_line":"        msg(D_TLS_DEBUG_LOW, \"TLS: tls_multi_process: initial untrusted \""},{"line_number":3250,"context_line":"            \"session promoted to %strusted\","},{"line_number":3251,"context_line":"            tas \u003d\u003d TLS_AUTHENTICATION_SUCCEEDED ? \"\" : \"semi-\");"},{"line_number":3252,"context_line":"    }"},{"line_number":3253,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":1,"id":"854a9a57_0d293370","line":3250,"in_reply_to":"10450665_3180dcea","updated":"2026-10-06 21:53:30.000000000","message":"Accidental, I reverted to the old log message. While doing so, uncrustify found something else unrelated to complain about for some reason.","commit_id":"839053fc589d76782e799c427b5f9cce59aa2221"},{"author":{"_account_id":1000035,"name":"Steffan Karger","display_name":"Steffan Karger","email":"steffan@karger.me","username":"syzzer","status":"Commits and comments are my own views, not those of my employer."},"change_message_id":"cbdeab8d4206b84d6aa61f97d03fcf6f9664515d","unresolved":false,"context_lines":[{"line_number":3247,"context_line":"        move_session(multi, TM_ACTIVE, TM_UNTRUSTED, true, to_link);"},{"line_number":3248,"context_line":"        tas \u003d tls_authentication_status(multi, TLS_MULTI_AUTH_STATUS_INTERVAL);"},{"line_number":3249,"context_line":"        msg(D_TLS_DEBUG_LOW, \"TLS: tls_multi_process: initial untrusted \""},{"line_number":3250,"context_line":"            \"session promoted to %strusted\","},{"line_number":3251,"context_line":"            tas \u003d\u003d TLS_AUTHENTICATION_SUCCEEDED ? \"\" : \"semi-\");"},{"line_number":3252,"context_line":"    }"},{"line_number":3253,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":1,"id":"82f0725e_c6627dfe","line":3250,"in_reply_to":"854a9a57_0d293370","updated":"2026-10-13 18:29:35.000000000","message":"Done","commit_id":"839053fc589d76782e799c427b5f9cce59aa2221"}]}