)]}'
{"id":"openvpn~1985","triplet_id":"openvpn~release%2F2.5~I64920ed9f714803604d76c6df6b38cf20ce7626d","project":"openvpn","branch":"release/2.5","full_branch":"refs/heads/release/2.5","attention_set":{"1000030":{"account":{"_account_id":1000030,"name":"Max Fillinger","email":"max@max-fillinger.net","username":"MaxF"},"last_update":"2026-10-13 18:29:35.000000000","reason":"Someone else replied on the change"}},"removed_from_attention_set":{"1000035":{"account":{"_account_id":1000035,"name":"Steffan Karger","display_name":"Steffan Karger","email":"steffan@karger.me","username":"syzzer","status":"Commits and comments are my own views, not those of my employer."},"last_update":"2026-10-13 18:29:35.000000000","reason":"removed on reply"}},"hashtags":[],"change_id":"I64920ed9f714803604d76c6df6b38cf20ce7626d","subject":"Move check_session_buf_not_used method into the method that free the buffer","status":"NEW","created":"2026-10-06 18:17:41.000000000","updated":"2026-10-13 18:29:35.000000000","submit_type":"CHERRY_PICK","total_comment_count":13,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"cbdeab8d4206b84d6aa61f97d03fcf6f9664515d","_number":1985,"virtual_id_number":1985,"owner":{"_account_id":1000030,"name":"Max Fillinger","email":"max@max-fillinger.net","username":"MaxF"},"actions":{},"labels":{"Code-Review":{"approved":{"_account_id":1000035,"name":"Steffan Karger","display_name":"Steffan Karger","email":"steffan@karger.me","username":"syzzer","status":"Commits and comments are my own views, not those of my employer."},"all":[{"value":2,"date":"2026-10-13 18:29:35.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":1000035,"name":"Steffan Karger","display_name":"Steffan Karger","email":"steffan@karger.me","username":"syzzer","status":"Commits and comments are my own views, not those of my employer."}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000035,"name":"Steffan Karger","display_name":"Steffan Karger","email":"steffan@karger.me","username":"syzzer","status":"Commits and comments are my own views, not those of my employer."}],"CC":[{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-10-06 18:17:41.000000000","updated_by":{"_account_id":1000030,"name":"Max Fillinger","email":"max@max-fillinger.net","username":"MaxF"},"real_updated_by":{"_account_id":1000030,"name":"Max Fillinger","email":"max@max-fillinger.net","username":"MaxF"},"reviewer":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"CC"},{"updated":"2026-10-06 18:17:42.000000000","updated_by":{"_account_id":1000030,"name":"Max Fillinger","email":"max@max-fillinger.net","username":"MaxF"},"real_updated_by":{"_account_id":1000030,"name":"Max Fillinger","email":"max@max-fillinger.net","username":"MaxF"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2026-10-06 19:27:36.000000000","updated_by":{"_account_id":1000035,"name":"Steffan Karger","display_name":"Steffan Karger","email":"steffan@karger.me","username":"syzzer","status":"Commits and comments are my own views, not those of my employer."},"real_updated_by":{"_account_id":1000035,"name":"Steffan Karger","display_name":"Steffan Karger","email":"steffan@karger.me","username":"syzzer","status":"Commits and comments are my own views, not those of my employer."},"reviewer":{"_account_id":1000035,"name":"Steffan Karger","display_name":"Steffan Karger","email":"steffan@karger.me","username":"syzzer","status":"Commits and comments are my own views, not those of my employer."},"state":"REVIEWER"}],"messages":[{"id":"689c96ec09980ad52d7054cde50980842fb387cf","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000030,"name":"Max Fillinger","email":"max@max-fillinger.net","username":"MaxF"},"date":"2026-10-06 18:17:41.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"3ca45d8f11202f0abb7013aabe18c16bfdb1bc02","author":{"_account_id":1000035,"name":"Steffan Karger","display_name":"Steffan Karger","email":"steffan@karger.me","username":"syzzer","status":"Commits and comments are my own views, not those of my employer."},"date":"2026-10-06 19:27:36.000000000","message":"Patch Set 1: Code-Review-1\n\n(5 comments)","accounts_in_message":[],"_revision_number":1},{"id":"f6a5976da69932f96e9a8d62902178c892e2a9d9","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000030,"name":"Max Fillinger","email":"max@max-fillinger.net","username":"MaxF"},"date":"2026-10-06 21:51:21.000000000","message":"Uploaded patch set 2.\n\nOutdated Votes:\n* Code-Review-1 (copy condition: \"changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR is:MIN\")\n","accounts_in_message":[],"_revision_number":2},{"id":"74053a1f4d48c96a7e93ee89e065afe51691ca5a","author":{"_account_id":1000030,"name":"Max Fillinger","email":"max@max-fillinger.net","username":"MaxF"},"date":"2026-10-06 21:53:30.000000000","message":"Patch Set 1:\n\n(4 comments)","accounts_in_message":[],"_revision_number":1},{"id":"d8bf722011bbf609be97297ae3973432a5e40ba1","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000030,"name":"Max Fillinger","email":"max@max-fillinger.net","username":"MaxF"},"date":"2026-10-07 10:29:27.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"cbdeab8d4206b84d6aa61f97d03fcf6f9664515d","author":{"_account_id":1000035,"name":"Steffan Karger","display_name":"Steffan Karger","email":"steffan@karger.me","username":"syzzer","status":"Commits and comments are my own views, not those of my employer."},"date":"2026-10-13 18:29:35.000000000","message":"Patch Set 3: Code-Review+2\n\n(4 comments)","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"25b617465c79b2b7a5609f1f1a4194162168fd15","revisions":{"839053fc589d76782e799c427b5f9cce59aa2221":{"kind":"REWORK","_number":1,"created":"2026-10-06 18:17:41.000000000","uploader":{"_account_id":1000030,"name":"Max Fillinger","email":"max@max-fillinger.net","username":"MaxF"},"ref":"refs/changes/85/1985/1","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/85/1985/1","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/85/1985/1 \u0026\u0026 git checkout -b change-1985 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/85/1985/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/85/1985/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/85/1985/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/85/1985/1","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/85/1985/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"69e40fabd902321e8d30622094d6ea7bf9992db1","subject":"Backport stricter check for valid tokens"}],"author":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2026-09-03 06:12:02.000000000","tz":120},"committer":{"name":"Max Fillinger","email":"maximilian.fillinger@sentyron.com","date":"2026-10-06 18:12:52.000000000","tz":120},"subject":"Move check_session_buf_not_used method into the method that free the buffer","message":"Move check_session_buf_not_used method into the method that free the buffer\n\nThis cleans the code up a bit and ensure that we do not miss an invocation\nof a problematic code path. This is still a band-aid fix and a real fix\nrequires more refactoring and changing the logic.\n\nv2: sprinkle some \"const\" over check_keystate_buf_not_used() args\nv3: add missing doxygen for to_link parameter to tls_session_free()\n\nCVE: 2026-84471\nReported-By: Andreas Gabriel Berbescu \u003caberbescu@gmail.com\u003e\nTested-By: Andreas Gabriel Berbescu \u003caberbescu@gmail.com\u003e\nGithub: openvpn/openvpn-private-issues#157\nReported-By: Haruki Oyama (Waseda University)\nGithub: openvpn/openvpn-private-issues#132\nChange-Id: I64920ed9f714803604d76c6df6b38cf20ce7626d\nSigned-off-by: Arne Schwabe \u003carne@rfc2549.org\u003e\nGerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1893\nAcked-by: MaxF \u003cmax@max-fillinger.net\u003e\nMessage-Id: \u003c20260903061209.12599-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg38913.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n(cherry picked from commit 2a881d737b2562ee28247148160cfb60f0ba4645)\n"},"branch":"refs/heads/release/2.5"},"57ab873ae6a4ce3f1352838ed33ca090ef89d5c9":{"kind":"REWORK","_number":2,"created":"2026-10-06 21:51:21.000000000","uploader":{"_account_id":1000030,"name":"Max Fillinger","email":"max@max-fillinger.net","username":"MaxF"},"ref":"refs/changes/85/1985/2","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/85/1985/2","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/85/1985/2 \u0026\u0026 git checkout -b change-1985 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/85/1985/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/85/1985/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/85/1985/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/85/1985/2","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/85/1985/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"69e40fabd902321e8d30622094d6ea7bf9992db1","subject":"Backport stricter check for valid tokens"}],"author":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2026-09-03 06:12:02.000000000","tz":120},"committer":{"name":"Max Fillinger","email":"max@max-fillinger.net","date":"2026-10-06 21:50:31.000000000","tz":120},"subject":"Move check_session_buf_not_used method into the method that free the buffer","message":"Move check_session_buf_not_used method into the method that free the buffer\n\nThis cleans the code up a bit and ensure that we do not miss an invocation\nof a problematic code path. This is still a band-aid fix and a real fix\nrequires more refactoring and changing the logic.\n\nv2: sprinkle some \"const\" over check_keystate_buf_not_used() args\nv3: add missing doxygen for to_link parameter to tls_session_free()\n\nCVE: 2026-84471\nReported-By: Andreas Gabriel Berbescu \u003caberbescu@gmail.com\u003e\nTested-By: Andreas Gabriel Berbescu \u003caberbescu@gmail.com\u003e\nGithub: openvpn/openvpn-private-issues#157\nReported-By: Haruki Oyama (Waseda University)\nGithub: openvpn/openvpn-private-issues#132\nChange-Id: I64920ed9f714803604d76c6df6b38cf20ce7626d\nSigned-off-by: Arne Schwabe \u003carne@rfc2549.org\u003e\nGerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1893\nAcked-by: MaxF \u003cmax@max-fillinger.net\u003e\nMessage-Id: \u003c20260903061209.12599-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg38913.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n(cherry picked from commit 2a881d737b2562ee28247148160cfb60f0ba4645)\n"},"branch":"refs/heads/release/2.5"},"25b617465c79b2b7a5609f1f1a4194162168fd15":{"kind":"REWORK","_number":3,"created":"2026-10-07 10:29:27.000000000","uploader":{"_account_id":1000030,"name":"Max Fillinger","email":"max@max-fillinger.net","username":"MaxF"},"ref":"refs/changes/85/1985/3","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/85/1985/3","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/85/1985/3 \u0026\u0026 git checkout -b change-1985 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/85/1985/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/85/1985/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/85/1985/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/85/1985/3","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/85/1985/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"69e40fabd902321e8d30622094d6ea7bf9992db1","subject":"Backport stricter check for valid tokens"}],"author":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2026-09-03 06:12:02.000000000","tz":120},"committer":{"name":"Max Fillinger","email":"maximilian.fillinger@sentyron.com","date":"2026-10-07 10:18:16.000000000","tz":120},"subject":"Move check_session_buf_not_used method into the method that free the buffer","message":"Move check_session_buf_not_used method into the method that free the buffer\n\nThis cleans the code up a bit and ensure that we do not miss an invocation\nof a problematic code path. This is still a band-aid fix and a real fix\nrequires more refactoring and changing the logic.\n\nv2: sprinkle some \"const\" over check_keystate_buf_not_used() args\nv3: add missing doxygen for to_link parameter to tls_session_free()\n\nCVE: 2026-84471\nReported-By: Andreas Gabriel Berbescu \u003caberbescu@gmail.com\u003e\nTested-By: Andreas Gabriel Berbescu \u003caberbescu@gmail.com\u003e\nGithub: openvpn/openvpn-private-issues#157\nReported-By: Haruki Oyama (Waseda University)\nGithub: openvpn/openvpn-private-issues#132\nChange-Id: I64920ed9f714803604d76c6df6b38cf20ce7626d\nSigned-off-by: Arne Schwabe \u003carne@rfc2549.org\u003e\nGerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1893\nAcked-by: MaxF \u003cmax@max-fillinger.net\u003e\nMessage-Id: \u003c20260903061209.12599-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg38913.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n(cherry picked from commit 2a881d737b2562ee28247148160cfb60f0ba4645)\n"},"branch":"refs/heads/release/2.5"}},"requirements":[{"status":"NOT_READY","fallback_text":"All required checks must pass","type":"checks_pass"}],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"OK","labels":[{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000035,"name":"Steffan Karger","display_name":"Steffan Karger","email":"steffan@karger.me","username":"syzzer","status":"Commits and comments are my own views, not those of my employer."}}]},{"rule_name":"checks~ChecksSubmitRule","status":"NOT_READY","requirements":[{"status":"NOT_READY","fallback_text":"All required checks must pass","type":"checks_pass"}]}]}