)]}'
{"id":"openvpn~1987","triplet_id":"openvpn~master~I47e0741c75832a8f3fe161769feb27ddbfba3cdd","project":"openvpn","branch":"master","full_branch":"refs/heads/master","topic":"buffer_cleanup","attention_set":{},"removed_from_attention_set":{"1000053":{"account":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"last_update":"2026-10-08 16:11:04.000000000","reason":"removed on reply"},"1000003":{"account":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2026-10-08 19:01:13.000000000","reason":"Change was submitted"},"1000001":{"account":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2026-10-08 19:01:13.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I47e0741c75832a8f3fe161769feb27ddbfba3cdd","subject":"buffer: Clean up rm_trailing_chars","status":"MERGED","created":"2026-10-08 14:36:06.000000000","updated":"2026-10-08 19:01:13.000000000","submitted":"2026-10-08 19:01:13.000000000","submitter":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":4,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"1987-buffer_cleanup","meta_rev_id":"c6b60f5952678e313a8434e10ef34d90d7bc3002","_number":1987,"virtual_id_number":1987,"owner":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},{"value":0,"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"reviewers":{"REVIEWER":[{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-10-08 14:36:07.000000000","updated_by":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"real_updated_by":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2026-10-08 14:36:07.000000000","updated_by":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"real_updated_by":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2026-10-08 14:48:11.000000000","updated_by":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"real_updated_by":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"reviewer":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"state":"REVIEWER"}],"messages":[{"id":"4a3ba17e71eeab695076e9d3dba666a02bfdbb99","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-10-08 14:36:06.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"9e79c1ce5918ef273f83250bd2b06beda4463e04","author":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"date":"2026-10-08 14:48:11.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"c904740437ec0ab944cd7a6ea1ded25fefedc7af","author":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"date":"2026-10-08 15:00:50.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"5f28e604081a7f6896b964b44b7bb11f5747d7e7","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-10-08 16:01:29.000000000","message":"Uploaded patch set 2.\n\nOutdated Votes:\n* Code-Review-1 (copy condition: \"changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR is:MIN\")\n","accounts_in_message":[],"_revision_number":2},{"id":"ad71c2f619d87b41aee19ce05ede9f4a8fa270bd","author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-10-08 16:02:43.000000000","message":"Patch Set 2:\n\n(2 comments)","accounts_in_message":[],"_revision_number":2},{"id":"114a56c614e9e350d79a08864f3a50820c666f83","author":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"date":"2026-10-08 16:11:04.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"c6b60f5952678e313a8434e10ef34d90d7bc3002","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2026-10-08 19:01:13.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"ec55ca56e7abe9c3824ca37c0f5939d758163db7","revisions":{"f4ece820dcfb9a84c3ba309abf687f1990e98f59":{"kind":"REWORK","_number":1,"created":"2026-10-08 14:36:06.000000000","uploader":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/87/1987/1","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/87/1987/1","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/87/1987/1 \u0026\u0026 git checkout -b change-1987 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/87/1987/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/87/1987/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/87/1987/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/87/1987/1","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/87/1987/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"3a78bd3912607e5a62dad0453d5fc8bc37619073","subject":"reliable: characterize the packet id comparisons before rewriting them"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-10-08 14:33:37.000000000","tz":120},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-10-08 14:35:53.000000000","tz":120},"subject":"buffer: Clean up rm_trailing_chars","message":"buffer: Clean up rm_trailing_chars\n\nThis is very weird code. We re-run strlen for\nevery char that we delete, even though we actually\nknow which char to test next. Avoid this.\n\nAlso add unit tests to make sure I did not break it.\n\nChange-Id: I47e0741c75832a8f3fe161769feb27ddbfba3cdd\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"86829f5cd9d89561c5eae4bb556b27432bc11f79":{"kind":"REWORK","_number":2,"created":"2026-10-08 16:01:29.000000000","uploader":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/87/1987/2","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/87/1987/2","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/87/1987/2 \u0026\u0026 git checkout -b change-1987 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/87/1987/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/87/1987/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/87/1987/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/87/1987/2","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/87/1987/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"2053743b421fb08fd90ece583fc563b6ae2e03b9","subject":"config.h.cmake.in: Fix issues with string functions"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-10-08 14:33:37.000000000","tz":120},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-10-08 16:00:52.000000000","tz":120},"subject":"buffer: Clean up rm_trailing_chars","message":"buffer: Clean up rm_trailing_chars\n\nThis is very weird code. We re-run strlen for\nevery char that we delete, even though we actually\nknow which char to test next. Avoid this.\n\nAlso add unit tests to make sure I did not break it.\n\nChange-Id: I47e0741c75832a8f3fe161769feb27ddbfba3cdd\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"ec55ca56e7abe9c3824ca37c0f5939d758163db7":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":3,"created":"2026-10-08 19:01:13.000000000","uploader":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/87/1987/3","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/87/1987/3","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/87/1987/3 \u0026\u0026 git checkout -b change-1987 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/87/1987/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/87/1987/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/87/1987/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/87/1987/3","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/87/1987/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"3a78bd3912607e5a62dad0453d5fc8bc37619073","subject":"reliable: characterize the packet id comparisons before rewriting them"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-10-08 16:13:24.000000000","tz":120},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2026-10-08 18:56:49.000000000","tz":120},"subject":"buffer: Clean up rm_trailing_chars","message":"buffer: Clean up rm_trailing_chars\n\nThis is very weird code. We re-run strlen for\nevery char that we delete, even though we actually\nknow which char to test next. Avoid this.\n\nAlso add unit tests to make sure I did not break it.\n\nChange-Id: I47e0741c75832a8f3fe161769feb27ddbfba3cdd\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\nAcked-by: Razvan Cojocaru \u003crazvanc@mailbox.org\u003e\nGerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1987\nMessage-Id: \u003c20261008161329.32304-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg39789.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[]}