)]}'
{"id":"openvpn~1990","triplet_id":"openvpn~master~Ib74788b0365f6b44383ce09cf7d4914bbe500f8a","project":"openvpn","branch":"master","full_branch":"refs/heads/master","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2026-10-12 20:01:24.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Ib74788b0365f6b44383ce09cf7d4914bbe500f8a","subject":"Make CRL reload EOF detection independent of stale error queue entries","status":"MERGED","created":"2026-10-12 07:35:22.000000000","updated":"2026-10-12 20:01:24.000000000","submitted":"2026-10-12 20:01:24.000000000","submitter":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"1990","meta_rev_id":"4f615c6cb74ba025b79d9da73b0941e4cf79a131","_number":1990,"virtual_id_number":1990,"owner":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},{"value":0,"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-10-12 07:35:23.000000000","updated_by":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"real_updated_by":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2026-10-12 08:12:25.000000000","updated_by":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"real_updated_by":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"reviewer":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"state":"REVIEWER"}],"messages":[{"id":"a7422753b2523d65fa13c85099e4b88ad7a0d8e6","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2026-10-12 07:35:22.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"36cbcc9f80a4e29acbee6b925f5db63662780042","author":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"date":"2026-10-12 08:12:25.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"4f615c6cb74ba025b79d9da73b0941e4cf79a131","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2026-10-12 20:01:24.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"15a1465f981bb3f1950056a8f82b91dfe5f3fdbc","revisions":{"2af9751442c600a902b3968f3a72ab5a5e4d2236":{"kind":"REWORK","_number":1,"created":"2026-10-12 07:35:22.000000000","uploader":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"ref":"refs/changes/90/1990/1","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/90/1990/1","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/90/1990/1 \u0026\u0026 git checkout -b change-1990 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/90/1990/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/90/1990/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/90/1990/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/90/1990/1","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/90/1990/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"6aab116b2955902fe81349e5cfd1e92f6a49fb8a","subject":"Do not look up the \"none\" cipher or digest in OpenSSL"}],"author":{"name":"Drew Blokzyl","email":"drew@linuxkids.com","date":"2026-09-10 11:08:34.000000000","tz":-240},"committer":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2026-10-12 07:35:02.000000000","tz":120},"subject":"Make CRL reload EOF detection independent of stale error queue entries","message":"Make CRL reload EOF detection independent of stale error queue entries\n\nbackend_tls_ctx_reload_crl() treats a NULL from PEM_read_bio_X509_CRL()\nas EOF when ERR_peek_error() shows PEM_R_NO_START_LINE. ERR_peek_error()\nreturns the OLDEST queued error, so any entry left behind earlier in the\nthread turns a clean EOF into a \"CRL: cannot read CRL from file\" warning,\nprints the unrelated errors as if they came from the CRL file, and still\ninstalls the CRLs already parsed. The previous commit removes the\nleftover that triggered this in practice; this one stops the loop from\ndepending on the queue being clean at all.\n\nIf the queue is not empty when the CRL is loaded, say so at D_LOW with\nthe queued errors, since that is a bug somewhere else worth seeing, then\nstart the loop from an empty queue so only errors raised by\nPEM_read_bio_X509_CRL() are visible. Test the error it raised last\nrather than the oldest one, and clear the queue on the EOF path instead\nof popping a single entry.\n\nChange-Id: Ib74788b0365f6b44383ce09cf7d4914bbe500f8a\nSigned-off-by: Drew Blokzyl \u003cdrew@linuxkids.com\u003e\nSigned-off-by: Arne Schwabe \u003carne@rfc2549.org\u003e\n"},"branch":"refs/heads/master"},"15a1465f981bb3f1950056a8f82b91dfe5f3fdbc":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":2,"created":"2026-10-12 20:01:24.000000000","uploader":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/90/1990/2","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/90/1990/2","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/90/1990/2 \u0026\u0026 git checkout -b change-1990 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/90/1990/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/90/1990/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/90/1990/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/90/1990/2","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/90/1990/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"984a5d08e5838afd5db8987837327de731798886","subject":"options: Introduce boolean_flag() and review usages of atoi_warn"}],"author":{"name":"Drew Blokzyl","email":"drew@linuxkids.com","date":"2026-10-12 10:26:47.000000000","tz":120},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2026-10-12 17:00:33.000000000","tz":120},"subject":"Make CRL reload EOF detection independent of stale error queue entries","message":"Make CRL reload EOF detection independent of stale error queue entries\n\nbackend_tls_ctx_reload_crl() treats a NULL from PEM_read_bio_X509_CRL()\nas EOF when ERR_peek_error() shows PEM_R_NO_START_LINE. ERR_peek_error()\nreturns the OLDEST queued error, so any entry left behind earlier in the\nthread turns a clean EOF into a \"CRL: cannot read CRL from file\" warning,\nprints the unrelated errors as if they came from the CRL file, and still\ninstalls the CRLs already parsed. The previous commit removes the\nleftover that triggered this in practice; this one stops the loop from\ndepending on the queue being clean at all.\n\nIf the queue is not empty when the CRL is loaded, say so at D_LOW with\nthe queued errors, since that is a bug somewhere else worth seeing, then\nstart the loop from an empty queue so only errors raised by\nPEM_read_bio_X509_CRL() are visible. Test the error it raised last\nrather than the oldest one, and clear the queue on the EOF path instead\nof popping a single entry.\n\nChange-Id: Ib74788b0365f6b44383ce09cf7d4914bbe500f8a\nSigned-off-by: Drew Blokzyl \u003cdrew@linuxkids.com\u003e\nSigned-off-by: Arne Schwabe \u003carne@rfc2549.org\u003e\nAcked-by: Razvan Cojocaru \u003crazvanc@mailbox.org\u003e\nGithub: OpenVPN/openvpn#1104\nGerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1990\nMessage-Id: \u003c20261012102657.13611-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg39839.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[]}