)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"change_message_id":"cd1639c6357c22a7aeba4d20a1b767c84607e5ed","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2026-10-13 16:18:29 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"buffer: Fix small issues buf_printf and buf_puts"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"- Fix documentation for buf_puts"},{"line_number":10,"context_line":"- Add UTs for buf_puts"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bf44caf2_47911318","line":7,"updated":"2026-10-14 07:13:39.000000000","message":"Is this missing an \"in\"?","commit_id":"a05840749fae02ea496242e2624097ed6817b9b2"},{"author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"ea1bdc3fb43897945591bbaecdde0bc5ff5784fc","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2026-10-13 16:18:29 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"buffer: Fix small issues buf_printf and buf_puts"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"- Fix documentation for buf_puts"},{"line_number":10,"context_line":"- Add UTs for buf_puts"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"197fc833_3acab81f","line":7,"in_reply_to":"bf44caf2_47911318","updated":"2026-10-14 11:30:05.000000000","message":"Done","commit_id":"a05840749fae02ea496242e2624097ed6817b9b2"}],"src/openvpn/buffer.h":[{"author":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"change_message_id":"cd1639c6357c22a7aeba4d20a1b767c84607e5ed","unresolved":true,"context_lines":[{"line_number":792,"context_line":" * @param buf   The buffer to append to."},{"line_number":793,"context_line":" * @param str   The null-terminated string to append."},{"line_number":794,"context_line":" *"},{"line_number":795,"context_line":" * @return true if the buffer was changed, i.e. at least one character was appended."},{"line_number":796,"context_line":" */"},{"line_number":797,"context_line":"bool buf_puts(struct buffer *buf, const char *str);"},{"line_number":798,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":1,"id":"3d7b7dff_7cce7db7","line":795,"updated":"2026-10-14 07:13:39.000000000","message":"`buf_puts(buf, \"\")` returns `true` whenever `cap \u003e 1` so that\u0027s not technically true.\n\nMaybe say \"false if there was no room to append anything\"?","commit_id":"a05840749fae02ea496242e2624097ed6817b9b2"},{"author":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"change_message_id":"050c37eba4ce84ec4c8ea3dba64600081a966588","unresolved":true,"context_lines":[{"line_number":792,"context_line":" * @param buf   The buffer to append to."},{"line_number":793,"context_line":" * @param str   The null-terminated string to append."},{"line_number":794,"context_line":" *"},{"line_number":795,"context_line":" * @return true if the buffer was changed, i.e. at least one character was appended."},{"line_number":796,"context_line":" */"},{"line_number":797,"context_line":"bool buf_puts(struct buffer *buf, const char *str);"},{"line_number":798,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":1,"id":"601e60de_efe382ea","line":795,"in_reply_to":"09b6961e_a7004139","updated":"2026-10-14 11:01:31.000000000","message":"I was thinking of the empty string: `buf_puts(buf, \"\")` with `cap \u003e 1` returns `true`, but nothing gets appended and the buffer is unchanged. So true really means \"there was room to append\", not \"something was appended\".","commit_id":"a05840749fae02ea496242e2624097ed6817b9b2"},{"author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"3befca4e985ab35b513b4d229a4586c430bc671c","unresolved":true,"context_lines":[{"line_number":792,"context_line":" * @param buf   The buffer to append to."},{"line_number":793,"context_line":" * @param str   The null-terminated string to append."},{"line_number":794,"context_line":" *"},{"line_number":795,"context_line":" * @return true if the buffer was changed, i.e. at least one character was appended."},{"line_number":796,"context_line":" */"},{"line_number":797,"context_line":"bool buf_puts(struct buffer *buf, const char *str);"},{"line_number":798,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":1,"id":"09b6961e_a7004139","line":795,"in_reply_to":"3d7b7dff_7cce7db7","updated":"2026-10-14 10:50:36.000000000","message":"I don\u0027t understand this one","commit_id":"a05840749fae02ea496242e2624097ed6817b9b2"},{"author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"ea1bdc3fb43897945591bbaecdde0bc5ff5784fc","unresolved":false,"context_lines":[{"line_number":792,"context_line":" * @param buf   The buffer to append to."},{"line_number":793,"context_line":" * @param str   The null-terminated string to append."},{"line_number":794,"context_line":" *"},{"line_number":795,"context_line":" * @return true if the buffer was changed, i.e. at least one character was appended."},{"line_number":796,"context_line":" */"},{"line_number":797,"context_line":"bool buf_puts(struct buffer *buf, const char *str);"},{"line_number":798,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":1,"id":"22d3fcbc_6f86f28b","line":795,"in_reply_to":"601e60de_efe382ea","updated":"2026-10-14 11:30:05.000000000","message":"Done","commit_id":"a05840749fae02ea496242e2624097ed6817b9b2"}],"tests/unit_tests/openvpn/test_buffer.c":[{"author":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"change_message_id":"cd1639c6357c22a7aeba4d20a1b767c84607e5ed","unresolved":true,"context_lines":[{"line_number":65,"context_line":"    assert_int_equal(BCAP(\u0026buf), 1); /* \\0 byte not part of len */"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    buf_printf(\u0026buf, \"%s\", \"more\");"},{"line_number":68,"context_line":"    assert_buf_equals_str(\u0026buf, \"123some text, t\");"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    buf_catrunc(\u0026buf, \"...\");"},{"line_number":71,"context_line":"    assert_buf_equals_str(\u0026buf, \"123some text...\");"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"af54758a_5f5c3f0d","line":68,"updated":"2026-10-14 07:13:39.000000000","message":"This passes with the old code as well. Intended?","commit_id":"a05840749fae02ea496242e2624097ed6817b9b2"},{"author":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"change_message_id":"80e6cb26e7e7db62454835354e93c60c1dd8e996","unresolved":false,"context_lines":[{"line_number":65,"context_line":"    assert_int_equal(BCAP(\u0026buf), 1); /* \\0 byte not part of len */"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    buf_printf(\u0026buf, \"%s\", \"more\");"},{"line_number":68,"context_line":"    assert_buf_equals_str(\u0026buf, \"123some text, t\");"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    buf_catrunc(\u0026buf, \"...\");"},{"line_number":71,"context_line":"    assert_buf_equals_str(\u0026buf, \"123some text...\");"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"ffed094b_b53d8478","line":68,"in_reply_to":"16d53d2a_2ec6f17a","updated":"2026-10-14 11:06:16.000000000","message":"Acknowledged","commit_id":"a05840749fae02ea496242e2624097ed6817b9b2"},{"author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"3befca4e985ab35b513b4d229a4586c430bc671c","unresolved":true,"context_lines":[{"line_number":65,"context_line":"    assert_int_equal(BCAP(\u0026buf), 1); /* \\0 byte not part of len */"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    buf_printf(\u0026buf, \"%s\", \"more\");"},{"line_number":68,"context_line":"    assert_buf_equals_str(\u0026buf, \"123some text, t\");"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    buf_catrunc(\u0026buf, \"...\");"},{"line_number":71,"context_line":"    assert_buf_equals_str(\u0026buf, \"123some text...\");"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"16d53d2a_2ec6f17a","line":68,"in_reply_to":"af54758a_5f5c3f0d","updated":"2026-10-14 10:50:36.000000000","message":"Yes, this was just to confirm the behavior. It did not change.","commit_id":"a05840749fae02ea496242e2624097ed6817b9b2"}]}