)]}'
{"id":"openvpn~1997","triplet_id":"openvpn~master~I1d6ed5d40910359b65b9f5c5d8f56ad3d3bc827a","project":"openvpn","branch":"master","full_branch":"refs/heads/master","topic":"strlcpy","attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2026-10-13 14:23:16.000000000","reason":"Reviewer was added"},"1000001":{"account":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2026-10-14 11:38:45.000000000","reason":"Someone else replied on the change"}},"removed_from_attention_set":{"1000053":{"account":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"last_update":"2026-10-14 11:38:45.000000000","reason":"removed on reply"}},"hashtags":[],"change_id":"I1d6ed5d40910359b65b9f5c5d8f56ad3d3bc827a","subject":"buffer: Fix small issues in buf_printf and buf_puts","status":"NEW","created":"2026-10-13 14:23:14.000000000","updated":"2026-10-14 11:56:59.000000000","submit_type":"CHERRY_PICK","total_comment_count":9,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"1a5f78f7dea6b6763b812849d90977f90bff354b","_number":1997,"virtual_id_number":1997,"owner":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"actions":{},"labels":{"Code-Review":{"approved":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"all":[{"value":2,"date":"2026-10-14 11:56:59.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-10-13 14:23:16.000000000","updated_by":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"real_updated_by":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2026-10-13 14:23:16.000000000","updated_by":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"real_updated_by":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2026-10-14 07:13:39.000000000","updated_by":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"real_updated_by":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"reviewer":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"state":"REVIEWER"}],"messages":[{"id":"8c6af40d915e619326fa0f12f91c1cc8163a8bf7","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-10-13 14:23:14.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"cd1639c6357c22a7aeba4d20a1b767c84607e5ed","author":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"date":"2026-10-14 07:13:39.000000000","message":"Patch Set 1: Code-Review-1\n\n(3 comments)","accounts_in_message":[],"_revision_number":1},{"id":"3befca4e985ab35b513b4d229a4586c430bc671c","author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-10-14 10:50:36.000000000","message":"Patch Set 1:\n\n(2 comments)","accounts_in_message":[],"_revision_number":1},{"id":"050c37eba4ce84ec4c8ea3dba64600081a966588","author":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"date":"2026-10-14 11:01:31.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"80e6cb26e7e7db62454835354e93c60c1dd8e996","author":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"date":"2026-10-14 11:06:16.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"20bc601508bb09412921052adb8fc15a9b25e346","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-10-14 11:28:57.000000000","message":"Uploaded patch set 2.\n\nOutdated Votes:\n* Code-Review-1 (copy condition: \"changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR is:MIN\")\n","accounts_in_message":[],"_revision_number":2},{"id":"ea1bdc3fb43897945591bbaecdde0bc5ff5784fc","author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-10-14 11:30:05.000000000","message":"Patch Set 2:\n\n(2 comments)","accounts_in_message":[],"_revision_number":2},{"id":"b94dcb76ffe303d063da9fc5fe5e69803bdd14b8","author":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"date":"2026-10-14 11:38:45.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"1a5f78f7dea6b6763b812849d90977f90bff354b","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-10-14 11:56:59.000000000","message":"Uploaded patch set 3: Patch Set 2 was rebased.\n\nCopied Votes:\n* Code-Review+2 (copy condition: \"changekind:NO_CHANGE OR **changekind:TRIVIAL_REBASE** OR is:MIN\")\n","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"40b3358be44d109b52f0c2beb4c57bb0ee4e7e2d","revisions":{"a05840749fae02ea496242e2624097ed6817b9b2":{"kind":"REWORK","_number":1,"created":"2026-10-13 14:23:14.000000000","uploader":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/97/1997/1","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/97/1997/1","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/97/1997/1 \u0026\u0026 git checkout -b change-1997 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/97/1997/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/97/1997/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/97/1997/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/97/1997/1","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/97/1997/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"041a72adf5fb8166d03d3dc9ef543207bfc6ccec","subject":"Replace strncat with strlcat"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-10-13 13:57:06.000000000","tz":120},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-10-13 14:18:29.000000000","tz":120},"subject":"buffer: Fix small issues buf_printf and buf_puts","message":"buffer: Fix small issues buf_printf and buf_puts\n\n- Fix documentation for buf_puts\n- Add UTs for buf_puts\nBoth of these changes based on a PR by\ncuishuang \u003cimcusg@gmail.com\u003e.\n\nIn both functions:\n- Remove obsolete manual adding of \\0\n- Do not try to append if we can only overwrite\n  the trailing \\0 byte\n\nChange-Id: I1d6ed5d40910359b65b9f5c5d8f56ad3d3bc827a\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"512103d0b5776e82beaeca0b200bc992b27f09c1":{"kind":"REWORK","_number":2,"created":"2026-10-14 11:28:57.000000000","uploader":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/97/1997/2","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/97/1997/2","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/97/1997/2 \u0026\u0026 git checkout -b change-1997 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/97/1997/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/97/1997/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/97/1997/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/97/1997/2","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/97/1997/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"5fb74caaaf6c7072dd50d05a84275d462e04cf1e","subject":"Replace strncat with strlcat"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-10-13 13:57:06.000000000","tz":120},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-10-14 11:26:00.000000000","tz":120},"subject":"buffer: Fix small issues in buf_printf and buf_puts","message":"buffer: Fix small issues in buf_printf and buf_puts\n\n- Remove unused and wrongly document return value\n  of buf_puts\n- Add UTs for buf_puts\nBoth of these changes based on a PR by\ncuishuang \u003cimcusg@gmail.com\u003e.\n\nIn both functions:\n- Remove obsolete manual adding of \\0\n- Do not try to append if we can only overwrite\n  the trailing \\0 byte\n\nChange-Id: I1d6ed5d40910359b65b9f5c5d8f56ad3d3bc827a\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"40b3358be44d109b52f0c2beb4c57bb0ee4e7e2d":{"kind":"TRIVIAL_REBASE","_number":3,"created":"2026-10-14 11:56:59.000000000","uploader":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/97/1997/3","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/97/1997/3","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/97/1997/3 \u0026\u0026 git checkout -b change-1997 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/97/1997/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/97/1997/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/97/1997/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/97/1997/3","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/97/1997/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"f598e350bab4a80bba9d9be162ab11485254c44c","subject":"Replace strncat with strlcat"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-10-13 13:57:06.000000000","tz":120},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-10-14 11:56:30.000000000","tz":120},"subject":"buffer: Fix small issues in buf_printf and buf_puts","message":"buffer: Fix small issues in buf_printf and buf_puts\n\n- Remove unused and wrongly document return value\n  of buf_puts\n- Add UTs for buf_puts\nBoth of these changes based on a PR by\ncuishuang \u003cimcusg@gmail.com\u003e.\n\nIn both functions:\n- Remove obsolete manual adding of \\0\n- Do not try to append if we can only overwrite\n  the trailing \\0 byte\n\nChange-Id: I1d6ed5d40910359b65b9f5c5d8f56ad3d3bc827a\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"OK","labels":[{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"}}]},{"rule_name":"checks~ChecksSubmitRule","status":"OK"}]}