)]}'
{"id":"openvpn~2014","triplet_id":"openvpn~master~I10ebb5821829bf738e58fec23f9f9dd65d4626d3","project":"openvpn","branch":"master","full_branch":"refs/heads/master","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2026-10-19 13:08:54.000000000","reason":"Change was submitted"},"1000002":{"account":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"last_update":"2026-10-18 14:53:31.000000000","reason":"removed on reply"}},"hashtags":[],"change_id":"I10ebb5821829bf738e58fec23f9f9dd65d4626d3","subject":"Fix cppcheck warnings on macOS","status":"MERGED","created":"2026-10-18 12:16:10.000000000","updated":"2026-10-19 13:08:54.000000000","submitted":"2026-10-19 13:08:54.000000000","submitter":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":3,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"2007-wconversion","meta_rev_id":"502d15b9f7c2dcd8789e9e9542c4ac74aef73778","_number":2014,"virtual_id_number":2014,"owner":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-10-18 12:16:10.000000000","updated_by":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"real_updated_by":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2026-10-18 12:45:01.000000000","updated_by":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"real_updated_by":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"state":"REVIEWER"}],"messages":[{"id":"e74283f8ff8b81f8b796ea2c3d21c5d3527feb02","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2026-10-18 12:16:10.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"050d7208b6c3d3f3c68cb9c0696abb6cb1625e2d","author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2026-10-18 12:45:01.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"997001c75a3059daf976b54d3fed2cb672d74ddb","author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2026-10-18 12:51:39.000000000","message":"Patch Set 1: -Code-Review\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"a56b811ca67359526a005c1cffd0bedf2c567756","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2026-10-18 14:45:18.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"71e4ff4ee8f08143d18a0cf594b5cf8001b19dab","author":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2026-10-18 14:45:40.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"bf248f7acd8a3d6586203c890f0468ec2a497fce","author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2026-10-18 14:53:31.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"502d15b9f7c2dcd8789e9e9542c4ac74aef73778","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2026-10-19 13:08:54.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"340b9021f401b6638392193db933c2af6c9e0db5","revisions":{"019f91d238c8bbf67bb6eeb8b795300b072bdcec":{"kind":"REWORK","_number":1,"created":"2026-10-18 12:16:10.000000000","uploader":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"ref":"refs/changes/14/2014/1","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/14/2014/1","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/14/2014/1 \u0026\u0026 git checkout -b change-2014 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/14/2014/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/14/2014/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/14/2014/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/14/2014/1","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/14/2014/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"dda75df387f83ae10741d74a516495466ca78964","subject":"configure: Add --enable-code-coverage"}],"author":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2026-10-18 11:59:53.000000000","tz":120},"committer":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2026-10-18 12:16:04.000000000","tz":120},"subject":"Fix cppcheck warnings on macOS","message":"Fix cppcheck warnings on macOS\n\n- Replace bzero with memset\n\n   memset is nowadays preferred to bzero\n\n- add_route_ipv6: Fix %d used with unsigned int\n- add const to two variables that can be const\n\nFound-By: cppcheck on macOS\nChange-Id: I10ebb5821829bf738e58fec23f9f9dd65d4626d3\n"},"branch":"refs/heads/master"},"262d36962c98a8ba3e5b6f4029bd9a21dca7389b":{"kind":"REWORK","_number":2,"created":"2026-10-18 14:45:18.000000000","uploader":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"ref":"refs/changes/14/2014/2","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/14/2014/2","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/14/2014/2 \u0026\u0026 git checkout -b change-2014 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/14/2014/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/14/2014/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/14/2014/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/14/2014/2","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/14/2014/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"43aee864957280d3fd060d477f90cb977708ddf9","subject":"Add --debug-aead-usage-limit-override option"}],"author":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2026-10-18 11:59:53.000000000","tz":120},"committer":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2026-10-18 14:44:58.000000000","tz":120},"subject":"Fix cppcheck warnings on macOS","message":"Fix cppcheck warnings on macOS\n\n- Replace bzero with CLEAR/memset\n\n   memset is nowadays preferred to bzero\n\n- add_route_ipv6: Fix %d used with unsigned int\n- add const to two variables that can be const\n\nFound-By: cppcheck on macOS\nChange-Id: I10ebb5821829bf738e58fec23f9f9dd65d4626d3\n"},"branch":"refs/heads/master"},"340b9021f401b6638392193db933c2af6c9e0db5":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":3,"created":"2026-10-19 13:08:54.000000000","uploader":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/14/2014/3","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/14/2014/3","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/14/2014/3 \u0026\u0026 git checkout -b change-2014 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/14/2014/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/14/2014/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/14/2014/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/14/2014/3","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/14/2014/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"9f5effdbe1734fb24de01e439ac2276e11f5987d","subject":"ssl_verify_mbedtls: Avoid conversion warning in x509_get_fingerprint"}],"author":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2026-10-18 14:54:06.000000000","tz":120},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2026-10-19 13:06:42.000000000","tz":120},"subject":"Fix cppcheck warnings on macOS","message":"Fix cppcheck warnings on macOS\n\n- Replace bzero with CLEAR/memset\n\n   memset is nowadays preferred to bzero\n\n- add_route_ipv6: Fix %d used with unsigned int\n- add const to two variables that can be const\n\nFound-By: cppcheck on macOS\nChange-Id: I10ebb5821829bf738e58fec23f9f9dd65d4626d3\nSigned-off-by: Arne Schwabe \u003carne-openvpn@rfc2549.org\u003e\nAcked-by: Gert Doering \u003cgert@greenie.muc.de\u003e\nGerrit URL: https://gerrit.openvpn.net/c/openvpn/+/2014\nMessage-Id: \u003c20261018145411.19775-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg40015.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[]}
