)]}'
{"id":"openvpn~2016","triplet_id":"openvpn~master~Id21a6b106c49d6647783e09a506add0726a1a6d2","project":"openvpn","branch":"master","full_branch":"refs/heads/master","attention_set":{"1000009":{"account":{"_account_id":1000009,"name":"Selva Nair","display_name":"Selva Nair","email":"selva.nair@gmail.com","username":"selvanair"},"last_update":"2026-10-18 14:27:01.000000000","reason":"\u003cGERRIT_ACCOUNT_1000006\u003e replied on the change","reason_account":{"_account_id":1000006,"name":"Heiko Hund","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"}},"1000008":{"account":{"_account_id":1000008,"name":"Lev Stipakov","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"last_update":"2026-10-18 14:27:01.000000000","reason":"\u003cGERRIT_ACCOUNT_1000006\u003e replied on the change","reason_account":{"_account_id":1000006,"name":"Heiko Hund","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"}},"1000003":{"account":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2026-10-18 13:10:08.000000000","reason":"Reviewer was added"}},"removed_from_attention_set":{},"hashtags":[],"change_id":"Id21a6b106c49d6647783e09a506add0726a1a6d2","subject":"openvpnserv: skip conversion of empty domain names","status":"NEW","created":"2026-10-18 13:10:07.000000000","updated":"2026-10-18 14:27:01.000000000","submit_type":"CHERRY_PICK","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"70488e3dc944bbaa42184d3179998c2eadebc7b0","_number":2016,"virtual_id_number":2016,"owner":{"_account_id":1000006,"name":"Heiko Hund","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":1000009,"name":"Selva Nair","display_name":"Selva Nair","email":"selva.nair@gmail.com","username":"selvanair"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":1000008,"name":"Lev Stipakov","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"_account_id":1000008,"name":"Lev Stipakov","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},{"_account_id":1000009,"name":"Selva Nair","display_name":"Selva Nair","email":"selva.nair@gmail.com","username":"selvanair"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-10-18 13:10:08.000000000","updated_by":{"_account_id":1000006,"name":"Heiko Hund","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"real_updated_by":{"_account_id":1000006,"name":"Heiko Hund","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2026-10-18 13:10:08.000000000","updated_by":{"_account_id":1000006,"name":"Heiko Hund","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"real_updated_by":{"_account_id":1000006,"name":"Heiko Hund","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"reviewer":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2026-10-18 14:27:01.000000000","updated_by":{"_account_id":1000006,"name":"Heiko Hund","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"real_updated_by":{"_account_id":1000006,"name":"Heiko Hund","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"reviewer":{"_account_id":1000009,"name":"Selva Nair","display_name":"Selva Nair","email":"selva.nair@gmail.com","username":"selvanair"},"state":"REVIEWER"},{"updated":"2026-10-18 14:27:01.000000000","updated_by":{"_account_id":1000006,"name":"Heiko Hund","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"real_updated_by":{"_account_id":1000006,"name":"Heiko Hund","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"reviewer":{"_account_id":1000008,"name":"Lev Stipakov","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"state":"REVIEWER"}],"messages":[{"id":"2fd5aae243bb770256a8a76fe09122c3ff4cdc62","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000006,"name":"Heiko Hund","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"date":"2026-10-18 13:10:07.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"dfb35d371c4281b2d50ce96d58024d0e34d7df1e","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000006,"name":"Heiko Hund","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"date":"2026-10-18 13:11:13.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"466d60c16156bd249281784e4561e96dde2d2afe","revisions":{"41f1d4dc99c8a8059cd789d9bd56cd95c6af8c5e":{"kind":"REWORK","_number":1,"created":"2026-10-18 13:10:07.000000000","uploader":{"_account_id":1000006,"name":"Heiko Hund","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"ref":"refs/changes/16/2016/1","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/16/2016/1","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/16/2016/1 \u0026\u0026 git checkout -b change-2016 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/16/2016/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/16/2016/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/16/2016/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/16/2016/1","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/16/2016/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"096cba6380113368a1c7bf73464d54289c311fd1","subject":"win: remove --register-dns"}],"author":{"name":"Heiko Hund","email":"heiko@ist.eigentlich.net","date":"2026-10-18 11:56:47.000000000","tz":120},"committer":{"name":"Heiko Hund","email":"heiko@ist.eigentlich.net","date":"2026-10-18 12:59:46.000000000","tz":120},"subject":"openvpnserv: skip conversion of empty domain names","message":"openvpnserv: skip conversion of empty domain names\n\nEmpty entries in an interface\u0027s comma separated domain list, were\nconverted to \".\" in the resulting MULTI_SZ and used as a match all\nin the resulting NRPT rules, so all DNS queries would be sent\nto that adapter\u0027s name server(s) instead of only the ones for its\ndomains. Such lists are not expected to be found in the registry,\nbut skip empty entries anyway, just to be sure.\n\nAlso rework the ConvertItfDnsDomains() unit tests to use a helper\nthat runs the conversion on an individually sized heap buffer with\neverything after the input poisoned. This detects terminators that\nare counted but not written, which zero-initialized stack buffers\nhid. Also add more tests for empty entries and buffer size boundaries.\n\nBonus: fix typo in related doxygen comment.\n\nReported-by: Marc Heuse \u003cmarc@srlabs.de\u003e\nChange-Id: Id21a6b106c49d6647783e09a506add0726a1a6d2\nSigned-off-by: Heiko Hund \u003cheiko@ist.eigentlich.net\u003e\n"},"branch":"refs/heads/master"},"466d60c16156bd249281784e4561e96dde2d2afe":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2026-10-18 13:11:13.000000000","uploader":{"_account_id":1000006,"name":"Heiko Hund","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"ref":"refs/changes/16/2016/2","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/16/2016/2","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/16/2016/2 \u0026\u0026 git checkout -b change-2016 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/16/2016/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/16/2016/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/16/2016/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/16/2016/2","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/16/2016/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"dda75df387f83ae10741d74a516495466ca78964","subject":"configure: Add --enable-code-coverage"}],"author":{"name":"Heiko Hund","email":"heiko@ist.eigentlich.net","date":"2026-10-18 11:56:47.000000000","tz":120},"committer":{"name":"Heiko Hund","email":"heiko@ist.eigentlich.net","date":"2026-10-18 13:10:47.000000000","tz":120},"subject":"openvpnserv: skip conversion of empty domain names","message":"openvpnserv: skip conversion of empty domain names\n\nEmpty entries in an interface\u0027s comma separated domain list, were\nconverted to \".\" in the resulting MULTI_SZ and used as a match all\nin the resulting NRPT rules, so all DNS queries would be sent\nto that adapter\u0027s name server(s) instead of only the ones for its\ndomains. Such lists are not expected to be found in the registry,\nbut skip empty entries anyway, just to be sure.\n\nAlso rework the ConvertItfDnsDomains() unit tests to use a helper\nthat runs the conversion on an individually sized heap buffer with\neverything after the input poisoned. This detects terminators that\nare counted but not written, which zero-initialized stack buffers\nhid. Also add more tests for empty entries and buffer size boundaries.\n\nBonus: fix typo in related doxygen comment.\n\nReported-by: Marc Heuse \u003cmarc@srlabs.de\u003e\nChange-Id: Id21a6b106c49d6647783e09a506add0726a1a6d2\nSigned-off-by: Heiko Hund \u003cheiko@ist.eigentlich.net\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"NOT_READY","labels":[{"label":"Code-Review","status":"NEED"}]},{"rule_name":"checks~ChecksSubmitRule","status":"OK"}]}