)]}'
{"id":"openvpn~2027","triplet_id":"openvpn~master~I26fe14053446dbd215f947910565c20318c34627","project":"openvpn","branch":"master","full_branch":"refs/heads/master","attention_set":{},"removed_from_attention_set":{"1000008":{"account":{"_account_id":1000008,"name":"Lev Stipakov","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"last_update":"2026-10-22 10:22:54.000000000","reason":"Change was submitted"},"1000003":{"account":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2026-10-22 10:22:54.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I26fe14053446dbd215f947910565c20318c34627","subject":"interactive: null-terminate iface.name in address and route handlers","status":"MERGED","created":"2026-10-21 07:15:15.000000000","updated":"2026-10-22 10:22:54.000000000","submitted":"2026-10-22 10:22:54.000000000","submitter":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"2027","meta_rev_id":"eaf3b0fc60b833d1f55887128223e3b42efdbec2","_number":2027,"virtual_id_number":2027,"owner":{"_account_id":1000008,"name":"Lev Stipakov","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000006,"name":"Heiko Hund","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},{"value":0,"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"reviewers":{"REVIEWER":[{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"_account_id":1000006,"name":"Heiko Hund","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-10-21 07:15:15.000000000","updated_by":{"_account_id":1000008,"name":"Lev Stipakov","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"real_updated_by":{"_account_id":1000008,"name":"Lev Stipakov","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2026-10-21 07:15:15.000000000","updated_by":{"_account_id":1000008,"name":"Lev Stipakov","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"real_updated_by":{"_account_id":1000008,"name":"Lev Stipakov","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"reviewer":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2026-10-21 16:54:28.000000000","updated_by":{"_account_id":1000006,"name":"Heiko Hund","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"real_updated_by":{"_account_id":1000006,"name":"Heiko Hund","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"reviewer":{"_account_id":1000006,"name":"Heiko Hund","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"state":"REVIEWER"}],"messages":[{"id":"f77a400005a79dcbc7ed8fbe72b620945c2a1b12","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000008,"name":"Lev Stipakov","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"date":"2026-10-21 07:15:15.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"bcbc87466059bdf8e907dfe1bf48955145800fa2","author":{"_account_id":1000006,"name":"Heiko Hund","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"date":"2026-10-21 16:54:28.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"eaf3b0fc60b833d1f55887128223e3b42efdbec2","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2026-10-22 10:22:54.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"5e520ccb3df9e2f3eb79e2a47d62d014bce5b9b8","revisions":{"e8e290fbb50ddd364bf6b40873bad982ca12dae7":{"kind":"REWORK","_number":1,"created":"2026-10-21 07:15:15.000000000","uploader":{"_account_id":1000008,"name":"Lev Stipakov","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"ref":"refs/changes/27/2027/1","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/27/2027/1","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/27/2027/1 \u0026\u0026 git checkout -b change-2027 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/27/2027/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/27/2027/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/27/2027/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/27/2027/1","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/27/2027/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"d662deca1a0fca531ee03b4c039896141badc155","subject":"test_pkt: Correct comment about which systems use ushort sin_family"}],"author":{"name":"Naveed Khan","email":"dxbnaveed.k@gmail.com","date":"2026-10-20 12:49:18.000000000","tz":330},"committer":{"name":"Lev Stipakov","email":"lev@openvpn.net","date":"2026-10-21 07:10:48.000000000","tz":180},"subject":"interactive: null-terminate iface.name in address and route handlers","message":"interactive: null-terminate iface.name in address and route handlers\n\nHandleAddressMessage() and HandleRouteMessage() pass the client supplied\ninterface name to InterfaceLuid() and strlen() without making sure it is\nnull-terminated. A pipe client sending a message with iface.index set to\nTUN_ADAPTER_INDEX_INVALID and a 256 byte name without a terminating NUL\nmakes the service read past the name into the remainder of the on-stack\npipe_message_t and beyond.\n\nThis is hardening rather than a fix for an exploitable bug: the trailing\nbytes only ever reach ConvertInterfaceAliasToLuid(), which fails on them,\nand nothing is returned to the client beyond an error code. Terminate the\nname anyway, like HandleDNSConfigMessage() and HandleDNSConfigNrptMessage()\nalready do.\n\nGithub: OpenVPN/openvpn#1130\nChange-Id: I26fe14053446dbd215f947910565c20318c34627\nSigned-off-by: Naveed Khan \u003cdxbnaveed.k@gmail.com\u003e\nSigned-off-by: Lev Stipakov \u003clev@openvpn.net\u003e\n"},"branch":"refs/heads/master"},"5e520ccb3df9e2f3eb79e2a47d62d014bce5b9b8":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":2,"created":"2026-10-22 10:22:54.000000000","uploader":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/27/2027/2","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/27/2027/2","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/27/2027/2 \u0026\u0026 git checkout -b change-2027 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/27/2027/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/27/2027/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/27/2027/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/27/2027/2","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/27/2027/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"a51224225e495d09d6d200c30c0c6c4a8fffb3d3","subject":"configure: Output compiler version"}],"author":{"name":"Naveed Khan","email":"dxbnaveed.k@gmail.com","date":"2026-10-21 16:57:29.000000000","tz":120},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2026-10-22 09:20:41.000000000","tz":120},"subject":"interactive: null-terminate iface.name in address and route handlers","message":"interactive: null-terminate iface.name in address and route handlers\n\nHandleAddressMessage() and HandleRouteMessage() pass the client supplied\ninterface name to InterfaceLuid() and strlen() without making sure it is\nnull-terminated. A pipe client sending a message with iface.index set to\nTUN_ADAPTER_INDEX_INVALID and a 256 byte name without a terminating NUL\nmakes the service read past the name into the remainder of the on-stack\npipe_message_t and beyond.\n\nThis is hardening rather than a fix for an exploitable bug: the trailing\nbytes only ever reach ConvertInterfaceAliasToLuid(), which fails on them,\nand nothing is returned to the client beyond an error code. Terminate the\nname anyway, like HandleDNSConfigMessage() and HandleDNSConfigNrptMessage()\nalready do.\n\nGithub: OpenVPN/openvpn#1130\nChange-Id: I26fe14053446dbd215f947910565c20318c34627\nSigned-off-by: Naveed Khan \u003cdxbnaveed.k@gmail.com\u003e\nSigned-off-by: Lev Stipakov \u003clev@openvpn.net\u003e\nAcked-by: Heiko Hund \u003cheiko@openvpn.net\u003e\nGerrit URL: https://gerrit.openvpn.net/c/openvpn/+/2027\nMessage-Id: \u003c20261021165735.11175-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg40085.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[]}