)]}'
{"id":"openvpn~2040","triplet_id":"openvpn~master~Iea151988f2fa120b1262051572604e3f42ef4b1c","project":"openvpn","branch":"master","full_branch":"refs/heads/master","attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2026-10-26 21:57:10.000000000","reason":"Reviewer was added"}},"removed_from_attention_set":{},"hashtags":[],"change_id":"Iea151988f2fa120b1262051572604e3f42ef4b1c","subject":"p2p: don\u0027t report WAIT/AUTH for a new session while connected","status":"NEW","created":"2026-10-26 21:57:09.000000000","updated":"2026-10-27 09:45:52.000000000","submit_type":"CHERRY_PICK","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"6d8aa249c03ca203dee32f62267a6275a70e8e26","_number":2040,"virtual_id_number":2040,"owner":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-10-26 21:57:10.000000000","updated_by":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"real_updated_by":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2026-10-26 21:57:10.000000000","updated_by":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"real_updated_by":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"reviewer":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"}],"messages":[{"id":"c3452eda8e25c0aa91c474d820c4421f09de27bd","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"date":"2026-10-26 21:57:09.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"b158cd98c313b815df0555c4f54bee996d4bb758","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"date":"2026-10-26 22:03:06.000000000","message":"Uploaded patch set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"6d8aa249c03ca203dee32f62267a6275a70e8e26","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"date":"2026-10-27 09:45:52.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"b88f198569da0953b6e64fcc5886f04d35802f9d","revisions":{"3ff05875a4425599b11d1cb3f6b8134f0d95fe76":{"kind":"REWORK","_number":1,"created":"2026-10-26 21:57:09.000000000","uploader":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"ref":"refs/changes/40/2040/1","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/40/2040/1","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/40/2040/1 \u0026\u0026 git checkout -b change-2040 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/40/2040/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/40/2040/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/40/2040/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/40/2040/1","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/40/2040/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"54a66f355ace8e89b25ed9e85c659d290eb700d2","subject":"run-cppcheck.sh: Make CPPCHECK_CHECK_LEVEL\u003dnormal the default"}],"author":{"name":"Antonio Quartulli","email":"antonio@mandelbit.com","date":"2026-10-26 21:43:25.000000000","tz":60},"committer":{"name":"Antonio Quartulli","email":"antonio@mandelbit.com","date":"2026-10-26 21:56:24.000000000","tz":60},"subject":"p2p: don\u0027t report WAIT/AUTH for a new session while connected","message":"p2p: don\u0027t report WAIT/AUTH for a new session while connected\n\nIn p2p mode, a hard reset that starts a new session moves the management\nstate to AUTH and WAIT even while the tunnel is up. If that session\nnever completes (e.g. an unauthenticated probe without tls-auth/tls-crypt,\nor a peer that gives up), CONNECTED is never announced again and the\nstate stays WAIT although the tunnel works fine.\n\nDon\u0027t announce AUTH/WAIT when an established session already exists.\nA successful new session still re-announces CONNECTED via\nCAS_RECONNECT_PENDING.\n\nAlso document that WAIT and AUTH are reported in p2p mode too.\n\nChange-Id: Iea151988f2fa120b1262051572604e3f42ef4b1c\nSigned-off-by: Antonio Quartulli \u003cantonio@mandelbit.com\u003e\n"},"branch":"refs/heads/master"},"c1a16cc7487324a97613d3be7f62d233999a1f9e":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2026-10-26 22:03:06.000000000","uploader":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"ref":"refs/changes/40/2040/2","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/40/2040/2","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/40/2040/2 \u0026\u0026 git checkout -b change-2040 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/40/2040/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/40/2040/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/40/2040/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/40/2040/2","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/40/2040/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"54a66f355ace8e89b25ed9e85c659d290eb700d2","subject":"run-cppcheck.sh: Make CPPCHECK_CHECK_LEVEL\u003dnormal the default"}],"author":{"name":"Antonio Quartulli","email":"antonio@mandelbit.com","date":"2026-10-26 21:43:25.000000000","tz":60},"committer":{"name":"Antonio Quartulli","email":"antonio@mandelbit.com","date":"2026-10-26 22:02:25.000000000","tz":60},"subject":"p2p: don\u0027t report WAIT/AUTH for a new session while connected","message":"p2p: don\u0027t report WAIT/AUTH for a new session while connected\n\nIn p2p mode, a hard reset that starts a new session moves the management\nstate to AUTH and WAIT even while the tunnel is up. If that session\nnever completes (e.g. an unauthenticated probe without tls-auth/tls-crypt,\nor a peer that gives up), CONNECTED is never announced again and the\nstate stays WAIT although the tunnel works fine.\n\nDon\u0027t announce AUTH/WAIT when an established session already exists.\nA successful new session still re-announces CONNECTED via\nCAS_RECONNECT_PENDING.\n\nAlso document that WAIT and AUTH are reported in p2p mode too.\n\nChange-Id: Iea151988f2fa120b1262051572604e3f42ef4b1c\nLink: https://bugzilla.ipfire.org/show_bug.cgi?id\u003d13897\nReported-by: Neil Chittenden \u003cneilchittenden@quintessa.org\u003e\nSigned-off-by: Antonio Quartulli \u003cantonio@mandelbit.com\u003e\n"},"branch":"refs/heads/master"},"b88f198569da0953b6e64fcc5886f04d35802f9d":{"kind":"REWORK","_number":3,"created":"2026-10-27 09:45:52.000000000","uploader":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"ref":"refs/changes/40/2040/3","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/40/2040/3","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/40/2040/3 \u0026\u0026 git checkout -b change-2040 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/40/2040/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/40/2040/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/40/2040/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/40/2040/3","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/40/2040/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"54a66f355ace8e89b25ed9e85c659d290eb700d2","subject":"run-cppcheck.sh: Make CPPCHECK_CHECK_LEVEL\u003dnormal the default"}],"author":{"name":"Antonio Quartulli","email":"antonio@mandelbit.com","date":"2026-10-26 21:43:25.000000000","tz":60},"committer":{"name":"Antonio Quartulli","email":"antonio@mandelbit.com","date":"2026-10-27 09:23:23.000000000","tz":60},"subject":"p2p: don\u0027t report WAIT/AUTH for a new session while connected","message":"p2p: don\u0027t report WAIT/AUTH for a new session while connected\n\nIn p2p mode, a hard reset that starts a new session moves the management\nstate to AUTH and WAIT even while the tunnel is up. If that session\nnever completes (e.g. an unauthenticated probe without tls-auth/tls-crypt,\nor a peer that gives up), CONNECTED is never announced again and the\nstate stays WAIT although the tunnel works fine.\n\nDon\u0027t announce AUTH/WAIT when an established session already exists.\nA successful new session still re-announces CONNECTED via\nCAS_RECONNECT_PENDING.\n\nAlso document that WAIT and AUTH are reported in p2p mode too.\n\nChange-Id: Iea151988f2fa120b1262051572604e3f42ef4b1c\nLink: https://bugzilla.ipfire.org/show_bug.cgi?id\u003d13897\nReported-by: Neil Chittenden \u003cneilchittenden@quintessa.org\u003e\nSigned-off-by: Antonio Quartulli \u003cantonio@mandelbit.com\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"NOT_READY","labels":[{"label":"Code-Review","status":"NEED"}]},{"rule_name":"checks~ChecksSubmitRule","status":"OK"}]}