)]}'
{"id":"openvpn~2046","triplet_id":"openvpn~master~Ia7a31ff1c3792104101cb2e828be3b7fd8f44156","project":"openvpn","branch":"master","full_branch":"refs/heads/master","topic":"multisocket_cleanup","attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2026-10-27 09:46:38.000000000","reason":"Reviewer was added"},"1000034":{"account":{"_account_id":1000034,"name":"Gianmarco De Gregori","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"last_update":"2026-11-03 10:24:51.000000000","reason":"Someone else replied on the change"}},"removed_from_attention_set":{"1000053":{"account":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"last_update":"2026-11-03 11:21:48.000000000","reason":"removed on reply"}},"hashtags":[],"change_id":"Ia7a31ff1c3792104101cb2e828be3b7fd8f44156","subject":"multi_io: dispatch UDP events through TA_SOCKET_READ/TA_SOCKET_WRITE","status":"NEW","created":"2026-10-27 09:46:33.000000000","updated":"2026-11-03 11:21:48.000000000","submit_type":"CHERRY_PICK","total_comment_count":5,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"79a596803aea1f899950aa658423a8e354d2d22d","_number":2046,"virtual_id_number":2046,"owner":{"_account_id":1000034,"name":"Gianmarco De Gregori","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"actions":{},"labels":{"Code-Review":{"approved":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"all":[{"value":2,"date":"2026-11-03 11:21:48.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-10-27 09:46:38.000000000","updated_by":{"_account_id":1000034,"name":"Gianmarco De Gregori","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"real_updated_by":{"_account_id":1000034,"name":"Gianmarco De Gregori","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2026-10-27 09:46:38.000000000","updated_by":{"_account_id":1000034,"name":"Gianmarco De Gregori","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"real_updated_by":{"_account_id":1000034,"name":"Gianmarco De Gregori","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"reviewer":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2026-10-27 11:36:59.000000000","updated_by":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"real_updated_by":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"reviewer":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"state":"REVIEWER"}],"messages":[{"id":"09e7e03c4ff1271ef4d2ef6a1ccf4e9ed3c9b189","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000034,"name":"Gianmarco De Gregori","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"date":"2026-10-27 09:46:33.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"5c45c285f6b58c5c6d7b25d76ad1bbb103002a0f","author":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"date":"2026-10-27 11:36:59.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"5e35edb6970443653d253929c74120d477fb6288","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000034,"name":"Gianmarco De Gregori","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"date":"2026-11-03 08:57:30.000000000","message":"Uploaded patch set 2.\n\nOutdated Votes:\n* Code-Review-1 (copy condition: \"changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR is:MIN\")\n","accounts_in_message":[],"_revision_number":2},{"id":"f1abe83e14754e342d907edf9ad97584c50e31b7","author":{"_account_id":1000034,"name":"Gianmarco De Gregori","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"date":"2026-11-03 08:58:13.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"8c0c7fba93efd29a37e473b609bf4f1354cec656","author":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"date":"2026-11-03 09:39:45.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"ae978127b80fd5f41c6566ca1bc9a704fe644802","author":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"date":"2026-11-03 09:52:14.000000000","message":"Patch Set 2: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"39bdc5c5e4a3b71aa01fece0f899b9cf40597332","author":{"_account_id":1000034,"name":"Gianmarco De Gregori","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"date":"2026-11-03 10:06:57.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"11037f3b60a4218db79806592e3d46359eee962b","author":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"date":"2026-11-03 10:24:51.000000000","message":"Patch Set 2: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"8fa5696b81086dc39bd3710181d6934ec2c4a8c4","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000034,"name":"Gianmarco De Gregori","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"date":"2026-11-03 11:04:40.000000000","message":"Uploaded patch set 3.\n\nOutdated Votes:\n* Code-Review+2 (copy condition: \"changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR is:MIN\")\n","accounts_in_message":[],"_revision_number":3},{"id":"79a596803aea1f899950aa658423a8e354d2d22d","author":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"date":"2026-11-03 11:21:48.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"2c83d9e5d30c38ea1aa872ddb2a7d78de2920b95","revisions":{"5219cd07ee23243dbc5ed986ad78aab34458435b":{"kind":"REWORK","_number":1,"created":"2026-10-27 09:46:33.000000000","uploader":{"_account_id":1000034,"name":"Gianmarco De Gregori","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"ref":"refs/changes/46/2046/1","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/46/2046/1","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/46/2046/1 \u0026\u0026 git checkout -b change-2046 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/46/2046/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/46/2046/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/46/2046/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/46/2046/1","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/46/2046/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"0ad283c0198adbac3713822bd4c00ef5a615d7b6","subject":"multi_io: walk the link sockets once in multi_io_wait()"}],"author":{"name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","date":"2026-09-29 11:16:00.000000000","tz":120},"committer":{"name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","date":"2026-10-26 14:24:43.000000000","tz":60},"subject":"multi_io: dispatch UDP events through TA_SOCKET_READ/TA_SOCKET_WRITE","message":"multi_io: dispatch UDP events through TA_SOCKET_READ/TA_SOCKET_WRITE\n\nUDP socket events were handled by multi_process_io_udp() outside the\nmulti_io_action() state machine and re-entered it via TA_INITIAL,\nrunning multi_process_post() twice.\n\nDispatch them as TA_SOCKET_READ, with mi \u003d\u003d NULL and the socket passed\nexplicitly, and TA_SOCKET_WRITE, so that pending output is flushed\nwithin the same event. Drop multi_process_io_udp(); multi_io_send_link()\nhas no caller left outside multi_io.c and becomes static.\n\nChange-Id: Ia7a31ff1c3792104101cb2e828be3b7fd8f44156\nSigned-off-by: Gianmarco De Gregori \u003cgianmarco@mandelbit.com\u003e\n"},"branch":"refs/heads/master"},"be5e142bdaa1060f0fe42dc8f882a913d8a4e378":{"kind":"REWORK","_number":2,"created":"2026-11-03 08:57:30.000000000","uploader":{"_account_id":1000034,"name":"Gianmarco De Gregori","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"ref":"refs/changes/46/2046/2","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/46/2046/2","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/46/2046/2 \u0026\u0026 git checkout -b change-2046 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/46/2046/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/46/2046/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/46/2046/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/46/2046/2","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/46/2046/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"24946176aed52c23c52c956df43fd052c232f652","subject":"port-share: do not write journal file through symlinks or hardlinks"}],"author":{"name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","date":"2026-10-29 09:44:43.000000000","tz":60},"committer":{"name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","date":"2026-11-03 08:28:01.000000000","tz":60},"subject":"multi_io: dispatch UDP events through TA_SOCKET_READ/TA_SOCKET_WRITE","message":"multi_io: dispatch UDP events through TA_SOCKET_READ/TA_SOCKET_WRITE\n\nUDP socket events were handled by multi_process_io_udp() outside the\nmulti_io_action() state machine and re-entered it via TA_INITIAL,\nrunning multi_process_post() twice.\n\nDispatch them as TA_SOCKET_READ, with mi \u003d\u003d NULL and the socket passed\nexplicitly, and TA_SOCKET_WRITE, so that pending output is flushed\nwithin the same event. Drop multi_process_io_udp(); multi_io_send_link()\nhas no caller left outside multi_io.c and becomes static.\n\nTA_SOCKET_WRITE fell back to the bcast/c2c queue when there was no\npending instance, and only the queue drain at the end of\nmulti_io_process_io() relied on that. A UDP EVENT_WRITE would now reach\nthe fallback too and write a queued packet, possibly for a TCP instance,\noutside the drain. Let the drain extract the packets itself with\nmulti_get_queue(), and make TA_SOCKET_WRITE write only output that is\nalready prepared: the pending instance\u0027s, or else that of mi.\n\nChange-Id: Ia7a31ff1c3792104101cb2e828be3b7fd8f44156\nSigned-off-by: Gianmarco De Gregori \u003cgianmarco@mandelbit.com\u003e\n"},"branch":"refs/heads/master"},"2c83d9e5d30c38ea1aa872ddb2a7d78de2920b95":{"kind":"REWORK","_number":3,"created":"2026-11-03 11:04:40.000000000","uploader":{"_account_id":1000034,"name":"Gianmarco De Gregori","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"ref":"refs/changes/46/2046/3","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/46/2046/3","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/46/2046/3 \u0026\u0026 git checkout -b change-2046 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/46/2046/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/46/2046/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/46/2046/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/46/2046/3","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/46/2046/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"52757c8591e1d3003943aba7207c9eb24964a398","subject":"multi: resume deferred auth through multi_io_action()"}],"author":{"name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","date":"2026-10-29 09:44:43.000000000","tz":60},"committer":{"name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","date":"2026-11-03 10:13:46.000000000","tz":60},"subject":"multi_io: dispatch UDP events through TA_SOCKET_READ/TA_SOCKET_WRITE","message":"multi_io: dispatch UDP events through TA_SOCKET_READ/TA_SOCKET_WRITE\n\nUDP socket events were handled by multi_process_io_udp() outside the\nmulti_io_action() state machine and re-entered it via TA_INITIAL,\nrunning multi_process_post() twice.\n\nDispatch them as TA_SOCKET_READ, with mi \u003d\u003d NULL and the socket passed\nexplicitly, and TA_SOCKET_WRITE, so that pending output is flushed\nwithin the same event. Drop multi_process_io_udp(); multi_io_send_link()\nhas no caller left outside multi_io.c and becomes static.\n\nTA_SOCKET_WRITE fell back to the bcast/c2c queue when there was no\npending instance, and only the queue drain at the end of\nmulti_io_process_io() relied on that. A UDP EVENT_WRITE would now reach\nthe fallback too and write a queued packet, possibly for a TCP instance,\noutside the drain. Let the drain extract the packets itself with\nmulti_get_queue(), and make TA_SOCKET_WRITE write only output that is\nalready prepared: the pending instance\u0027s, or else that of mi.\n\nChange-Id: Ia7a31ff1c3792104101cb2e828be3b7fd8f44156\nSigned-off-by: Gianmarco De Gregori \u003cgianmarco@mandelbit.com\u003e\n"},"branch":"refs/heads/master"}},"requirements":[{"status":"NOT_READY","fallback_text":"All required checks must pass","type":"checks_pass"}],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"OK","labels":[{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"}}]},{"rule_name":"checks~ChecksSubmitRule","status":"NOT_READY","requirements":[{"status":"NOT_READY","fallback_text":"All required checks must pass","type":"checks_pass"}]}]}
