)]}'
{"id":"openvpn~2049","triplet_id":"openvpn~master~I4637d59ed1fba450e81518766526d934cd2902b7","project":"openvpn","branch":"master","full_branch":"refs/heads/master","topic":"multisocket_cleanup","attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2026-10-27 09:46:39.000000000","reason":"Reviewer was added"},"1000034":{"account":{"_account_id":1000034,"name":"Gianmarco De Gregori","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"last_update":"2026-11-03 10:29:40.000000000","reason":"Someone else replied on the change"}},"removed_from_attention_set":{},"hashtags":[],"change_id":"I4637d59ed1fba450e81518766526d934cd2902b7","subject":"multi_io: replace TA_INITIAL with TA_INSTANCE_POST","status":"NEW","created":"2026-10-27 09:46:33.000000000","updated":"2026-11-03 11:04:40.000000000","submit_type":"CHERRY_PICK","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"fa490d8aeef34cbd490b93a4249ec0d244b5d49f","_number":2049,"virtual_id_number":2049,"owner":{"_account_id":1000034,"name":"Gianmarco De Gregori","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"actions":{},"labels":{"Code-Review":{"approved":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"all":[{"value":2,"date":"2026-11-03 11:04:40.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-10-27 09:46:39.000000000","updated_by":{"_account_id":1000034,"name":"Gianmarco De Gregori","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"real_updated_by":{"_account_id":1000034,"name":"Gianmarco De Gregori","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2026-10-27 09:46:39.000000000","updated_by":{"_account_id":1000034,"name":"Gianmarco De Gregori","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"real_updated_by":{"_account_id":1000034,"name":"Gianmarco De Gregori","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"reviewer":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2026-11-03 10:29:40.000000000","updated_by":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"real_updated_by":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"reviewer":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"state":"REVIEWER"}],"messages":[{"id":"7ffc505f68271f79e3c41612deb57a58847ce466","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000034,"name":"Gianmarco De Gregori","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"date":"2026-10-27 09:46:33.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"7857493620f3d810ad82f75d65ac9812532877a9","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000034,"name":"Gianmarco De Gregori","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"date":"2026-11-03 08:57:30.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.","accounts_in_message":[],"_revision_number":2},{"id":"71507631ed4f2a8646915f79660ef47ae21a9920","author":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"date":"2026-11-03 10:29:40.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"fa490d8aeef34cbd490b93a4249ec0d244b5d49f","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000034,"name":"Gianmarco De Gregori","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"date":"2026-11-03 11:04:40.000000000","message":"Uploaded patch set 3: New patch set was added with same tree, parent tree, and commit message as Patch Set 2.\n\nCopied Votes:\n* Code-Review+2 (copy condition: \"**changekind:NO_CHANGE** OR **changekind:TRIVIAL_REBASE** OR is:MIN\")\n","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"716a4e95727ba062e6cfcf7b69173e18871149fb","revisions":{"1c809b56129c8ba881e3b10e4cc2dcf17e11fafb":{"kind":"REWORK","_number":1,"created":"2026-10-27 09:46:33.000000000","uploader":{"_account_id":1000034,"name":"Gianmarco De Gregori","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"ref":"refs/changes/49/2049/1","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/49/2049/1","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/49/2049/1 \u0026\u0026 git checkout -b change-2049 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/49/2049/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/49/2049/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/49/2049/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/49/2049/1","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/49/2049/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"b81e08f05de7470cde113f6d1bf0f3822b43429e","subject":"multi: remove m-\u003epending"}],"author":{"name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","date":"2026-10-08 12:11:51.000000000","tz":120},"committer":{"name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","date":"2026-10-26 14:24:43.000000000","tz":60},"subject":"multi_io: replace TA_INITIAL with TA_INSTANCE_POST","message":"multi_io: replace TA_INITIAL with TA_INSTANCE_POST\n\nTA_INITIAL is TA_INSTANCE_POST plus multi_tcp_set_global_rw_flags(),\nwhich multi_io_post() already calls once the instance has no output\nleft. Use TA_INSTANCE_POST for new TCP instances too and drop\nTA_INITIAL.\n\nWith UDP instances going through the state machine as well, make the\nMTP_NONE branch of multi_io_post() explicitly TCP only: reading the\nstream residual and re-arming the socket only make sense on a\nconnection-oriented socket. multi_tcp_set_global_rw_flags() is then\nnever called on a datagram instance, and loses its proto check.\n\nChange-Id: I4637d59ed1fba450e81518766526d934cd2902b7\nSigned-off-by: Gianmarco De Gregori \u003cgianmarco@mandelbit.com\u003e\n"},"branch":"refs/heads/master"},"d5a143bc66899e589d96571e8c93dbf3c7e3b52b":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2026-11-03 08:57:30.000000000","uploader":{"_account_id":1000034,"name":"Gianmarco De Gregori","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"ref":"refs/changes/49/2049/2","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/49/2049/2","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/49/2049/2 \u0026\u0026 git checkout -b change-2049 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/49/2049/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/49/2049/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/49/2049/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/49/2049/2","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/49/2049/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"aaba27c973311e58a96a9ecb06dec7f74cc6ece7","subject":"multi: remove m-\u003epending"}],"author":{"name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","date":"2026-10-08 12:11:51.000000000","tz":120},"committer":{"name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","date":"2026-11-03 08:28:01.000000000","tz":60},"subject":"multi_io: replace TA_INITIAL with TA_INSTANCE_POST","message":"multi_io: replace TA_INITIAL with TA_INSTANCE_POST\n\nTA_INITIAL is TA_INSTANCE_POST plus multi_tcp_set_global_rw_flags(),\nwhich multi_io_post() already calls once the instance has no output\nleft. Use TA_INSTANCE_POST for new TCP instances too and drop\nTA_INITIAL.\n\nWith UDP instances going through the state machine as well, make the\nMTP_NONE branch of multi_io_post() explicitly TCP only: reading the\nstream residual and re-arming the socket only make sense on a\nconnection-oriented socket. multi_tcp_set_global_rw_flags() is then\nnever called on a datagram instance, and loses its proto check.\n\nChange-Id: I4637d59ed1fba450e81518766526d934cd2902b7\nSigned-off-by: Gianmarco De Gregori \u003cgianmarco@mandelbit.com\u003e\n"},"branch":"refs/heads/master"},"716a4e95727ba062e6cfcf7b69173e18871149fb":{"kind":"NO_CHANGE","_number":3,"created":"2026-11-03 11:04:40.000000000","uploader":{"_account_id":1000034,"name":"Gianmarco De Gregori","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"ref":"refs/changes/49/2049/3","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/49/2049/3","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/49/2049/3 \u0026\u0026 git checkout -b change-2049 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/49/2049/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/49/2049/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/49/2049/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/49/2049/3","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/49/2049/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"a2423fc78b86cca9e8247194e2922537670cf2cf","subject":"multi: remove m-\u003epending"}],"author":{"name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","date":"2026-10-08 12:11:51.000000000","tz":120},"committer":{"name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","date":"2026-11-03 10:13:46.000000000","tz":60},"subject":"multi_io: replace TA_INITIAL with TA_INSTANCE_POST","message":"multi_io: replace TA_INITIAL with TA_INSTANCE_POST\n\nTA_INITIAL is TA_INSTANCE_POST plus multi_tcp_set_global_rw_flags(),\nwhich multi_io_post() already calls once the instance has no output\nleft. Use TA_INSTANCE_POST for new TCP instances too and drop\nTA_INITIAL.\n\nWith UDP instances going through the state machine as well, make the\nMTP_NONE branch of multi_io_post() explicitly TCP only: reading the\nstream residual and re-arming the socket only make sense on a\nconnection-oriented socket. multi_tcp_set_global_rw_flags() is then\nnever called on a datagram instance, and loses its proto check.\n\nChange-Id: I4637d59ed1fba450e81518766526d934cd2902b7\nSigned-off-by: Gianmarco De Gregori \u003cgianmarco@mandelbit.com\u003e\n"},"branch":"refs/heads/master"}},"requirements":[{"status":"NOT_READY","fallback_text":"All required checks must pass","type":"checks_pass"}],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"OK","labels":[{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"}}]},{"rule_name":"checks~ChecksSubmitRule","status":"NOT_READY","requirements":[{"status":"NOT_READY","fallback_text":"All required checks must pass","type":"checks_pass"}]}]}
