)]}'
{"id":"openvpn~2050","triplet_id":"openvpn~master~I4379a167419d464c000dca3c5c032aaebb6dac73","project":"openvpn","branch":"master","full_branch":"refs/heads/master","topic":"multisocket_cleanup","attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2026-10-27 09:46:39.000000000","reason":"Reviewer was added"},"1000034":{"account":{"_account_id":1000034,"name":"Gianmarco De Gregori","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"last_update":"2026-11-03 10:33:36.000000000","reason":"Someone else replied on the change"}},"removed_from_attention_set":{},"hashtags":[],"change_id":"I4379a167419d464c000dca3c5c032aaebb6dac73","subject":"multi_io: avoid redundant event_ctl() calls in multi_io_wait()","status":"NEW","created":"2026-10-27 09:46:33.000000000","updated":"2026-11-03 11:04:40.000000000","submit_type":"CHERRY_PICK","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"0c4a7c45fb0281b5c60b199bb23b291021873dee","_number":2050,"virtual_id_number":2050,"owner":{"_account_id":1000034,"name":"Gianmarco De Gregori","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"actions":{},"labels":{"Code-Review":{"approved":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"all":[{"value":2,"date":"2026-11-03 11:04:40.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-10-27 09:46:39.000000000","updated_by":{"_account_id":1000034,"name":"Gianmarco De Gregori","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"real_updated_by":{"_account_id":1000034,"name":"Gianmarco De Gregori","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2026-10-27 09:46:39.000000000","updated_by":{"_account_id":1000034,"name":"Gianmarco De Gregori","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"real_updated_by":{"_account_id":1000034,"name":"Gianmarco De Gregori","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"reviewer":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2026-11-03 10:33:36.000000000","updated_by":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"real_updated_by":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"reviewer":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"state":"REVIEWER"}],"messages":[{"id":"7aec7351f5e6c23ec2433fcb053a092e43d13799","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000034,"name":"Gianmarco De Gregori","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"date":"2026-10-27 09:46:33.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"c9dc5c84480f2c5f0369d2eaf912b10999d35a8b","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000034,"name":"Gianmarco De Gregori","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"date":"2026-11-03 08:57:30.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.","accounts_in_message":[],"_revision_number":2},{"id":"803fb7a9db6e0342a1d56d848b1be6367a1398da","author":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"date":"2026-11-03 10:33:36.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"0c4a7c45fb0281b5c60b199bb23b291021873dee","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000034,"name":"Gianmarco De Gregori","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"date":"2026-11-03 11:04:40.000000000","message":"Uploaded patch set 3: New patch set was added with same tree, parent tree, and commit message as Patch Set 2.\n\nCopied Votes:\n* Code-Review+2 (copy condition: \"**changekind:NO_CHANGE** OR **changekind:TRIVIAL_REBASE** OR is:MIN\")\n","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"ebd122de934d813b630f422930d5dac5fe6ca7f6","revisions":{"6f59a41b6af8349369c39d13db2adcf55d5b3c83":{"kind":"REWORK","_number":1,"created":"2026-10-27 09:46:33.000000000","uploader":{"_account_id":1000034,"name":"Gianmarco De Gregori","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"ref":"refs/changes/50/2050/1","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/50/2050/1","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/50/2050/1 \u0026\u0026 git checkout -b change-2050 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/50/2050/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/50/2050/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/50/2050/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/50/2050/1","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/50/2050/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"1c809b56129c8ba881e3b10e4cc2dcf17e11fafb","subject":"multi_io: replace TA_INITIAL with TA_INSTANCE_POST"}],"author":{"name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","date":"2026-10-12 08:50:57.000000000","tz":120},"committer":{"name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","date":"2026-10-26 14:24:43.000000000","tz":60},"subject":"multi_io: avoid redundant event_ctl() calls in multi_io_wait()","message":"multi_io: avoid redundant event_ctl() calls in multi_io_wait()\n\nmulti_io_wait() registered each server UDP socket through\nmulti_io_process_flags(), which calls socket_set() without a persistent\ncache and tun_set() once more for every UDP socket, also without a\ncache. Both ended up in an event_ctl() on every loop iteration even\nthough nothing changed.\n\nNow that the UDP sockets and the tun device are only ever armed for\nreading, set them directly with EVENT_READ, caching the UDP socket\nrwflags in the new link_socket.rwflags_persistent and the tun ones in\nmulti_io-\u003etun_rwflags.\n\nOn a server with two UDP and one TCP listener this removes the\nremaining epoll_ctl() calls from the loop (syscalls per received\npacket 4.64 -\u003e 3.36, UDP only 5.29 -\u003e 3.77); at saturation the\nserver delivers 2-7% more traffic with UDP and uses 4-13% less CPU\nat a fixed load.\n\nWith --enable-async-push the inotify descriptor was also registered on\nevery iteration; register it once (1504 -\u003e 12 epoll_ctl() with\ndeferred auth).\n\nChange-Id: I4379a167419d464c000dca3c5c032aaebb6dac73\nSigned-off-by: Gianmarco De Gregori \u003cgianmarco@mandelbit.com\u003e\n"},"branch":"refs/heads/master"},"fc14e738f3444f427df093c599963e518ad70efb":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2026-11-03 08:57:30.000000000","uploader":{"_account_id":1000034,"name":"Gianmarco De Gregori","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"ref":"refs/changes/50/2050/2","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/50/2050/2","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/50/2050/2 \u0026\u0026 git checkout -b change-2050 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/50/2050/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/50/2050/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/50/2050/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/50/2050/2","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/50/2050/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"d5a143bc66899e589d96571e8c93dbf3c7e3b52b","subject":"multi_io: replace TA_INITIAL with TA_INSTANCE_POST"}],"author":{"name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","date":"2026-10-12 08:50:57.000000000","tz":120},"committer":{"name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","date":"2026-11-03 08:28:01.000000000","tz":60},"subject":"multi_io: avoid redundant event_ctl() calls in multi_io_wait()","message":"multi_io: avoid redundant event_ctl() calls in multi_io_wait()\n\nmulti_io_wait() registered each server UDP socket through\nmulti_io_process_flags(), which calls socket_set() without a persistent\ncache and tun_set() once more for every UDP socket, also without a\ncache. Both ended up in an event_ctl() on every loop iteration even\nthough nothing changed.\n\nNow that the UDP sockets and the tun device are only ever armed for\nreading, set them directly with EVENT_READ, caching the UDP socket\nrwflags in the new link_socket.rwflags_persistent and the tun ones in\nmulti_io-\u003etun_rwflags.\n\nOn a server with two UDP and one TCP listener this removes the\nremaining epoll_ctl() calls from the loop (syscalls per received\npacket 4.64 -\u003e 3.36, UDP only 5.29 -\u003e 3.77); at saturation the\nserver delivers 2-7% more traffic with UDP and uses 4-13% less CPU\nat a fixed load.\n\nWith --enable-async-push the inotify descriptor was also registered on\nevery iteration; register it once (1504 -\u003e 12 epoll_ctl() with\ndeferred auth).\n\nChange-Id: I4379a167419d464c000dca3c5c032aaebb6dac73\nSigned-off-by: Gianmarco De Gregori \u003cgianmarco@mandelbit.com\u003e\n"},"branch":"refs/heads/master"},"ebd122de934d813b630f422930d5dac5fe6ca7f6":{"kind":"NO_CHANGE","_number":3,"created":"2026-11-03 11:04:40.000000000","uploader":{"_account_id":1000034,"name":"Gianmarco De Gregori","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"ref":"refs/changes/50/2050/3","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/50/2050/3","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/50/2050/3 \u0026\u0026 git checkout -b change-2050 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/50/2050/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/50/2050/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/50/2050/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/50/2050/3","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/50/2050/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"716a4e95727ba062e6cfcf7b69173e18871149fb","subject":"multi_io: replace TA_INITIAL with TA_INSTANCE_POST"}],"author":{"name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","date":"2026-10-12 08:50:57.000000000","tz":120},"committer":{"name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","date":"2026-11-03 10:13:46.000000000","tz":60},"subject":"multi_io: avoid redundant event_ctl() calls in multi_io_wait()","message":"multi_io: avoid redundant event_ctl() calls in multi_io_wait()\n\nmulti_io_wait() registered each server UDP socket through\nmulti_io_process_flags(), which calls socket_set() without a persistent\ncache and tun_set() once more for every UDP socket, also without a\ncache. Both ended up in an event_ctl() on every loop iteration even\nthough nothing changed.\n\nNow that the UDP sockets and the tun device are only ever armed for\nreading, set them directly with EVENT_READ, caching the UDP socket\nrwflags in the new link_socket.rwflags_persistent and the tun ones in\nmulti_io-\u003etun_rwflags.\n\nOn a server with two UDP and one TCP listener this removes the\nremaining epoll_ctl() calls from the loop (syscalls per received\npacket 4.64 -\u003e 3.36, UDP only 5.29 -\u003e 3.77); at saturation the\nserver delivers 2-7% more traffic with UDP and uses 4-13% less CPU\nat a fixed load.\n\nWith --enable-async-push the inotify descriptor was also registered on\nevery iteration; register it once (1504 -\u003e 12 epoll_ctl() with\ndeferred auth).\n\nChange-Id: I4379a167419d464c000dca3c5c032aaebb6dac73\nSigned-off-by: Gianmarco De Gregori \u003cgianmarco@mandelbit.com\u003e\n"},"branch":"refs/heads/master"}},"requirements":[{"status":"NOT_READY","fallback_text":"All required checks must pass","type":"checks_pass"}],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"OK","labels":[{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"}}]},{"rule_name":"checks~ChecksSubmitRule","status":"NOT_READY","requirements":[{"status":"NOT_READY","fallback_text":"All required checks must pass","type":"checks_pass"}]}]}
