)]}'
{"id":"openvpn~2051","triplet_id":"openvpn~master~Ie755169bb32da856e941a214f43fbb243b768d75","project":"openvpn","branch":"master","full_branch":"refs/heads/master","topic":"multisocket_cleanup","attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2026-10-27 09:46:39.000000000","reason":"Reviewer was added"},"1000034":{"account":{"_account_id":1000034,"name":"Gianmarco De Gregori","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"last_update":"2026-11-03 10:41:09.000000000","reason":"Someone else replied on the change"}},"removed_from_attention_set":{},"hashtags":[],"change_id":"Ie755169bb32da856e941a214f43fbb243b768d75","subject":"multi: drop MPP_CLOSE_ON_SIGNAL","status":"NEW","created":"2026-10-27 09:46:33.000000000","updated":"2026-11-03 11:04:40.000000000","submit_type":"CHERRY_PICK","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"88a541979b6d0c745cc2ea917bc52b5ef90d319a","_number":2051,"virtual_id_number":2051,"owner":{"_account_id":1000034,"name":"Gianmarco De Gregori","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"actions":{},"labels":{"Code-Review":{"approved":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"all":[{"value":2,"date":"2026-11-03 11:04:40.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-10-27 09:46:39.000000000","updated_by":{"_account_id":1000034,"name":"Gianmarco De Gregori","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"real_updated_by":{"_account_id":1000034,"name":"Gianmarco De Gregori","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2026-10-27 09:46:39.000000000","updated_by":{"_account_id":1000034,"name":"Gianmarco De Gregori","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"real_updated_by":{"_account_id":1000034,"name":"Gianmarco De Gregori","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"reviewer":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2026-11-03 10:41:09.000000000","updated_by":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"real_updated_by":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"reviewer":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"state":"REVIEWER"}],"messages":[{"id":"0552e154dce77b0a29a6e19ecc69973827135eae","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000034,"name":"Gianmarco De Gregori","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"date":"2026-10-27 09:46:33.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"8a3ab6bed09408a7adeb23ef36d34ec95203d735","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000034,"name":"Gianmarco De Gregori","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"date":"2026-11-03 08:57:30.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"bb1b60f8cd6512a467daf7ba3c579bf66ae71afe","author":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"date":"2026-11-03 10:41:09.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"88a541979b6d0c745cc2ea917bc52b5ef90d319a","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000034,"name":"Gianmarco De Gregori","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"date":"2026-11-03 11:04:40.000000000","message":"Uploaded patch set 3: New patch set was added with same tree, parent tree, and commit message as Patch Set 2.\n\nCopied Votes:\n* Code-Review+2 (copy condition: \"**changekind:NO_CHANGE** OR **changekind:TRIVIAL_REBASE** OR is:MIN\")\n","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"d1e3ac5717e4c0ea62238ff76a73d1b22fd258bb","revisions":{"85e80583244f6839e1e9e4cfd900604911c0e146":{"kind":"REWORK","_number":1,"created":"2026-10-27 09:46:33.000000000","uploader":{"_account_id":1000034,"name":"Gianmarco De Gregori","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"ref":"refs/changes/51/2051/1","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/51/2051/1","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/51/2051/1 \u0026\u0026 git checkout -b change-2051 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/51/2051/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/51/2051/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/51/2051/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/51/2051/1","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/51/2051/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"6f59a41b6af8349369c39d13db2adcf55d5b3c83","subject":"multi_io: avoid redundant event_ctl() calls in multi_io_wait()"}],"author":{"name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","date":"2026-10-21 13:07:38.000000000","tz":120},"committer":{"name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","date":"2026-10-26 14:24:43.000000000","tz":60},"subject":"multi: drop MPP_CLOSE_ON_SIGNAL","message":"multi: drop MPP_CLOSE_ON_SIGNAL\n\nThe UDP path, the last user of MPP_CLOSE_ON_SIGNAL, now goes through\nmulti_io_action(), which closes the signalled instance itself. Without\nthe flag multi_process_post() always returns true, and the functions\nthat only passed its result along return a value nobody reads.\n\nDrop the flag and make multi_process_post(), the incoming and timeout\nprocessing functions and the static write functions of multi_io.c\nreturn void. The check of the multi_process_post() result in\nmulti_create_instance() could never fail and goes away as well.\n\nChange-Id: Ie755169bb32da856e941a214f43fbb243b768d75\nSigned-off-by: Gianmarco De Gregori \u003cgianmarco@mandelbit.com\u003e\n"},"branch":"refs/heads/master"},"e30b37ae898619b96ac42577cb58b47af0d2a783":{"kind":"REWORK","_number":2,"created":"2026-11-03 08:57:30.000000000","uploader":{"_account_id":1000034,"name":"Gianmarco De Gregori","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"ref":"refs/changes/51/2051/2","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/51/2051/2","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/51/2051/2 \u0026\u0026 git checkout -b change-2051 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/51/2051/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/51/2051/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/51/2051/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/51/2051/2","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/51/2051/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"fc14e738f3444f427df093c599963e518ad70efb","subject":"multi_io: avoid redundant event_ctl() calls in multi_io_wait()"}],"author":{"name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","date":"2026-10-21 13:07:38.000000000","tz":120},"committer":{"name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","date":"2026-11-03 08:28:01.000000000","tz":60},"subject":"multi: drop MPP_CLOSE_ON_SIGNAL","message":"multi: drop MPP_CLOSE_ON_SIGNAL\n\nThe UDP path, the last user of MPP_CLOSE_ON_SIGNAL, now goes through\nmulti_io_action(), which closes the signalled instance itself. Without\nthe flag multi_process_post() always returns true, and the functions\nthat only passed its result along return a value nobody reads.\n\nDrop the flag and make multi_process_post(), the incoming and timeout\nprocessing functions and the static write functions of multi_io.c\nreturn void. The check of the multi_process_post() result in\nmulti_create_instance() could never fail and goes away as well.\n\nChange-Id: Ie755169bb32da856e941a214f43fbb243b768d75\nSigned-off-by: Gianmarco De Gregori \u003cgianmarco@mandelbit.com\u003e\n"},"branch":"refs/heads/master"},"d1e3ac5717e4c0ea62238ff76a73d1b22fd258bb":{"kind":"NO_CHANGE","_number":3,"created":"2026-11-03 11:04:40.000000000","uploader":{"_account_id":1000034,"name":"Gianmarco De Gregori","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"ref":"refs/changes/51/2051/3","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/51/2051/3","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/51/2051/3 \u0026\u0026 git checkout -b change-2051 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/51/2051/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/51/2051/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/51/2051/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/51/2051/3","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/51/2051/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"ebd122de934d813b630f422930d5dac5fe6ca7f6","subject":"multi_io: avoid redundant event_ctl() calls in multi_io_wait()"}],"author":{"name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","date":"2026-10-21 13:07:38.000000000","tz":120},"committer":{"name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","date":"2026-11-03 10:13:46.000000000","tz":60},"subject":"multi: drop MPP_CLOSE_ON_SIGNAL","message":"multi: drop MPP_CLOSE_ON_SIGNAL\n\nThe UDP path, the last user of MPP_CLOSE_ON_SIGNAL, now goes through\nmulti_io_action(), which closes the signalled instance itself. Without\nthe flag multi_process_post() always returns true, and the functions\nthat only passed its result along return a value nobody reads.\n\nDrop the flag and make multi_process_post(), the incoming and timeout\nprocessing functions and the static write functions of multi_io.c\nreturn void. The check of the multi_process_post() result in\nmulti_create_instance() could never fail and goes away as well.\n\nChange-Id: Ie755169bb32da856e941a214f43fbb243b768d75\nSigned-off-by: Gianmarco De Gregori \u003cgianmarco@mandelbit.com\u003e\n"},"branch":"refs/heads/master"}},"requirements":[{"status":"NOT_READY","fallback_text":"All required checks must pass","type":"checks_pass"}],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"OK","labels":[{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"}}]},{"rule_name":"checks~ChecksSubmitRule","status":"NOT_READY","requirements":[{"status":"NOT_READY","fallback_text":"All required checks must pass","type":"checks_pass"}]}]}
