)]}'
{"id":"openvpn~2060","triplet_id":"openvpn~master~I75ba77fcbb11790c7cc86cc436fc75ff99bd1c9e","project":"openvpn","branch":"master","full_branch":"refs/heads/master","topic":"PushUpdateDCO","attention_set":{"1000040":{"account":{"_account_id":1000040,"name":"Marco Baffo","email":"marco@mandelbit.com","username":"mrbff"},"last_update":"2026-11-05 05:56:18.000000000","reason":"Someone else replied on the change"},"1000003":{"account":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2026-10-28 13:37:53.000000000","reason":"Reviewer was added"}},"removed_from_attention_set":{"1000053":{"account":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"last_update":"2026-11-05 05:56:18.000000000","reason":"removed on reply"}},"hashtags":[],"change_id":"I75ba77fcbb11790c7cc86cc436fc75ff99bd1c9e","subject":"PUSH_UPDATE: centralize virtual address changes in update_vaddr","status":"NEW","created":"2026-10-28 13:37:51.000000000","updated":"2026-11-05 05:56:18.000000000","submit_type":"CHERRY_PICK","total_comment_count":8,"unresolved_comment_count":1,"has_review_started":true,"meta_rev_id":"cada127abb46cf2093a66af35ebeb08ce7fcda6b","_number":2060,"virtual_id_number":2060,"owner":{"_account_id":1000040,"name":"Marco Baffo","email":"marco@mandelbit.com","username":"mrbff"},"actions":{},"labels":{"Code-Review":{"approved":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"all":[{"value":2,"date":"2026-11-05 05:56:18.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-10-28 13:37:53.000000000","updated_by":{"_account_id":1000040,"name":"Marco Baffo","email":"marco@mandelbit.com","username":"mrbff"},"real_updated_by":{"_account_id":1000040,"name":"Marco Baffo","email":"marco@mandelbit.com","username":"mrbff"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2026-10-28 13:37:53.000000000","updated_by":{"_account_id":1000040,"name":"Marco Baffo","email":"marco@mandelbit.com","username":"mrbff"},"real_updated_by":{"_account_id":1000040,"name":"Marco Baffo","email":"marco@mandelbit.com","username":"mrbff"},"reviewer":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2026-11-04 10:14:55.000000000","updated_by":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"real_updated_by":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"reviewer":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"state":"REVIEWER"}],"messages":[{"id":"b53df36cd79ac40ef22e2095e562a00461a49fbb","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000040,"name":"Marco Baffo","email":"marco@mandelbit.com","username":"mrbff"},"date":"2026-10-28 13:37:51.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"d9b119eb593386cf39adfb1d08b58774b25cae56","author":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"date":"2026-11-04 10:14:55.000000000","message":"Patch Set 1: Code-Review-1\n\n(4 comments)","accounts_in_message":[],"_revision_number":1},{"id":"e7ed52194b2fbac4a5b8f4528a27e1bec896ecd9","author":{"_account_id":1000040,"name":"Marco Baffo","email":"marco@mandelbit.com","username":"mrbff"},"date":"2026-11-04 16:16:17.000000000","message":"Patch Set 1:\n\n(4 comments)","accounts_in_message":[],"_revision_number":1},{"id":"7b5a2f88f89d7963d57966374f7abcae84623593","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000040,"name":"Marco Baffo","email":"marco@mandelbit.com","username":"mrbff"},"date":"2026-11-04 16:27:50.000000000","message":"Uploaded patch set 2.\n\nOutdated Votes:\n* Code-Review-1 (copy condition: \"changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR is:MIN\")\n","accounts_in_message":[],"_revision_number":2},{"id":"cada127abb46cf2093a66af35ebeb08ce7fcda6b","author":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"date":"2026-11-05 05:56:18.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"d05b45d95c175c9b892c157f6c4e3fa6283a7ba6","revisions":{"ed4acc88e80d08696902ef2b387f2f44497b1fb7":{"kind":"REWORK","_number":1,"created":"2026-10-28 13:37:51.000000000","uploader":{"_account_id":1000040,"name":"Marco Baffo","email":"marco@mandelbit.com","username":"mrbff"},"ref":"refs/changes/60/2060/1","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/60/2060/1","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/60/2060/1 \u0026\u0026 git checkout -b change-2060 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/60/2060/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/60/2060/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/60/2060/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/60/2060/1","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/60/2060/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"ec513f49473a63b5b67b5acb273782bbdb5ad29d","subject":"multi: skip DCO route installation when address learning fails"}],"author":{"name":"Marco Baffo","email":"marco@mandelbit.com","date":"2025-12-18 15:05:06.000000000","tz":60},"committer":{"name":"Marco Baffo","email":"marco@mandelbit.com","date":"2026-10-28 13:36:26.000000000","tz":60},"subject":"PUSH_UPDATE: centralize virtual address changes in update_vaddr","message":"PUSH_UPDATE: centralize virtual address changes in update_vaddr\n\nUse the current virtual addresses as parser defaults so omitted options\nremain unchanged and NULL consistently means address removal. Move removal\ninto update_vaddr(), skip unchanged addresses, and set the new address before\nlearning its route. If learning either new address fails, restart the client\nsince the PUSH_UPDATE is already queued. Report the scheduled exit as a failed\nupdate so management does not count the client as successfully updated.\n\nChange-Id: I75ba77fcbb11790c7cc86cc436fc75ff99bd1c9e\nSigned-off-by: Marco Baffo \u003cmarco@mandelbit.com\u003e\n"},"branch":"refs/heads/master"},"d05b45d95c175c9b892c157f6c4e3fa6283a7ba6":{"kind":"REWORK","_number":2,"created":"2026-11-04 16:27:50.000000000","uploader":{"_account_id":1000040,"name":"Marco Baffo","email":"marco@mandelbit.com","username":"mrbff"},"ref":"refs/changes/60/2060/2","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/60/2060/2","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/60/2060/2 \u0026\u0026 git checkout -b change-2060 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/60/2060/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/60/2060/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/60/2060/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/60/2060/2","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/60/2060/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"347aa94405ca171f30b2ca4cf8d9016779c2bd87","subject":"multi: skip DCO route installation when address learning fails"}],"author":{"name":"Marco Baffo","email":"marco@mandelbit.com","date":"2025-12-18 15:05:06.000000000","tz":60},"committer":{"name":"Marco Baffo","email":"marco@mandelbit.com","date":"2026-11-04 15:09:13.000000000","tz":60},"subject":"PUSH_UPDATE: centralize virtual address changes in update_vaddr","message":"PUSH_UPDATE: centralize virtual address changes in update_vaddr\n\nUse the current virtual addresses as parser defaults so omitted options\nremain unchanged and NULL consistently means address removal. Move removal\ninto update_vaddr(), skip unchanged addresses, and set the new address before\nlearning its route. If learning either new address fails, restart the client\nsince the PUSH_UPDATE is already queued. Report the scheduled exit as a failed\nupdate so management does not count the client as successfully updated.\n\nChange-Id: I75ba77fcbb11790c7cc86cc436fc75ff99bd1c9e\nSigned-off-by: Marco Baffo \u003cmarco@mandelbit.com\u003e\n"},"branch":"refs/heads/master"}},"requirements":[{"status":"NOT_READY","fallback_text":"All required checks must pass","type":"checks_pass"}],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"OK","labels":[{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"}}]},{"rule_name":"checks~ChecksSubmitRule","status":"NOT_READY","requirements":[{"status":"NOT_READY","fallback_text":"All required checks must pass","type":"checks_pass"}]}]}