)]}'
{"id":"openvpn~2078","triplet_id":"openvpn~master~Ic4243377c96a3b460d69050386cddcb30535de27","project":"openvpn","branch":"master","full_branch":"refs/heads/master","attention_set":{},"removed_from_attention_set":{"1000062":{"account":{"_account_id":1000062,"name":"Hansaem Wi","email":"hansaemw@gmail.com","username":"wihansaem1991"},"last_update":"2026-11-05 17:03:29.000000000","reason":"Change was submitted"},"1000003":{"account":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2026-11-05 17:03:29.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Ic4243377c96a3b460d69050386cddcb30535de27","subject":"crypto: Wipe the struct key_parameters copies after use","status":"MERGED","created":"2026-11-02 00:46:17.000000000","updated":"2026-11-05 17:03:29.000000000","submitted":"2026-11-05 17:03:29.000000000","submitter":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"2078","meta_rev_id":"36c720a995e1ab7cedf5fb2e883df9a7c53abbf3","_number":2078,"virtual_id_number":2078,"owner":{"_account_id":1000062,"name":"Hansaem Wi","email":"hansaemw@gmail.com","username":"wihansaem1991"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000035,"name":"Steffan Karger","display_name":"Steffan Karger","email":"steffan@karger.me","username":"syzzer","status":"Commits and comments are my own views, not those of my employer."},{"value":0,"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"reviewers":{"REVIEWER":[{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"_account_id":1000035,"name":"Steffan Karger","display_name":"Steffan Karger","email":"steffan@karger.me","username":"syzzer","status":"Commits and comments are my own views, not those of my employer."}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-11-02 00:46:17.000000000","updated_by":{"_account_id":1000062,"name":"Hansaem Wi","email":"hansaemw@gmail.com","username":"wihansaem1991"},"real_updated_by":{"_account_id":1000062,"name":"Hansaem Wi","email":"hansaemw@gmail.com","username":"wihansaem1991"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2026-11-02 00:46:17.000000000","updated_by":{"_account_id":1000062,"name":"Hansaem Wi","email":"hansaemw@gmail.com","username":"wihansaem1991"},"real_updated_by":{"_account_id":1000062,"name":"Hansaem Wi","email":"hansaemw@gmail.com","username":"wihansaem1991"},"reviewer":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2026-11-05 08:46:44.000000000","updated_by":{"_account_id":1000035,"name":"Steffan Karger","display_name":"Steffan Karger","email":"steffan@karger.me","username":"syzzer","status":"Commits and comments are my own views, not those of my employer."},"real_updated_by":{"_account_id":1000035,"name":"Steffan Karger","display_name":"Steffan Karger","email":"steffan@karger.me","username":"syzzer","status":"Commits and comments are my own views, not those of my employer."},"reviewer":{"_account_id":1000035,"name":"Steffan Karger","display_name":"Steffan Karger","email":"steffan@karger.me","username":"syzzer","status":"Commits and comments are my own views, not those of my employer."},"state":"REVIEWER"}],"messages":[{"id":"cc9106b802a8395e8c2b20c75281f596e9a26aa0","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000062,"name":"Hansaem Wi","email":"hansaemw@gmail.com","username":"wihansaem1991"},"date":"2026-11-02 00:46:17.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"c03bab7f229d7054bce8af731db09f071b8e0038","author":{"_account_id":1000035,"name":"Steffan Karger","display_name":"Steffan Karger","email":"steffan@karger.me","username":"syzzer","status":"Commits and comments are my own views, not those of my employer."},"date":"2026-11-05 08:46:44.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"36c720a995e1ab7cedf5fb2e883df9a7c53abbf3","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2026-11-05 17:03:29.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"09fd5ac8e4f679a58b02ed2f883ebf4a4d7205a7","revisions":{"30fed23777f60a5c177d45143363f507246c2044":{"kind":"REWORK","_number":1,"created":"2026-11-02 00:46:17.000000000","uploader":{"_account_id":1000062,"name":"Hansaem Wi","email":"hansaemw@gmail.com","username":"wihansaem1991"},"ref":"refs/changes/78/2078/1","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/78/2078/1","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/78/2078/1 \u0026\u0026 git checkout -b change-2078 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/78/2078/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/78/2078/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/78/2078/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/78/2078/1","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/78/2078/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"5f28589175a1cda2f5bf675e93655db229cb4116","subject":"cmake: don\u0027t prefix the event message DLL with lib"}],"author":{"name":"Hansaem Wi","email":"hansaemw@gmail.com","date":"2026-11-02 00:42:15.000000000","tz":540},"committer":{"name":"Hansaem Wi","email":"hansaemw@gmail.com","date":"2026-11-02 00:42:15.000000000","tz":540},"subject":"crypto: Wipe the struct key_parameters copies after use","message":"crypto: Wipe the struct key_parameters copies after use\n\ninit_key_ctx_bi() and tls_crypt_v2_init_server_key() convert the key\ninto a struct key_parameters on the stack and return without clearing\nit. init_key_ctx_bi() sets up the data channel keys (when epoch keys\nare not used), tls-auth, tls-crypt and static keys, so the cipher and\nHMAC keys stay on the stack after every key setup.\nepoch_init_send_key() and epoch_init_recv_key() already clear their\nstruct key_parameters after use; do the same in these two places.\n\nAssisted-by: Claude Code:claude-opus-5-5\nChange-Id: Ic4243377c96a3b460d69050386cddcb30535de27\nSigned-off-by: Hansaem Wi \u003chansaemw@gmail.com\u003e\n"},"branch":"refs/heads/master"},"09fd5ac8e4f679a58b02ed2f883ebf4a4d7205a7":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":2,"created":"2026-11-05 17:03:29.000000000","uploader":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/78/2078/2","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/78/2078/2","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/78/2078/2 \u0026\u0026 git checkout -b change-2078 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/78/2078/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/78/2078/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/78/2078/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/78/2078/2","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/78/2078/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"da6659452a34b5c94b20f55cbeb96b9ba70885ad","subject":"ssl: Wipe the key source material in key_state_free()"}],"author":{"name":"Hansaem Wi","email":"hansaemw@gmail.com","date":"2026-11-05 09:37:30.000000000","tz":60},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2026-11-05 16:50:50.000000000","tz":60},"subject":"crypto: Wipe the struct key_parameters copies after use","message":"crypto: Wipe the struct key_parameters copies after use\n\ninit_key_ctx_bi() and tls_crypt_v2_init_server_key() convert the key\ninto a struct key_parameters on the stack and return without clearing\nit. init_key_ctx_bi() sets up the data channel keys (when epoch keys\nare not used), tls-auth, tls-crypt and static keys, so the cipher and\nHMAC keys stay on the stack after every key setup.\nepoch_init_send_key() and epoch_init_recv_key() already clear their\nstruct key_parameters after use; do the same in these two places.\n\nAssisted-by: Claude Code:claude-opus-5-5\nChange-Id: Ic4243377c96a3b460d69050386cddcb30535de27\nSigned-off-by: Hansaem Wi \u003chansaemw@gmail.com\u003e\nAcked-by: Steffan Karger \u003csteffan@karger.me\u003e\nGerrit URL: https://gerrit.openvpn.net/c/openvpn/+/2078\nMessage-Id: \u003c20261105093736.11814-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg40749.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[]}
