)]}'
{"id":"openvpn~2079","triplet_id":"openvpn~master~I8e02b4cf39cc431f1f2c058db95997c8907557c0","project":"openvpn","branch":"master","full_branch":"refs/heads/master","attention_set":{"1000062":{"account":{"_account_id":1000062,"name":"Hansaem Wi","email":"hansaemw@gmail.com","username":"wihansaem1991"},"last_update":"2026-11-02 10:11:46.000000000","reason":"\u003cGERRIT_ACCOUNT_1000035\u003e replied on the change","reason_account":{"_account_id":1000035,"name":"Steffan Karger","display_name":"Steffan Karger","email":"steffan@karger.me","username":"syzzer","status":"Commits and comments are my own views, not those of my employer."}},"1000003":{"account":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2026-11-02 04:39:49.000000000","reason":"Reviewer was added"}},"removed_from_attention_set":{},"hashtags":[],"change_id":"I8e02b4cf39cc431f1f2c058db95997c8907557c0","subject":"tls_crypt: Wipe the tls-crypt-v2 client key copies","status":"NEW","created":"2026-11-02 04:39:48.000000000","updated":"2026-11-02 10:11:46.000000000","submit_type":"CHERRY_PICK","total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"83a94205c7df9b0a9b1394e2edce1ca386a0a22f","_number":2079,"virtual_id_number":2079,"owner":{"_account_id":1000062,"name":"Hansaem Wi","email":"hansaemw@gmail.com","username":"wihansaem1991"},"actions":{},"labels":{"Code-Review":{"approved":{"_account_id":1000035,"name":"Steffan Karger","display_name":"Steffan Karger","email":"steffan@karger.me","username":"syzzer","status":"Commits and comments are my own views, not those of my employer."},"all":[{"value":2,"date":"2026-11-02 10:11:46.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":1000035,"name":"Steffan Karger","display_name":"Steffan Karger","email":"steffan@karger.me","username":"syzzer","status":"Commits and comments are my own views, not those of my employer."},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"_account_id":1000035,"name":"Steffan Karger","display_name":"Steffan Karger","email":"steffan@karger.me","username":"syzzer","status":"Commits and comments are my own views, not those of my employer."}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-11-02 04:39:49.000000000","updated_by":{"_account_id":1000062,"name":"Hansaem Wi","email":"hansaemw@gmail.com","username":"wihansaem1991"},"real_updated_by":{"_account_id":1000062,"name":"Hansaem Wi","email":"hansaemw@gmail.com","username":"wihansaem1991"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2026-11-02 04:39:49.000000000","updated_by":{"_account_id":1000062,"name":"Hansaem Wi","email":"hansaemw@gmail.com","username":"wihansaem1991"},"real_updated_by":{"_account_id":1000062,"name":"Hansaem Wi","email":"hansaemw@gmail.com","username":"wihansaem1991"},"reviewer":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2026-11-02 10:11:46.000000000","updated_by":{"_account_id":1000035,"name":"Steffan Karger","display_name":"Steffan Karger","email":"steffan@karger.me","username":"syzzer","status":"Commits and comments are my own views, not those of my employer."},"real_updated_by":{"_account_id":1000035,"name":"Steffan Karger","display_name":"Steffan Karger","email":"steffan@karger.me","username":"syzzer","status":"Commits and comments are my own views, not those of my employer."},"reviewer":{"_account_id":1000035,"name":"Steffan Karger","display_name":"Steffan Karger","email":"steffan@karger.me","username":"syzzer","status":"Commits and comments are my own views, not those of my employer."},"state":"REVIEWER"}],"messages":[{"id":"df24fc1aee84ec8d45ceb7efd19af17cadc2b3ed","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000062,"name":"Hansaem Wi","email":"hansaemw@gmail.com","username":"wihansaem1991"},"date":"2026-11-02 04:39:48.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"83a94205c7df9b0a9b1394e2edce1ca386a0a22f","author":{"_account_id":1000035,"name":"Steffan Karger","display_name":"Steffan Karger","email":"steffan@karger.me","username":"syzzer","status":"Commits and comments are my own views, not those of my employer."},"date":"2026-11-02 10:11:46.000000000","message":"Patch Set 1: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"7f3b66366055c7e45c4256969f2497496df91a88","revisions":{"7f3b66366055c7e45c4256969f2497496df91a88":{"kind":"REWORK","_number":1,"created":"2026-11-02 04:39:48.000000000","uploader":{"_account_id":1000062,"name":"Hansaem Wi","email":"hansaemw@gmail.com","username":"wihansaem1991"},"ref":"refs/changes/79/2079/1","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/79/2079/1","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/79/2079/1 \u0026\u0026 git checkout -b change-2079 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/79/2079/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/79/2079/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/79/2079/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/79/2079/1","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/79/2079/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"5f28589175a1cda2f5bf675e93655db229cb4116","subject":"cmake: don\u0027t prefix the event message DLL with lib"}],"author":{"name":"Hansaem Wi","email":"hansaemw@gmail.com","date":"2026-11-02 04:38:48.000000000","tz":540},"committer":{"name":"Hansaem Wi","email":"hansaemw@gmail.com","date":"2026-11-02 04:39:00.000000000","tz":540},"subject":"tls_crypt: Wipe the tls-crypt-v2 client key copies","message":"tls_crypt: Wipe the tls-crypt-v2 client key copies\n\ntls_crypt_v2_init_client_key() reads the client key into a struct key2\non the stack, copies it to *original_key and returns without clearing\nit, so every client start leaves the tls-crypt-v2 client key on the\nstack. crypto_read_openvpn_key() does the same copy for tls-auth and\ntls-crypt keys and clears its struct key2 afterwards; do the same here.\n\nThe --genkey tls-crypt-v2-client sanity check in\ntls_crypt_v2_write_client_key_file() has two more copies:\n- keydata, the struct key2 that tls_crypt_v2_init_client_key() fills;\n  clear it after use.\n- check_wrapped_client_key, the decoded key file buffer: the client key\n  is still in front of the wrapped key when it is freed. Clear it with\n  buf_clear() before free_buf(), as do_close_free_key_schedule() does\n  for the client\u0027s tls_crypt_v2_wkc.\n\nAssisted-by: Claude Code:claude-opus-5-5\nChange-Id: I8e02b4cf39cc431f1f2c058db95997c8907557c0\nSigned-off-by: Hansaem Wi \u003chansaemw@gmail.com\u003e\n"},"branch":"refs/heads/master"}},"requirements":[{"status":"NOT_READY","fallback_text":"All required checks must pass","type":"checks_pass"}],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"OK","labels":[{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000035,"name":"Steffan Karger","display_name":"Steffan Karger","email":"steffan@karger.me","username":"syzzer","status":"Commits and comments are my own views, not those of my employer."}}]},{"rule_name":"checks~ChecksSubmitRule","status":"NOT_READY","requirements":[{"status":"NOT_READY","fallback_text":"All required checks must pass","type":"checks_pass"}]}]}