)]}'
{"id":"openvpn~2101","triplet_id":"openvpn~master~Idb3c52174e588016240e9c9162a1676e1531c551","project":"openvpn","branch":"master","full_branch":"refs/heads/master","attention_set":{},"removed_from_attention_set":{"1000053":{"account":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"last_update":"2026-11-16 18:56:12.000000000","reason":"Change was submitted"},"1000003":{"account":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2026-11-16 18:56:12.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Idb3c52174e588016240e9c9162a1676e1531c551","subject":"dco_linux: check ovpn_dco_nlmsg_create() result in new/get peer","status":"MERGED","created":"2026-11-03 08:04:07.000000000","updated":"2026-11-16 18:56:12.000000000","submitted":"2026-11-16 18:56:12.000000000","submitter":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"2101","meta_rev_id":"f59428322a645a2d8cdbc6a7721cbc806b27c653","_number":2101,"virtual_id_number":2101,"owner":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},{"value":0,"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"reviewers":{"REVIEWER":[{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-11-03 08:04:07.000000000","updated_by":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"real_updated_by":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2026-11-03 08:04:07.000000000","updated_by":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"real_updated_by":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"reviewer":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2026-11-16 10:20:31.000000000","updated_by":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"real_updated_by":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"reviewer":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"state":"REVIEWER"}],"messages":[{"id":"5a5169326d49e1624ed41ef3252a13e3b1f3f2e0","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"date":"2026-11-03 08:04:07.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"f8c9ebe52301f007808450f0e6f3cc3c07e09d03","author":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"date":"2026-11-16 10:20:31.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"f59428322a645a2d8cdbc6a7721cbc806b27c653","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2026-11-16 18:56:12.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"bbc14868ef99a16eda987396b890ec8df6427dcf","revisions":{"6ff900bd4f226e6b1b1c992d531f3eb7d3111d23":{"kind":"REWORK","_number":1,"created":"2026-11-03 08:04:07.000000000","uploader":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"ref":"refs/changes/01/2101/1","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/01/2101/1","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/01/2101/1 \u0026\u0026 git checkout -b change-2101 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/01/2101/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/01/2101/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/01/2101/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/01/2101/1","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/01/2101/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"24946176aed52c23c52c956df43fd052c232f652","subject":"port-share: do not write journal file through symlinks or hardlinks"}],"author":{"name":"Razvan Cojocaru","email":"razvanc@mailbox.org","date":"2026-11-03 08:03:07.000000000","tz":120},"committer":{"name":"Razvan Cojocaru","email":"razvanc@mailbox.org","date":"2026-11-03 08:03:36.000000000","tz":120},"subject":"dco_linux: check ovpn_dco_nlmsg_create() result in new/get peer","message":"dco_linux: check ovpn_dco_nlmsg_create() result in new/get peer\n\ndco_new_peer() and dco_get_peer() passed the result straight to\nnla_nest_start() without checking for NULL. Return -ENOMEM like the\nother callers.\n\ndco_new_peer() unchecked since e34437c2 (\"dco: introduce low-level code\nfor handling ovpn-dco in the Linux kernel\"), dco_get_peer() since\n5a8fb55a (\"dco-linux: implement dco_get_peer_stats{, multi} API\").\n\nChange-Id: Idb3c52174e588016240e9c9162a1676e1531c551\nSigned-off-by: Razvan Cojocaru \u003crazvanc@mailbox.org\u003e\n"},"branch":"refs/heads/master"},"bbc14868ef99a16eda987396b890ec8df6427dcf":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":2,"created":"2026-11-16 18:56:12.000000000","uploader":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/01/2101/2","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/01/2101/2","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/01/2101/2 \u0026\u0026 git checkout -b change-2101 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/01/2101/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/01/2101/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/01/2101/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/01/2101/2","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/01/2101/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"7d46ff17248908acf906134ee1e03ded831634a6","subject":"ssl_util: Switch get_num_elements to size_t"}],"author":{"name":"Razvan Cojocaru","email":"razvanc@mailbox.org","date":"2026-11-16 10:25:11.000000000","tz":60},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2026-11-16 17:58:28.000000000","tz":60},"subject":"dco_linux: check ovpn_dco_nlmsg_create() result in new/get peer","message":"dco_linux: check ovpn_dco_nlmsg_create() result in new/get peer\n\ndco_new_peer() and dco_get_peer() passed the result straight to\nnla_nest_start() without checking for NULL. Return -ENOMEM like the\nother callers.\n\ndco_new_peer() unchecked since e34437c2 (\"dco: introduce low-level code\nfor handling ovpn-dco in the Linux kernel\"), dco_get_peer() since\n5a8fb55a (\"dco-linux: implement dco_get_peer_stats{, multi} API\").\n\nChange-Id: Idb3c52174e588016240e9c9162a1676e1531c551\nSigned-off-by: Razvan Cojocaru \u003crazvanc@mailbox.org\u003e\nAcked-by: Antonio Quartulli \u003cantonio@mandelbit.com\u003e\nGerrit URL: https://gerrit.openvpn.net/c/openvpn/+/2101\nMessage-Id: \u003c20261116102516.14493-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg41409.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[]}
