)]}'
{"id":"openvpn~2105","triplet_id":"openvpn~master~I494a427924ea501382275ea96ef85a6abcd780e5","project":"openvpn","branch":"master","full_branch":"refs/heads/master","attention_set":{},"removed_from_attention_set":{"1000007":{"account":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"last_update":"2026-11-06 17:33:53.000000000","reason":"Change was submitted"},"1000053":{"account":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"last_update":"2026-11-06 17:33:53.000000000","reason":"Change was submitted"},"1000003":{"account":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2026-11-06 17:33:53.000000000","reason":"Change was submitted"},"1000002":{"account":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"last_update":"2026-11-06 13:00:55.000000000","reason":"\u003cGERRIT_ACCOUNT_1000002\u003e replied on the change","reason_account":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}}},"hashtags":[],"change_id":"I494a427924ea501382275ea96ef85a6abcd780e5","subject":"Move gc from openvpn_net_ctx_t to local variables","status":"MERGED","created":"2026-11-03 12:43:59.000000000","updated":"2026-11-06 17:33:53.000000000","submitted":"2026-11-06 17:33:53.000000000","submitter":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":5,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"2105","meta_rev_id":"a111b7d89d8836240ce2545bd0650f9ba249544a","_number":2105,"virtual_id_number":2105,"owner":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},{"value":0,"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},{"value":0,"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-11-03 12:44:00.000000000","updated_by":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"real_updated_by":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2026-11-03 13:32:38.000000000","updated_by":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"real_updated_by":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"reviewer":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"state":"REVIEWER"},{"updated":"2026-11-03 13:35:29.000000000","updated_by":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"real_updated_by":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"reviewer":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"state":"REVIEWER"},{"updated":"2026-11-05 19:53:33.000000000","updated_by":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"real_updated_by":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"state":"REVIEWER"}],"messages":[{"id":"81f8e005d2322b8249c37605d92cb92fa7d6465a","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2026-11-03 12:43:59.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"04ab7e79e486bd3337959dfb2e0590f8bd7adce6","author":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"date":"2026-11-03 13:32:38.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"cf2dddb11b9d17a9323e87f66a04127dc5586dad","author":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"date":"2026-11-03 13:35:29.000000000","message":"Patch Set 1: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"0e306d7c2801fc808e5442d26a9a3cafe5901e6a","author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2026-11-05 19:53:33.000000000","message":"Patch Set 1: Code-Review-1\n\n(2 comments)","accounts_in_message":[],"_revision_number":1},{"id":"14cc9fdcb016b7c510ece06cdefebf8a87a95664","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2026-11-06 12:21:28.000000000","message":"Uploaded patch set 2.\n\nOutdated Votes:\n* Code-Review+2, Code-Review-1 (copy condition: \"changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR is:MIN\")\n","accounts_in_message":[],"_revision_number":2},{"id":"a1c61febbba01b38006bf0fb0609a4791523ce50","author":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2026-11-06 12:22:51.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"9eee67567c82644795d3a20b0bedc9fe6dc38857","author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2026-11-06 13:00:55.000000000","message":"Patch Set 2: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"a111b7d89d8836240ce2545bd0650f9ba249544a","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2026-11-06 17:33:53.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"612c2203b19d58de952b65d0a1860487dc7e00c6","revisions":{"8eb4af5adaff4a6f1f9a8801a45c00eac2a2df24":{"kind":"REWORK","_number":1,"created":"2026-11-03 12:43:59.000000000","uploader":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"ref":"refs/changes/05/2105/1","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/05/2105/1","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/05/2105/1 \u0026\u0026 git checkout -b change-2105 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/05/2105/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/05/2105/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/05/2105/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/05/2105/1","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/05/2105/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"6b617486ada6b9b936e0076081ca878ba493a3a9","subject":"Introduce get_key_by_management_key_id helper function"}],"author":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2026-11-03 12:25:07.000000000","tz":60},"committer":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2026-11-03 12:43:44.000000000","tz":60},"subject":"Move gc from openvpn_net_ctx_t to local variables","message":"Move gc from openvpn_net_ctx_t to local variables\n\nAll the iproute2 functions use the gc only to create local variables\nand strings to ultimately pass to openvpn_execve_check. These do not\nneed to live longer than the function that calls openvpn_execve_check\n\nChange-Id: I494a427924ea501382275ea96ef85a6abcd780e5\nSigned-off-by: Arne Schwabe \u003carne@rfc2549.org\u003e\n"},"branch":"refs/heads/master"},"4079ffb801003e9bb3f66c653d62b32836fece4c":{"kind":"REWORK","_number":2,"created":"2026-11-06 12:21:28.000000000","uploader":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"ref":"refs/changes/05/2105/2","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/05/2105/2","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/05/2105/2 \u0026\u0026 git checkout -b change-2105 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/05/2105/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/05/2105/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/05/2105/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/05/2105/2","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/05/2105/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"41889e72a604e500c33392df93a62ef60c14d1f1","subject":"lladdr: pass S_* flags, not M_WARN, to openvpn_execve_check()"}],"author":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2026-11-03 12:25:07.000000000","tz":60},"committer":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2026-11-06 12:20:26.000000000","tz":60},"subject":"Move gc from openvpn_net_ctx_t to local variables","message":"Move gc from openvpn_net_ctx_t to local variables\n\nAll the iproute2 functions use the gc only to create local variables\nand strings to ultimately pass to openvpn_execve_check. These do not\nneed to live longer than the function that calls openvpn_execve_check.\n\nSince argv already has a gc and the variables are used for the\ncommand construction with that argv, just use the gc of that local\nargv.\n\nChange-Id: I494a427924ea501382275ea96ef85a6abcd780e5\nSigned-off-by: Arne Schwabe \u003carne@rfc2549.org\u003e\n"},"branch":"refs/heads/master"},"612c2203b19d58de952b65d0a1860487dc7e00c6":{"kind":"NO_CODE_CHANGE","_number":3,"created":"2026-11-06 17:33:53.000000000","uploader":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/05/2105/3","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/05/2105/3","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/05/2105/3 \u0026\u0026 git checkout -b change-2105 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/05/2105/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/05/2105/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/05/2105/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/05/2105/3","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/05/2105/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"41889e72a604e500c33392df93a62ef60c14d1f1","subject":"lladdr: pass S_* flags, not M_WARN, to openvpn_execve_check()"}],"author":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2026-11-06 13:10:39.000000000","tz":60},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2026-11-06 16:16:55.000000000","tz":60},"subject":"Move gc from openvpn_net_ctx_t to local variables","message":"Move gc from openvpn_net_ctx_t to local variables\n\nAll the iproute2 functions use the gc only to create local variables\nand strings to ultimately pass to openvpn_execve_check. These do not\nneed to live longer than the function that calls openvpn_execve_check.\n\nSince argv already has a gc and the variables are used for the\ncommand construction with that argv, just use the gc of that local\nargv.\n\nChange-Id: I494a427924ea501382275ea96ef85a6abcd780e5\nSigned-off-by: Arne Schwabe \u003carne@rfc2549.org\u003e\nAcked-by: Gert Doering \u003cgert@greenie.muc.de\u003e\nGerrit URL: https://gerrit.openvpn.net/c/openvpn/+/2105\nMessage-Id: \u003c20261106131044.16659-1-gert@greenie.muc.de\u003e\nURL: https://lore.kernel.org/openvpn-devel/20261106131044.16659-1-gert@greenie.muc.de\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[]}