)]}'
{"id":"openvpn~2111","triplet_id":"openvpn~master~Ifc707ef69d614c3408b6f88c780e337e95baafac","project":"openvpn","branch":"master","full_branch":"refs/heads/master","attention_set":{},"removed_from_attention_set":{"1000053":{"account":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"last_update":"2026-11-04 17:10:12.000000000","reason":"Change was submitted"},"1000003":{"account":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2026-11-04 17:10:12.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Ifc707ef69d614c3408b6f88c780e337e95baafac","subject":"openvpnserv: free security descriptors in RunOpenvpn()","status":"MERGED","created":"2026-11-03 19:23:54.000000000","updated":"2026-11-04 17:10:12.000000000","submitted":"2026-11-04 17:10:12.000000000","submitter":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"2111","meta_rev_id":"072272786fbe39a7d707b36323a0733cd691b41b","_number":2111,"virtual_id_number":2111,"owner":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000006,"name":"Heiko Hund","display_name":"Heiko Hund","email":"heiko@ist.eigentlich.net","username":"d12fk"},{"value":0,"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"reviewers":{"REVIEWER":[{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"_account_id":1000006,"name":"Heiko Hund","display_name":"Heiko Hund","email":"heiko@ist.eigentlich.net","username":"d12fk"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-11-03 19:23:55.000000000","updated_by":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"real_updated_by":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2026-11-03 19:23:55.000000000","updated_by":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"real_updated_by":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"reviewer":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2026-11-03 20:10:10.000000000","updated_by":{"_account_id":1000006,"name":"Heiko Hund","display_name":"Heiko Hund","email":"heiko@ist.eigentlich.net","username":"d12fk"},"real_updated_by":{"_account_id":1000006,"name":"Heiko Hund","display_name":"Heiko Hund","email":"heiko@ist.eigentlich.net","username":"d12fk"},"reviewer":{"_account_id":1000006,"name":"Heiko Hund","display_name":"Heiko Hund","email":"heiko@ist.eigentlich.net","username":"d12fk"},"state":"REVIEWER"}],"messages":[{"id":"8054f2581a5c6d9d9035148a7bac8c98262a7622","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"date":"2026-11-03 19:23:54.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"0f733cc58484e96fbac57accd2b7cf602e6a1c89","author":{"_account_id":1000006,"name":"Heiko Hund","display_name":"Heiko Hund","email":"heiko@ist.eigentlich.net","username":"d12fk"},"date":"2026-11-03 20:10:10.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"072272786fbe39a7d707b36323a0733cd691b41b","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2026-11-04 17:10:12.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"9e4394a6511d1e50f1c11efde223635bbc296aa3","revisions":{"d2b8fc1d0fa0ddf8d96e14529f50113a950920f8":{"kind":"REWORK","_number":1,"created":"2026-11-03 19:23:54.000000000","uploader":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"ref":"refs/changes/11/2111/1","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/11/2111/1","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/11/2111/1 \u0026\u0026 git checkout -b change-2111 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/11/2111/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/11/2111/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/11/2111/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/11/2111/1","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/11/2111/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"09cc40a6ff9e1d81db463a7769c464dd2baecf1a","subject":"openvpnserv: fix inverted inet_ntop() check in GetItfDnsServersV6()"}],"author":{"name":"Razvan Cojocaru","email":"razvanc@mailbox.org","date":"2026-11-03 19:21:10.000000000","tz":120},"committer":{"name":"Razvan Cojocaru","email":"razvanc@mailbox.org","date":"2026-11-03 19:23:49.000000000","tz":120},"subject":"openvpnserv: free security descriptors in RunOpenvpn()","message":"openvpnserv: free security descriptors in RunOpenvpn()\n\nThe DACL from SetEntriesInAcl() and the pipe security descriptor from\nConvertStringSecurityDescriptorToSecurityDescriptorW() were never\nfreed, leaking both on every client connection. Initialize them to\nNULL at the top and LocalFree() them at out.\n\nDACL leaked since a24dd2e3 (\"interactive service v3\"), pipe security\ndescriptor since 0a429cb1 (\"Restrict access to the service pipe to\nSYSTEM and owner\").\n\nChange-Id: Ifc707ef69d614c3408b6f88c780e337e95baafac\nSigned-off-by: Razvan Cojocaru \u003crazvanc@mailbox.org\u003e\n"},"branch":"refs/heads/master"},"9e4394a6511d1e50f1c11efde223635bbc296aa3":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":2,"created":"2026-11-04 17:10:12.000000000","uploader":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/11/2111/2","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/11/2111/2","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/11/2111/2 \u0026\u0026 git checkout -b change-2111 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/11/2111/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/11/2111/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/11/2111/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/11/2111/2","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/11/2111/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"719f5c2c19037262a0758dc2f7e504ff7958b23e","subject":"tun: log the actual error in Windows tun_read_queue()"}],"author":{"name":"Razvan Cojocaru","email":"razvanc@mailbox.org","date":"2026-11-04 07:47:45.000000000","tz":60},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2026-11-04 17:04:02.000000000","tz":60},"subject":"openvpnserv: free security descriptors in RunOpenvpn()","message":"openvpnserv: free security descriptors in RunOpenvpn()\n\nThe DACL from SetEntriesInAcl() and the pipe security descriptor from\nConvertStringSecurityDescriptorToSecurityDescriptorW() were never\nfreed, leaking both on every client connection. Initialize them to\nNULL at the top and LocalFree() them at out.\n\nDACL leaked since a24dd2e3 (\"interactive service v3\"), pipe security\ndescriptor since 0a429cb1 (\"Restrict access to the service pipe to\nSYSTEM and owner\").\n\nChange-Id: Ifc707ef69d614c3408b6f88c780e337e95baafac\nSigned-off-by: Razvan Cojocaru \u003crazvanc@mailbox.org\u003e\nAcked-by: Heiko Hund \u003cheiko@openvpn.net\u003e\nGerrit URL: https://gerrit.openvpn.net/c/openvpn/+/2111\nMessage-Id: \u003c20261104074751.21336-1-gert@greenie.muc.de\u003e\nURL: https://lore.kernel.org/openvpn-devel/20261104074751.21336-1-gert@greenie.muc.de\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[]}