)]}'
{"id":"openvpn~2128","triplet_id":"openvpn~master~I5542520825112dfd64aab332bd76333b74d7fec0","project":"openvpn","branch":"master","full_branch":"refs/heads/master","attention_set":{},"removed_from_attention_set":{"1000053":{"account":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"last_update":"2026-11-04 16:50:03.000000000","reason":"Change was submitted"},"1000003":{"account":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2026-11-04 16:50:03.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I5542520825112dfd64aab332bd76333b74d7fec0","subject":"openvpnserv: don\u0027t return freed token groups from GetTokenGroups()","status":"MERGED","created":"2026-11-04 08:47:45.000000000","updated":"2026-11-04 16:50:03.000000000","submitted":"2026-11-04 16:50:03.000000000","submitter":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"2128","meta_rev_id":"fbe67afd2ea7340ce6e50ba3059e2479483be874","_number":2128,"virtual_id_number":2128,"owner":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"reviewers":{"REVIEWER":[{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-11-04 08:47:48.000000000","updated_by":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"real_updated_by":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2026-11-04 08:47:48.000000000","updated_by":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"real_updated_by":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"reviewer":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2026-11-04 10:57:25.000000000","updated_by":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"real_updated_by":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"state":"REVIEWER"}],"messages":[{"id":"805bfd46de18d97664f0fbd4c963828e2965ded4","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"date":"2026-11-04 08:47:45.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"f940452a08d3504e0bc61e2512e3ff557edc4b99","author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2026-11-04 10:57:25.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"fbe67afd2ea7340ce6e50ba3059e2479483be874","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2026-11-04 16:50:03.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"21efe909a89fd6eb13b04849505301312a22c35a","revisions":{"ea64f4bcf2968e0d4a935fd6882326bacf599193":{"kind":"REWORK","_number":1,"created":"2026-11-04 08:47:45.000000000","uploader":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"ref":"refs/changes/28/2128/1","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/28/2128/1","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/28/2128/1 \u0026\u0026 git checkout -b change-2128 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/28/2128/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/28/2128/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/28/2128/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/28/2128/1","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/28/2128/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"f1721dc7c1c0eb7e257ec557d86e7ec38599586a","subject":"crypto_epoch: wipe key material with secure_memzero()"}],"author":{"name":"Razvan Cojocaru","email":"razvanc@mailbox.org","date":"2026-11-04 08:46:56.000000000","tz":120},"committer":{"name":"Razvan Cojocaru","email":"razvanc@mailbox.org","date":"2026-11-04 08:46:56.000000000","tz":120},"subject":"openvpnserv: don\u0027t return freed token groups from GetTokenGroups()","message":"openvpnserv: don\u0027t return freed token groups from GetTokenGroups()\n\nWhen the second GetTokenInformation() call failed, the freed buffer was\nreturned. IsUserInGroup() then read it and IsAuthorizedUser() freed it\nagain. Return NULL, which IsUserInGroup() already handles by skipping\nthe token group check.\n\nBroken since e82733a1 (\"Fix user\u0027s group membership check in\ninteractive service to work with domains\").\n\nChange-Id: I5542520825112dfd64aab332bd76333b74d7fec0\nSigned-off-by: Razvan Cojocaru \u003crazvanc@mailbox.org\u003e\n"},"branch":"refs/heads/master"},"21efe909a89fd6eb13b04849505301312a22c35a":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2026-11-04 16:50:03.000000000","uploader":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/28/2128/2","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/28/2128/2","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/28/2128/2 \u0026\u0026 git checkout -b change-2128 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/28/2128/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/28/2128/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/28/2128/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/28/2128/2","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/28/2128/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"f1721dc7c1c0eb7e257ec557d86e7ec38599586a","subject":"crypto_epoch: wipe key material with secure_memzero()"}],"author":{"name":"Razvan Cojocaru","email":"razvanc@mailbox.org","date":"2026-11-04 10:57:32.000000000","tz":60},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2026-11-04 16:47:35.000000000","tz":60},"subject":"openvpnserv: don\u0027t return freed token groups from GetTokenGroups()","message":"openvpnserv: don\u0027t return freed token groups from GetTokenGroups()\n\nWhen the second GetTokenInformation() call failed, the freed buffer was\nreturned. IsUserInGroup() then read it and IsAuthorizedUser() freed it\nagain. Return NULL, which IsUserInGroup() already handles by skipping\nthe token group check.\n\nBroken since e82733a1 (\"Fix user\u0027s group membership check in\ninteractive service to work with domains\").\n\nChange-Id: I5542520825112dfd64aab332bd76333b74d7fec0\nSigned-off-by: Razvan Cojocaru \u003crazvanc@mailbox.org\u003e\nAcked-by: Gert Doering \u003cgert@greenie.muc.de\u003e\nGerrit URL: https://gerrit.openvpn.net/c/openvpn/+/2128\nMessage-Id: \u003c20261104105737.7333-1-gert@greenie.muc.de\u003e\nURL: https://lore.kernel.org/openvpn-devel/20261104105737.7333-1-gert@greenie.muc.de\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[]}