)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"change_message_id":"a406643eefe27f673e4c39e8cb49660f3f5fead6","unresolved":true,"context_lines":[{"line_number":9,"context_line":"We do not need to limit the maximum ACC message length to just 1280. Also"},{"line_number":10,"context_line":"improve the comments and documentation to be clearer."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Fix that the management notification about negotiated protocol is not send"},{"line_number":13,"context_line":"when in p2p mode (or if a server has push-peer-info in its configuration)"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I3a268fc602e916bf54853c950761977cf3d7f835"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"841bf794_c6ef5615","line":12,"updated":"2026-11-05 05:48:44.000000000","message":"Typo: \"is not sent\".","commit_id":"4789b833c6308269796058871518caef61e2f1b5"},{"author":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"39d4d662e4811a27a69582c3c90251a5f4d2aae9","unresolved":false,"context_lines":[{"line_number":9,"context_line":"We do not need to limit the maximum ACC message length to just 1280. Also"},{"line_number":10,"context_line":"improve the comments and documentation to be clearer."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Fix that the management notification about negotiated protocol is not send"},{"line_number":13,"context_line":"when in p2p mode (or if a server has push-peer-info in its configuration)"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I3a268fc602e916bf54853c950761977cf3d7f835"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5d476727_407cd659","line":12,"in_reply_to":"841bf794_c6ef5615","updated":"2026-11-06 11:27:56.000000000","message":"Done","commit_id":"4789b833c6308269796058871518caef61e2f1b5"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"change_message_id":"a406643eefe27f673e4c39e8cb49660f3f5fead6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"df17bdee_47cfe7ec","updated":"2026-11-05 05:48:44.000000000","message":"test_acc.c:187 fails:\n\n```\n[ RUN      ] test_parse_acc_parameters\n[  ERROR   ] --- 1920 !\u003d 2048\n[   LINE   ] --- test_acc.c:187: error: Failure!\n```","commit_id":"4789b833c6308269796058871518caef61e2f1b5"},{"author":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"change_message_id":"1b956ef5d71ba8b4a1ebf06f3e06125c8f7b47ee","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"04262207_3d87b20a","updated":"2026-11-06 11:40:19.000000000","message":"Unit test fails:\n\n```\n[ RUN      ] test_acc_common_protocols\n[  ERROR   ] --- Test failed with exception: Segmentation fault(11)\n[  FAILED  ] test_acc_common_protocols\n```","commit_id":"960b56641b7814262f6a811e7f4338d4224bb741"},{"author":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"0ec734f257eef075fa929d5e23c53b45bae5ccdf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"874fbfed_81c425dd","in_reply_to":"04262207_3d87b20a","updated":"2026-11-06 12:50:09.000000000","message":"Done","commit_id":"960b56641b7814262f6a811e7f4338d4224bb741"}],"doc/management-notes.txt":[{"author":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"change_message_id":"3cdeb0dd7745da8fe6c0248002c72c4abc13de88","unresolved":true,"context_lines":[{"line_number":1399,"context_line":"    message."},{"line_number":1400,"context_line":""},{"line_number":1401,"context_line":"    Note that fragment is basically a flag for allowing peers communicating"},{"line_number":1402,"context_line":"    over ACC to indicate if multiple ACC message should be considered to"},{"line_number":1403,"context_line":"    be a single message. If the ACC protocol is a stream based protocol"},{"line_number":1404,"context_line":"    then all messages can be sent without fragment flag."},{"line_number":1405,"context_line":""}],"source_content_type":"text/plain","patch_set":1,"id":"bfa11e74_9371b7fb","line":1402,"updated":"2026-11-04 13:10:10.000000000","message":"Typo: \"multiple ACC messages\".","commit_id":"4209c014003f70b1e0fd21f154d8eac8969d816d"},{"author":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"ac9d49f292ef14a7bc00f9fdca31d188b1727532","unresolved":false,"context_lines":[{"line_number":1399,"context_line":"    message."},{"line_number":1400,"context_line":""},{"line_number":1401,"context_line":"    Note that fragment is basically a flag for allowing peers communicating"},{"line_number":1402,"context_line":"    over ACC to indicate if multiple ACC message should be considered to"},{"line_number":1403,"context_line":"    be a single message. If the ACC protocol is a stream based protocol"},{"line_number":1404,"context_line":"    then all messages can be sent without fragment flag."},{"line_number":1405,"context_line":""}],"source_content_type":"text/plain","patch_set":1,"id":"a19e30c2_69218d04","line":1402,"in_reply_to":"bfa11e74_9371b7fb","updated":"2026-11-04 22:53:19.000000000","message":"Done","commit_id":"4209c014003f70b1e0fd21f154d8eac8969d816d"},{"author":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"change_message_id":"3cdeb0dd7745da8fe6c0248002c72c4abc13de88","unresolved":true,"context_lines":[{"line_number":1406,"context_line":"    Note that the OpenVPN implementation allows receiving messages longer than"},{"line_number":1407,"context_line":"    announced maximum allowed message length. Implementations must be prepared"},{"line_number":1408,"context_line":"    to handle messages that are longer than the maximum allowed message length."},{"line_number":1409,"context_line":"    Overlong message are considered invalid and indicate that the peer is"},{"line_number":1410,"context_line":"    misbehaving. Disconnecting/dropping the peer is considered a valid"},{"line_number":1411,"context_line":"    response to such messages."},{"line_number":1412,"context_line":""}],"source_content_type":"text/plain","patch_set":1,"id":"a5bae5a4_0483d27a","line":1409,"updated":"2026-11-04 13:10:10.000000000","message":"Typo: \"messages are\".","commit_id":"4209c014003f70b1e0fd21f154d8eac8969d816d"},{"author":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"ac9d49f292ef14a7bc00f9fdca31d188b1727532","unresolved":false,"context_lines":[{"line_number":1406,"context_line":"    Note that the OpenVPN implementation allows receiving messages longer than"},{"line_number":1407,"context_line":"    announced maximum allowed message length. Implementations must be prepared"},{"line_number":1408,"context_line":"    to handle messages that are longer than the maximum allowed message length."},{"line_number":1409,"context_line":"    Overlong message are considered invalid and indicate that the peer is"},{"line_number":1410,"context_line":"    misbehaving. Disconnecting/dropping the peer is considered a valid"},{"line_number":1411,"context_line":"    response to such messages."},{"line_number":1412,"context_line":""}],"source_content_type":"text/plain","patch_set":1,"id":"b73e4230_fc7b832e","line":1409,"in_reply_to":"a5bae5a4_0483d27a","updated":"2026-11-04 22:53:19.000000000","message":"Done","commit_id":"4209c014003f70b1e0fd21f154d8eac8969d816d"}],"src/openvpn/acc.c":[{"author":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"change_message_id":"3cdeb0dd7745da8fe6c0248002c72c4abc13de88","unresolved":true,"context_lines":[{"line_number":192,"context_line":"    /* We do not check the length here. We make no promises to support"},{"line_number":193,"context_line":"     * anything larger than our announced message length but we accept also"},{"line_number":194,"context_line":"     * longer messages if they manage to get through all the other layers"},{"line_number":195,"context_line":"     * that restrict the message size like TLS_CHANNEL_BUF_SIZE (2048)."},{"line_number":196,"context_line":"     */"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"    int payload_len;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"ee84d8bb_d6892e3a","line":195,"updated":"2026-11-04 13:10:10.000000000","message":"Here too, not sure if we want to risk the comment going stale about the size of `TLS_CHANNEL_BUF_SIZE`.","commit_id":"4209c014003f70b1e0fd21f154d8eac8969d816d"},{"author":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"ac9d49f292ef14a7bc00f9fdca31d188b1727532","unresolved":false,"context_lines":[{"line_number":192,"context_line":"    /* We do not check the length here. We make no promises to support"},{"line_number":193,"context_line":"     * anything larger than our announced message length but we accept also"},{"line_number":194,"context_line":"     * longer messages if they manage to get through all the other layers"},{"line_number":195,"context_line":"     * that restrict the message size like TLS_CHANNEL_BUF_SIZE (2048)."},{"line_number":196,"context_line":"     */"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"    int payload_len;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"12dd80eb_41ce3fb8","line":195,"in_reply_to":"ee84d8bb_d6892e3a","updated":"2026-11-04 22:53:19.000000000","message":"Done","commit_id":"4209c014003f70b1e0fd21f154d8eac8969d816d"}],"src/openvpn/acc.h":[{"author":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"change_message_id":"3cdeb0dd7745da8fe6c0248002c72c4abc13de88","unresolved":true,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"#define ACC_MIN_MSG_LEN 64"},{"line_number":32,"context_line":"/* This is a conservative limit. The theoretical maximum"},{"line_number":33,"context_line":" * is much closer to the TLS_CHANNEL_BUF_SIZE (2048) */"},{"line_number":34,"context_line":"#define ACC_MAX_MSG_LEN (TLS_CHANNEL_BUF_SIZE - 128)"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"/**"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"7205cdbd_ccbb7378","line":33,"updated":"2026-11-04 13:10:10.000000000","message":"Do we want to specify the current size of `TLS_CHANNEL_BUF_SIZE`? This comment could go stale if that changes.","commit_id":"4209c014003f70b1e0fd21f154d8eac8969d816d"},{"author":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"ac9d49f292ef14a7bc00f9fdca31d188b1727532","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"#define ACC_MIN_MSG_LEN 64"},{"line_number":32,"context_line":"/* This is a conservative limit. The theoretical maximum"},{"line_number":33,"context_line":" * is much closer to the TLS_CHANNEL_BUF_SIZE (2048) */"},{"line_number":34,"context_line":"#define ACC_MAX_MSG_LEN (TLS_CHANNEL_BUF_SIZE - 128)"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"/**"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"5d6e8f38_20e1c944","line":33,"in_reply_to":"7205cdbd_ccbb7378","updated":"2026-11-04 22:53:19.000000000","message":"Done","commit_id":"4209c014003f70b1e0fd21f154d8eac8969d816d"},{"author":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"change_message_id":"c34cdcadecd21ba98f8e9ab3046142501ccf59cc","unresolved":true,"context_lines":[{"line_number":31,"context_line":"#define ACC_MIN_MSG_LEN 64"},{"line_number":32,"context_line":"/* This is a conservative limit. The theoretical maximum"},{"line_number":33,"context_line":" * is much closer to the TLS_CHANNEL_BUF_SIZE */"},{"line_number":34,"context_line":"#define ACC_MAX_MSG_LEN (TLS_CHANNEL_BUF_SIZE - 128)"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"/**"},{"line_number":37,"context_line":" * This method parses an app custom control message and delivers it to the"}],"source_content_type":"text/x-csrc","patch_set":4,"id":"8caf0242_92628aaa","line":34,"updated":"2026-11-05 16:45:38.000000000","message":"`log_acc_message()` sends messages through `msg()` which formats them into buffers of `ERR_BUF_SIZE` which is currently `1280`.\n\n`ACC_MAX_MSG_LEN` is now `1920` so bigger than what can be delivered.\n\nNot sure if we want to fix that.","commit_id":"3d760aa23b004c8e6b95875d7d76209bcf129a19"},{"author":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"4c111c90519023ef089aadf2875603b53afe1777","unresolved":false,"context_lines":[{"line_number":31,"context_line":"#define ACC_MIN_MSG_LEN 64"},{"line_number":32,"context_line":"/* This is a conservative limit. The theoretical maximum"},{"line_number":33,"context_line":" * is much closer to the TLS_CHANNEL_BUF_SIZE */"},{"line_number":34,"context_line":"#define ACC_MAX_MSG_LEN (TLS_CHANNEL_BUF_SIZE - 128)"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"/**"},{"line_number":37,"context_line":" * This method parses an app custom control message and delivers it to the"}],"source_content_type":"text/x-csrc","patch_set":4,"id":"3f650cc5_e0594e8b","line":34,"in_reply_to":"8caf0242_92628aaa","updated":"2026-11-06 11:27:45.000000000","message":"I don\u0027t think that is correct. The only part in this function that logs the payload  itself is inside `#ifdef ENABLE_MANAGEMENT` and if that is enabled the ERR_BUF_SIZE is 10240:\n\n#if defined(ENABLE_PKCS11) || defined(ENABLE_MANAGEMENT)\n#define ERR_BUF_SIZE 10240\n#else\n#define ERR_BUF_SIZE 1280\n#endif","commit_id":"3d760aa23b004c8e6b95875d7d76209bcf129a19"}],"src/openvpn/ssl.c":[{"author":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"change_message_id":"c34cdcadecd21ba98f8e9ab3046142501ccf59cc","unresolved":true,"context_lines":[{"line_number":2400,"context_line":"    {"},{"line_number":2401,"context_line":"        /* This is required to support ACC in p2p mode or when the server"},{"line_number":2402,"context_line":"         * sends peer-info */"},{"line_number":2403,"context_line":"        notify_client_acc_protocols(multi);"},{"line_number":2404,"context_line":"    }"},{"line_number":2405,"context_line":""},{"line_number":2406,"context_line":"    if (username_len \u003c 0 || password_len \u003c 0)"}],"source_content_type":"text/x-csrc","patch_set":4,"id":"0478a2e2_94f4f011","line":2403,"updated":"2026-11-05 16:45:38.000000000","message":"This seems to be sent out regardless of whether negotiation worked or not.\n\nWould it be acceptable to send it in `determine_common_acc_protocols()` after `after acc_negotiated_protocols` is set, when `when multi-\u003eopt.mode !\u003d MODE_SERVER`?","commit_id":"3d760aa23b004c8e6b95875d7d76209bcf129a19"},{"author":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"4c111c90519023ef089aadf2875603b53afe1777","unresolved":false,"context_lines":[{"line_number":2400,"context_line":"    {"},{"line_number":2401,"context_line":"        /* This is required to support ACC in p2p mode or when the server"},{"line_number":2402,"context_line":"         * sends peer-info */"},{"line_number":2403,"context_line":"        notify_client_acc_protocols(multi);"},{"line_number":2404,"context_line":"    }"},{"line_number":2405,"context_line":""},{"line_number":2406,"context_line":"    if (username_len \u003c 0 || password_len \u003c 0)"}],"source_content_type":"text/x-csrc","patch_set":4,"id":"7e0a3db1_515763c7","line":2403,"in_reply_to":"0478a2e2_94f4f011","updated":"2026-11-06 11:27:45.000000000","message":"Done","commit_id":"3d760aa23b004c8e6b95875d7d76209bcf129a19"}],"tests/unit_tests/openvpn/test_acc.c":[{"author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"479b2079e9a5dadc5bc675717468f8f28d3e77b1","unresolved":true,"context_lines":[{"line_number":181,"context_line":"    int max_len \u003d 0;"},{"line_number":182,"context_line":"    const char *protocols \u003d parse_acc_parameters(info_acc_msg, \" \", \u0026max_len, true, \u0026gc);"},{"line_number":183,"context_line":"    assert_string_equal(protocols, \"flower:happy\");"},{"line_number":184,"context_line":"    assert_int_equal(max_len, 2048 - 128);"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"    /* a client does not accept a length longer than it supports */"},{"line_number":187,"context_line":"    protocols \u003d parse_acc_parameters(info_acc_msg, \" \", \u0026max_len, false, \u0026gc);"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"228c03b9_62755275","line":184,"updated":"2026-11-04 12:38:33.000000000","message":"Why not use ACC_MAX_MSG_LEN here?","commit_id":"4209c014003f70b1e0fd21f154d8eac8969d816d"},{"author":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"ac9d49f292ef14a7bc00f9fdca31d188b1727532","unresolved":false,"context_lines":[{"line_number":181,"context_line":"    int max_len \u003d 0;"},{"line_number":182,"context_line":"    const char *protocols \u003d parse_acc_parameters(info_acc_msg, \" \", \u0026max_len, true, \u0026gc);"},{"line_number":183,"context_line":"    assert_string_equal(protocols, \"flower:happy\");"},{"line_number":184,"context_line":"    assert_int_equal(max_len, 2048 - 128);"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"    /* a client does not accept a length longer than it supports */"},{"line_number":187,"context_line":"    protocols \u003d parse_acc_parameters(info_acc_msg, \" \", \u0026max_len, false, \u0026gc);"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"74bb1b1e_25d0af58","line":184,"in_reply_to":"228c03b9_62755275","updated":"2026-11-04 22:53:19.000000000","message":"Done","commit_id":"4209c014003f70b1e0fd21f154d8eac8969d816d"}]}