)]}'
{"id":"openvpn~2141","triplet_id":"openvpn~release%2F2.7~I13f9f7dd61d7a4cc986155629f6a3c792aaac6d2","project":"openvpn","branch":"release/2.7","full_branch":"refs/heads/release/2.7","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2026-11-06 09:39:50.000000000","reason":"Change was submitted"},"1000002":{"account":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"last_update":"2026-11-06 09:39:50.000000000","reason":"Change was submitted"},"1000001":{"account":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2026-11-05 11:20:57.000000000","reason":"\u003cGERRIT_ACCOUNT_1000001\u003e replied on the change","reason_account":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."}}},"hashtags":[],"change_id":"I13f9f7dd61d7a4cc986155629f6a3c792aaac6d2","subject":"backport t_client.sh changes from master","status":"MERGED","created":"2026-11-05 09:59:44.000000000","updated":"2026-11-06 09:39:50.000000000","submitted":"2026-11-06 09:39:50.000000000","submitter":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"2141","meta_rev_id":"1cb13e2fee7998f017f6c932478f485dbbcee573","_number":2141,"virtual_id_number":2141,"owner":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"value":0,"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-11-05 09:59:44.000000000","updated_by":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"real_updated_by":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2026-11-05 09:59:44.000000000","updated_by":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"real_updated_by":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2026-11-05 10:09:00.000000000","updated_by":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"real_updated_by":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REMOVED"},{"updated":"2026-11-05 10:09:00.000000000","updated_by":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"real_updated_by":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"state":"REVIEWER"},{"updated":"2026-11-05 13:56:52.000000000","updated_by":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"real_updated_by":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"}],"messages":[{"id":"3023bb071726e19b310f1629cff007438243114c","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2026-11-05 09:59:44.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"60267a7884f467190209403440182e2ef5f6d485","tag":"autogenerated:gerrit:deleteReviewer","author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2026-11-05 10:09:00.000000000","message":"Removed reviewer \u003cGERRIT_ACCOUNT_1000003\u003e.","accounts_in_message":[{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"_revision_number":1},{"id":"6331709cd52e0fa33591444bb91e4b9a8a9bd5f5","author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-11-05 11:20:57.000000000","message":"Patch Set 1: Code-Review-2\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"9bac6999279b860089af65b77445deb54ca988c8","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2026-11-05 13:56:52.000000000","message":"Uploaded patch set 2.\n\nCopied Votes:\n* Code-Review-2 (copy condition: \"changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR **is:MIN**\")\n","accounts_in_message":[],"_revision_number":2},{"id":"997d501a26a0427cd944a26e3a1f136a23e20874","author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-11-05 15:23:07.000000000","message":"Patch Set 2: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"1cb13e2fee7998f017f6c932478f485dbbcee573","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2026-11-06 09:39:50.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"7804cf0170ecc8019c7eff79db9fa13a6108d080","revisions":{"58bbdfa2db1fda07c3f99eaeeaac00920b3b1626":{"kind":"REWORK","_number":1,"created":"2026-11-05 09:59:44.000000000","uploader":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/41/2141/1","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/41/2141/1","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/41/2141/1 \u0026\u0026 git checkout -b change-2141 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/41/2141/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/41/2141/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/41/2141/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/41/2141/1","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/41/2141/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"f5cb028cb6424b778658adbc5989f57901da79b1","subject":"port-share: do not write journal file through symlinks or hardlinks"}],"author":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2026-11-05 09:52:11.000000000","tz":60},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2026-11-05 09:52:11.000000000","tz":60},"subject":"backport t_client.sh changes from master","message":"backport t_client.sh changes from master\n\nThis is basically just copying in the current t_client.sh.in script from\nmaster, with a number of changes that are not in 2.7 yet - most notably\nsupport for \"expect failure\" cases.\n\nGiven that this is a test support script with no dependencies into the\nOpenVPN core, and the large number of non-backported scripts that touch\none line or the other, or re-indent things, copying the whole script\ninstead of trying to cherry-pick all the individual change seemed like\na much better idea...\n\nHere\u0027s the list:\n\ncommit e2548f6e3b7f9ed3d24020319117b17f30743656\n    t_client.sh.in: Check whether addresses are in \"tentative\" state\n\ncommit af6a79c6a83739ca9542e52a02a3449a2f292758\n    t_client.sh.in: Add ability to filter by test group\n\ncommit dc162485236b70ecfe1be639dbd9db8244a85d54\n    t_client.sh.in: Allow to override the location of t_client_ips.rc\n\ncommit 8b392d642eb4c9b9135dc6a442d943159467e058\n    t_client.sh.in: Add utility function needs_openvpn()\n\ncommit dc162485236b70ecfe1be639dbd9db8244a85d54\n    t_client.sh.in: Allow to override the location of t_client_ips.rc\n\ncommit 37ea1c7683ccb464f80d6e7e8fbcd4b8baf2ac60\n    t_client.sh.in: Add support for expected test failures\n\ncommit ed427eab1683af3adf21553dd1c6b6e4b8b2f10d\n    reformat-shell.sh: Add --simplify argument\n\ncommit f781227c92a3d1017e9d8a67e83e4465b43edf66\n    Reformat all shell-scripts with shfmt\n\ncommit b32d1ab45ec93786191e0dac2c8f5549d6c04258\n    t_client.sh.in: Do not try to guess the absolute path to LOGDIR\n\ncommit da1b2a7081eb2791f3a675945c42d7f3189ef752\n    t_client.sh.in: Use printf instead of echo -e\n\ncommit 162f19112702d1c8045efd17c5b09022fe1e04fb\n    t_client.sh.in: Do not run resolvectl if systemd is not running\n\ncommit 841ab0b216a424eb0100448362f76a2c12b3a516\n    t_client.sh: Do not use CA_CERT variable as indicator for good .rc file\n\nChange-Id: I13f9f7dd61d7a4cc986155629f6a3c792aaac6d2\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/release/2.7"},"ac887c352dcf82277edf8772139e0056467426c2":{"kind":"REWORK","_number":2,"created":"2026-11-05 13:56:52.000000000","uploader":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/41/2141/2","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/41/2141/2","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/41/2141/2 \u0026\u0026 git checkout -b change-2141 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/41/2141/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/41/2141/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/41/2141/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/41/2141/2","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/41/2141/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"f5cb028cb6424b778658adbc5989f57901da79b1","subject":"port-share: do not write journal file through symlinks or hardlinks"}],"author":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2026-11-05 09:52:11.000000000","tz":60},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2026-11-05 13:54:59.000000000","tz":60},"subject":"backport t_client.sh changes from master","message":"backport t_client.sh changes from master\n\nThis is basically just copying in the current t_client.sh.in script from\nmaster, with a number of changes that are not in 2.7 yet - most notably\nsupport for \"expect failure\" cases.\n\nGiven that this is a test support script with no dependencies into the\nOpenVPN core, and the large number of non-backported scripts that touch\none line or the other, or re-indent things, copying the whole script\ninstead of trying to cherry-pick all the individual change seemed like\na much better idea...\n\nBesides t_client.sh, this also brings tests/update_t_client_ips.sh\nfrom master, because the dc16248523 commit will break functionality\notherwise.\n\nHere\u0027s the list:\n\ncommit e2548f6e3b7f9ed3d24020319117b17f30743656\n    t_client.sh.in: Check whether addresses are in \"tentative\" state\n\ncommit af6a79c6a83739ca9542e52a02a3449a2f292758\n    t_client.sh.in: Add ability to filter by test group\n\ncommit dc162485236b70ecfe1be639dbd9db8244a85d54\n    t_client.sh.in: Allow to override the location of t_client_ips.rc\n    (needs updated update_t_client_ips.sh)\n\ncommit 8b392d642eb4c9b9135dc6a442d943159467e058\n    t_client.sh.in: Add utility function needs_openvpn()\n\ncommit dc162485236b70ecfe1be639dbd9db8244a85d54\n    t_client.sh.in: Allow to override the location of t_client_ips.rc\n\ncommit 37ea1c7683ccb464f80d6e7e8fbcd4b8baf2ac60\n    t_client.sh.in: Add support for expected test failures\n\ncommit ed427eab1683af3adf21553dd1c6b6e4b8b2f10d\n    reformat-shell.sh: Add --simplify argument\n\ncommit f781227c92a3d1017e9d8a67e83e4465b43edf66\n    Reformat all shell-scripts with shfmt\n    (touches update_t_client_ips.sh)\n\ncommit b32d1ab45ec93786191e0dac2c8f5549d6c04258\n    t_client.sh.in: Do not try to guess the absolute path to LOGDIR\n\ncommit da1b2a7081eb2791f3a675945c42d7f3189ef752\n    t_client.sh.in: Use printf instead of echo -e\n\ncommit 162f19112702d1c8045efd17c5b09022fe1e04fb\n    t_client.sh.in: Do not run resolvectl if systemd is not running\n\ncommit 841ab0b216a424eb0100448362f76a2c12b3a516\n    t_client.sh: Do not use CA_CERT variable as indicator for good .rc file\n\nChange-Id: I13f9f7dd61d7a4cc986155629f6a3c792aaac6d2\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/release/2.7"},"7804cf0170ecc8019c7eff79db9fa13a6108d080":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":3,"created":"2026-11-06 09:39:50.000000000","uploader":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/41/2141/3","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/41/2141/3","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/41/2141/3 \u0026\u0026 git checkout -b change-2141 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/41/2141/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/41/2141/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/41/2141/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/41/2141/3","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/41/2141/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"4608daa51451fd63c52cc2e44371608604259a99","subject":"crypto: Wipe the struct key_parameters copies after use"}],"author":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2026-11-05 16:49:21.000000000","tz":60},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2026-11-06 09:10:53.000000000","tz":60},"subject":"backport t_client.sh changes from master","message":"backport t_client.sh changes from master\n\nThis is basically just copying in the current t_client.sh.in script from\nmaster, with a number of changes that are not in 2.7 yet - most notably\nsupport for \"expect failure\" cases.\n\nGiven that this is a test support script with no dependencies into the\nOpenVPN core, and the large number of non-backported scripts that touch\none line or the other, or re-indent things, copying the whole script\ninstead of trying to cherry-pick all the individual change seemed like\na much better idea...\n\nBesides t_client.sh, this also brings tests/update_t_client_ips.sh\nfrom master, because the dc16248523 commit will break functionality\notherwise.\n\nHere\u0027s the list:\n\ncommit e2548f6e3b7f9ed3d24020319117b17f30743656\n    t_client.sh.in: Check whether addresses are in \"tentative\" state\n\ncommit af6a79c6a83739ca9542e52a02a3449a2f292758\n    t_client.sh.in: Add ability to filter by test group\n\ncommit dc162485236b70ecfe1be639dbd9db8244a85d54\n    t_client.sh.in: Allow to override the location of t_client_ips.rc\n    (needs updated update_t_client_ips.sh)\n\ncommit 8b392d642eb4c9b9135dc6a442d943159467e058\n    t_client.sh.in: Add utility function needs_openvpn()\n\ncommit dc162485236b70ecfe1be639dbd9db8244a85d54\n    t_client.sh.in: Allow to override the location of t_client_ips.rc\n\ncommit 37ea1c7683ccb464f80d6e7e8fbcd4b8baf2ac60\n    t_client.sh.in: Add support for expected test failures\n\ncommit ed427eab1683af3adf21553dd1c6b6e4b8b2f10d\n    reformat-shell.sh: Add --simplify argument\n\ncommit f781227c92a3d1017e9d8a67e83e4465b43edf66\n    Reformat all shell-scripts with shfmt\n    (touches update_t_client_ips.sh)\n\ncommit b32d1ab45ec93786191e0dac2c8f5549d6c04258\n    t_client.sh.in: Do not try to guess the absolute path to LOGDIR\n\ncommit da1b2a7081eb2791f3a675945c42d7f3189ef752\n    t_client.sh.in: Use printf instead of echo -e\n\ncommit 162f19112702d1c8045efd17c5b09022fe1e04fb\n    t_client.sh.in: Do not run resolvectl if systemd is not running\n\ncommit 841ab0b216a424eb0100448362f76a2c12b3a516\n    t_client.sh: Do not use CA_CERT variable as indicator for good .rc file\n\nChange-Id: I13f9f7dd61d7a4cc986155629f6a3c792aaac6d2\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\nAcked-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\nGerrit URL: https://gerrit.openvpn.net/c/openvpn/+/2141\nMessage-Id: \u003c20261105164926.24646-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg40756.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/release/2.7"}},"requirements":[],"submit_records":[]}