)]}'
{"id":"openvpn~2142","triplet_id":"openvpn~master~I784f3ffe17ecadabf96caad11fe9f774aa00b7cc","project":"openvpn","branch":"master","full_branch":"refs/heads/master","attention_set":{},"removed_from_attention_set":{"1000053":{"account":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"last_update":"2026-11-08 13:17:42.000000000","reason":"Change was submitted"},"1000003":{"account":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2026-11-06 10:09:03.000000000","reason":"removed on reply"}},"hashtags":[],"change_id":"I784f3ffe17ecadabf96caad11fe9f774aa00b7cc","subject":"comp: use the wire byte when escaping v2 uncompressed packets","status":"MERGED","created":"2026-11-06 06:46:47.000000000","updated":"2026-11-08 13:17:42.000000000","submitted":"2026-11-08 13:17:42.000000000","submitter":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"2142","meta_rev_id":"6fe69e452693669e1d494180f39d448513664e2c","_number":2142,"virtual_id_number":2142,"owner":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"value":0,"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-11-06 06:46:47.000000000","updated_by":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"real_updated_by":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2026-11-06 06:46:47.000000000","updated_by":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"real_updated_by":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"reviewer":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"}],"messages":[{"id":"2fb033926e249140e693ce3b6436c5c0d9a79804","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"date":"2026-11-06 06:46:47.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"58a319c3dda714bc898683035b6858705a1d226c","author":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2026-11-06 10:09:03.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"6fe69e452693669e1d494180f39d448513664e2c","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2026-11-08 13:17:42.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"ebc370a5a232aff244c9d2d1f8497c665e6bd853","revisions":{"6422a369d480b3f6f3a99471b8a1b81a7189dc97":{"kind":"REWORK","_number":1,"created":"2026-11-06 06:46:47.000000000","uploader":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"ref":"refs/changes/42/2142/1","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/42/2142/1","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/42/2142/1 \u0026\u0026 git checkout -b change-2142 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/42/2142/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/42/2142/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/42/2142/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/42/2142/1","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/42/2142/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"4333525868d68593bbdb5c4270f21275d6a35466","subject":"misc: Fix username overflow spilling into password"}],"author":{"name":"Razvan Cojocaru","email":"razvanc@mailbox.org","date":"2026-11-05 12:31:51.000000000","tz":120},"committer":{"name":"Razvan Cojocaru","email":"razvanc@mailbox.org","date":"2026-11-05 12:31:51.000000000","tz":120},"subject":"comp: use the wire byte when escaping v2 uncompressed packets","message":"comp: use the wire byte when escaping v2 uncompressed packets\n\ncompv2_escape_data_ifneeded() wrote COMP_ALGV2_UNCOMPRESSED (the\nalgorithm id, 10) instead of COMP_ALGV2_UNCOMPRESSED_BYTE (0) after\nthe 0x50 indicator. Receivers reject that header, so packets whose\nfirst byte is 0x50 were dropped with stub-v2 and lz4-v2, e.g. tap\nframes to a MAC address starting with 0x50.\n\nBroken since a75bb2e4 (\"Implement the compression V2 data format for\nstub and lz4.\").\n\nChange-Id: I784f3ffe17ecadabf96caad11fe9f774aa00b7cc\nSigned-off-by: Razvan Cojocaru \u003crazvanc@mailbox.org\u003e\n"},"branch":"refs/heads/master"},"ebc370a5a232aff244c9d2d1f8497c665e6bd853":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":2,"created":"2026-11-08 13:17:42.000000000","uploader":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/42/2142/2","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/42/2142/2","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/42/2142/2 \u0026\u0026 git checkout -b change-2142 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/42/2142/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/42/2142/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/42/2142/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/42/2142/2","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/42/2142/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"5b08a76c1a3215c9c927909e695ccd8e83eb6895","subject":"Make parameter openvpn_net_ctx_t const where possible"}],"author":{"name":"Razvan Cojocaru","email":"razvanc@mailbox.org","date":"2026-11-06 12:57:50.000000000","tz":60},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2026-11-08 13:09:55.000000000","tz":60},"subject":"comp: use the wire byte when escaping v2 uncompressed packets","message":"comp: use the wire byte when escaping v2 uncompressed packets\n\ncompv2_escape_data_ifneeded() wrote COMP_ALGV2_UNCOMPRESSED (the\nalgorithm id, 10) instead of COMP_ALGV2_UNCOMPRESSED_BYTE (0) after\nthe 0x50 indicator. Receivers reject that header, so packets whose\nfirst byte is 0x50 were dropped with stub-v2 and lz4-v2, e.g. tap\nframes to a MAC address starting with 0x50.\n\nBroken since a75bb2e4 (\"Implement the compression V2 data format for\nstub and lz4.\").\n\nChange-Id: I784f3ffe17ecadabf96caad11fe9f774aa00b7cc\nSigned-off-by: Razvan Cojocaru \u003crazvanc@mailbox.org\u003e\nAcked-by: Arne Schwabe \u003carne-openvpn@rfc2549.org\u003e\nGerrit URL: https://gerrit.openvpn.net/c/openvpn/+/2142\nMessage-Id: \u003c20261106125757.14721-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg40883.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[]}