)]}'
{"id":"openvpn~2143","triplet_id":"openvpn~master~I7c9e123a458b9d3757e9de93f401e4e421741675","project":"openvpn","branch":"master","full_branch":"refs/heads/master","attention_set":{"1000053":{"account":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"last_update":"2026-11-06 15:31:29.000000000","reason":"Someone else replied on the change"},"1000003":{"account":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2026-11-06 08:51:53.000000000","reason":"Reviewer was added"}},"removed_from_attention_set":{},"hashtags":[],"change_id":"I7c9e123a458b9d3757e9de93f401e4e421741675","subject":"comp: share the stub compress methods with LZO and LZ4","status":"NEW","created":"2026-11-06 08:51:52.000000000","updated":"2026-11-06 15:31:29.000000000","submit_type":"CHERRY_PICK","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"27e4717acb898509818104d18709e2425b106bc6","_number":2143,"virtual_id_number":2143,"owner":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"actions":{},"labels":{"Code-Review":{"approved":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"all":[{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"value":2,"date":"2026-11-06 15:31:29.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-11-06 08:51:53.000000000","updated_by":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"real_updated_by":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2026-11-06 08:51:53.000000000","updated_by":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"real_updated_by":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"reviewer":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2026-11-06 15:31:29.000000000","updated_by":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"real_updated_by":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"state":"REVIEWER"}],"messages":[{"id":"6afb0e001326c3b58549c48ee7d11f5efe5199d0","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"date":"2026-11-06 08:51:52.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"27e4717acb898509818104d18709e2425b106bc6","author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-11-06 15:31:29.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"6579489bd3a3b39f9e153ac50c9d01887c9811a1","revisions":{"6579489bd3a3b39f9e153ac50c9d01887c9811a1":{"kind":"REWORK","_number":1,"created":"2026-11-06 08:51:52.000000000","uploader":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"ref":"refs/changes/43/2143/1","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/43/2143/1","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/43/2143/1 \u0026\u0026 git checkout -b change-2143 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/43/2143/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/43/2143/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/43/2143/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/43/2143/1","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/43/2143/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"41889e72a604e500c33392df93a62ef60c14d1f1","subject":"lladdr: pass S_* flags, not M_WARN, to openvpn_execve_check()"}],"author":{"name":"Razvan Cojocaru","email":"razvanc@mailbox.org","date":"2026-11-06 08:36:00.000000000","tz":120},"committer":{"name":"Razvan Cojocaru","email":"razvanc@mailbox.org","date":"2026-11-06 08:48:27.000000000","tz":120},"subject":"comp: share the stub compress methods with LZO and LZ4","message":"comp: share the stub compress methods with LZO and LZ4\n\nSince 7f0214c9 (\"Remove support for compression on send\") the LZO and\nLZ4 compress methods only add the stub framing, duplicating\nstub_compress() and stubv2_compress(). Export those as\ncomp_stub_compress() and compv2_stub_compress() and use them for all\nmethods. Also allocate the context only once in comp_init().\n\nThis also fixes LZO sending dropped packets. encrypt_sign() drops\npackets by setting buf.len to 0 (e.g. before client-connect has\ncompleted) and still calls the compress method. lzo_compress()\nprepended NO_COMPRESS_BYTE regardless, turning the dropped packet into\na one byte packet that was sent. The stub methods return early on\nempty buffers.\n\nChange-Id: I7c9e123a458b9d3757e9de93f401e4e421741675\nSigned-off-by: Razvan Cojocaru \u003crazvanc@mailbox.org\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"OK","labels":[{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."}}]},{"rule_name":"checks~ChecksSubmitRule","status":"OK"}]}