)]}'
{"id":"openvpn~2145","triplet_id":"openvpn~master~I76cd424b34e91f07a6d187b23a258d9dcbf7ed0f","project":"openvpn","branch":"master","full_branch":"refs/heads/master","attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2026-11-06 09:38:30.000000000","reason":"Reviewer was added"}},"removed_from_attention_set":{},"hashtags":[],"change_id":"I76cd424b34e91f07a6d187b23a258d9dcbf7ed0f","subject":"ssl_verify: share fingerprint and x509 env helpers between backends","status":"NEW","created":"2026-11-06 09:38:29.000000000","updated":"2026-11-06 09:44:18.000000000","submit_type":"CHERRY_PICK","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"2b444e6a7a3ff3335b802ab331705f2ca14590d7","_number":2145,"virtual_id_number":2145,"owner":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-11-06 09:38:30.000000000","updated_by":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"real_updated_by":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2026-11-06 09:38:30.000000000","updated_by":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"real_updated_by":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"reviewer":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"}],"messages":[{"id":"369fbc4d1e662c19b830e02c9152c92445326823","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"date":"2026-11-06 09:38:29.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"2b444e6a7a3ff3335b802ab331705f2ca14590d7","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"date":"2026-11-06 09:44:18.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"f78670921980cd9e5b9e1339a12d9a57238038e6","revisions":{"ed6d6e0d2cf544637ceadd065a29caccec2fd233":{"kind":"REWORK","_number":1,"created":"2026-11-06 09:38:29.000000000","uploader":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"ref":"refs/changes/45/2145/1","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/45/2145/1","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/45/2145/1 \u0026\u0026 git checkout -b change-2145 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/45/2145/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/45/2145/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/45/2145/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/45/2145/1","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/45/2145/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"41889e72a604e500c33392df93a62ef60c14d1f1","subject":"lladdr: pass S_* flags, not M_WARN, to openvpn_execve_check()"}],"author":{"name":"Razvan Cojocaru","email":"razvanc@mailbox.org","date":"2026-11-06 09:18:48.000000000","tz":120},"committer":{"name":"Razvan Cojocaru","email":"razvanc@mailbox.org","date":"2026-11-06 09:32:36.000000000","tz":120},"subject":"ssl_verify: share fingerprint and x509 env helpers between backends","message":"ssl_verify: share fingerprint and x509 env helpers between backends\n\nReplace x509_get_sha1_fingerprint() and x509_get_sha256_fingerprint()\nwith x509_get_fingerprint(cert, algo, gc) in both backends. This also\nremoves the switch in verify_cert(), whose default case could not be\nreached, as verify_hash_algo is always MD_SHA1 or MD_SHA256. The\nbackends now switch over the enum without a default, so a new\nalgorithm gets a -Wswitch warning, and ASSERT on unknown values.\n\nMove the identical do_setenv_x509() copies from the backends to\nssl_verify.c, with a stub for test_ssl as for verify_cert().\n\nChange-Id: I76cd424b34e91f07a6d187b23a258d9dcbf7ed0f\nSigned-off-by: Razvan Cojocaru \u003crazvanc@mailbox.org\u003e\n"},"branch":"refs/heads/master"},"f78670921980cd9e5b9e1339a12d9a57238038e6":{"kind":"REWORK","_number":2,"created":"2026-11-06 09:44:18.000000000","uploader":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"ref":"refs/changes/45/2145/2","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/45/2145/2","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/45/2145/2 \u0026\u0026 git checkout -b change-2145 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/45/2145/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/45/2145/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/45/2145/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/45/2145/2","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/45/2145/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"41889e72a604e500c33392df93a62ef60c14d1f1","subject":"lladdr: pass S_* flags, not M_WARN, to openvpn_execve_check()"}],"author":{"name":"Razvan Cojocaru","email":"razvanc@mailbox.org","date":"2026-11-06 09:18:48.000000000","tz":120},"committer":{"name":"Razvan Cojocaru","email":"razvanc@mailbox.org","date":"2026-11-06 09:43:40.000000000","tz":120},"subject":"ssl_verify: share fingerprint and x509 env helpers between backends","message":"ssl_verify: share fingerprint and x509 env helpers between backends\n\nReplace x509_get_sha1_fingerprint() and x509_get_sha256_fingerprint()\nwith x509_get_fingerprint(cert, algo, gc) in both backends. This also\nremoves the switch in verify_cert(), whose default case could not be\nreached, as verify_hash_algo is always MD_SHA1 or MD_SHA256. The\nbackends now switch over the enum without a default, so a new\nalgorithm gets a -Wswitch warning, and ASSERT on unknown values.\n\nMove the identical do_setenv_x509() copies from the backends to\nssl_verify.c, with a stub for test_ssl as for verify_cert().\n\nChange-Id: I76cd424b34e91f07a6d187b23a258d9dcbf7ed0f\nSigned-off-by: Razvan Cojocaru \u003crazvanc@mailbox.org\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"NOT_READY","labels":[{"label":"Code-Review","status":"NEED"}]},{"rule_name":"checks~ChecksSubmitRule","status":"OK"}]}