)]}'
{"id":"openvpn~2146","triplet_id":"openvpn~master~Ied9e36d45b30a88610cafee668ecefa98b29eddc","project":"openvpn","branch":"master","full_branch":"refs/heads/master","topic":"oob-groundwork","attention_set":{},"removed_from_attention_set":{"1000008":{"account":{"_account_id":1000008,"name":"Lev Stipakov","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"last_update":"2026-11-09 12:06:12.000000000","reason":"Change was submitted"},"1000003":{"account":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2026-11-09 12:06:12.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Ied9e36d45b30a88610cafee668ecefa98b29eddc","subject":"reflect_filter: initialise warning_displayed in the rate limiter","status":"MERGED","created":"2026-11-06 13:03:21.000000000","updated":"2026-11-09 12:06:12.000000000","submitted":"2026-11-09 12:06:12.000000000","submitter":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"2146-oob-groundwork","meta_rev_id":"be8cf5f26cac534ddbca87fba9e82ac625309803","_number":2146,"virtual_id_number":2146,"owner":{"_account_id":1000008,"name":"Lev Stipakov","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},{"value":0,"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"value":0,"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-11-06 13:03:21.000000000","updated_by":{"_account_id":1000008,"name":"Lev Stipakov","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"real_updated_by":{"_account_id":1000008,"name":"Lev Stipakov","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2026-11-06 13:03:21.000000000","updated_by":{"_account_id":1000008,"name":"Lev Stipakov","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"real_updated_by":{"_account_id":1000008,"name":"Lev Stipakov","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"reviewer":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2026-11-09 09:00:43.000000000","updated_by":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"real_updated_by":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"reviewer":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"state":"REVIEWER"}],"messages":[{"id":"4cae0f8528eda8e5ab01cc69808daea308d71b9e","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000008,"name":"Lev Stipakov","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"date":"2026-11-06 13:03:21.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"6d7fbd055b8987643b03ae45f9012add43e913e0","author":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2026-11-06 14:07:29.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"1740a8de6d27796b71124ed13f7ccab650507c52","author":{"_account_id":1000008,"name":"Lev Stipakov","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"date":"2026-11-09 08:35:40.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"2f5557646bc320f00983cbe9f92ad05ccdeb185b","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000008,"name":"Lev Stipakov","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"date":"2026-11-09 08:37:48.000000000","message":"Uploaded patch set 2.\n\nOutdated Votes:\n* Code-Review-1 (copy condition: \"changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR is:MIN\")\n","accounts_in_message":[],"_revision_number":2},{"id":"a8862197fe388f4f6a3456bd969249490ee90ed6","author":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"date":"2026-11-09 09:00:43.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"be8cf5f26cac534ddbca87fba9e82ac625309803","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2026-11-09 12:06:12.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"672f39fbd0a88ce0b387d581da22a7b5d30b91d1","revisions":{"8b7e241ff25b9ebe71c56cdf0a3b4d7424cf252b":{"kind":"REWORK","_number":1,"created":"2026-11-06 13:03:21.000000000","uploader":{"_account_id":1000008,"name":"Lev Stipakov","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"ref":"refs/changes/46/2146/1","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/46/2146/1","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/46/2146/1 \u0026\u0026 git checkout -b change-2146 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/46/2146/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/46/2146/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/46/2146/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/46/2146/1","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/46/2146/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"f1721dc7c1c0eb7e257ec557d86e7ec38599586a","subject":"crypto_epoch: wipe key material with secure_memzero()"}],"author":{"name":"Lev Stipakov","email":"lev@openvpn.net","date":"2026-11-06 10:33:36.000000000","tz":120},"committer":{"name":"Lev Stipakov","email":"lev@openvpn.net","date":"2026-11-06 12:59:48.000000000","tz":120},"subject":"reflect_filter: zero the rate limiter on allocation","message":"reflect_filter: zero the rate limiter on allocation\n\ninitial_rate_limit_init() allocates with ALLOC_OBJ, which does not\nclear, and then assigns every field but warning_displayed. That one is\nread on the path that warns about --connect-freq-initial being hit, so\nwhether the warning appears at all is down to whatever the heap handed\nus.\n\nUse ALLOC_OBJ_CLEAR, which is also what keeps a field added later from\nstarting out undefined.\n\nChange-Id: Ied9e36d45b30a88610cafee668ecefa98b29eddc\nSigned-off-by: Lev Stipakov \u003clev@openvpn.net\u003e\n"},"branch":"refs/heads/master"},"9067f9bb8aaf22415cd231537f59353095b8143b":{"kind":"REWORK","_number":2,"created":"2026-11-09 08:37:48.000000000","uploader":{"_account_id":1000008,"name":"Lev Stipakov","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"ref":"refs/changes/46/2146/2","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/46/2146/2","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/46/2146/2 \u0026\u0026 git checkout -b change-2146 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/46/2146/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/46/2146/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/46/2146/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/46/2146/2","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/46/2146/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"f1721dc7c1c0eb7e257ec557d86e7ec38599586a","subject":"crypto_epoch: wipe key material with secure_memzero()"}],"author":{"name":"Lev Stipakov","email":"lev@openvpn.net","date":"2026-11-06 10:33:36.000000000","tz":120},"committer":{"name":"Lev Stipakov","email":"lev@openvpn.net","date":"2026-11-09 08:18:34.000000000","tz":120},"subject":"reflect_filter: initialise warning_displayed in the rate limiter","message":"reflect_filter: initialise warning_displayed in the rate limiter\n\ninitial_rate_limit_init() allocates with ALLOC_OBJ, which does not\nclear, and assigns every field but warning_displayed. The first period\nreset assigns it before anything reads it, so nothing misbehaves today,\nbut there is no reason to leave a field undefined.\n\nChange-Id: Ied9e36d45b30a88610cafee668ecefa98b29eddc\nSigned-off-by: Lev Stipakov \u003clev@openvpn.net\u003e\n"},"branch":"refs/heads/master"},"672f39fbd0a88ce0b387d581da22a7b5d30b91d1":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":3,"created":"2026-11-09 12:06:12.000000000","uploader":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/46/2146/3","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/46/2146/3","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/46/2146/3 \u0026\u0026 git checkout -b change-2146 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/46/2146/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/46/2146/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/46/2146/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/46/2146/3","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/46/2146/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"990ade4504db620fa7dccb272635518eb4afa654","subject":"dco_linux: clear the context, not the pointer, in ovpn_dco_uninit_netlink()"}],"author":{"name":"Lev Stipakov","email":"lev@openvpn.net","date":"2026-11-09 09:11:32.000000000","tz":60},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2026-11-09 11:27:20.000000000","tz":60},"subject":"reflect_filter: initialise warning_displayed in the rate limiter","message":"reflect_filter: initialise warning_displayed in the rate limiter\n\ninitial_rate_limit_init() allocates with ALLOC_OBJ, which does not\nclear, and assigns every field but warning_displayed. The first period\nreset assigns it before anything reads it, so nothing misbehaves today,\nbut there is no reason to leave a field undefined.\n\nChange-Id: Ied9e36d45b30a88610cafee668ecefa98b29eddc\nSigned-off-by: Lev Stipakov \u003clev@openvpn.net\u003e\nAcked-by: Razvan Cojocaru \u003crazvanc@mailbox.org\u003e\nGerrit URL: https://gerrit.openvpn.net/c/openvpn/+/2146\nMessage-Id: \u003c20261109091139.4816-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg40963.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[]}