)]}'
{"id":"openvpn~2155","triplet_id":"openvpn~master~I603321ae6893dbdb054deae5a9bff5e52cbb7429","project":"openvpn","branch":"master","full_branch":"refs/heads/master","attention_set":{"1000068":{"account":{"_account_id":1000068,"name":"Alexandre Laroche","username":"AlexLaroche"},"last_update":"2026-11-09 12:53:38.000000000","reason":"\u003cGERRIT_ACCOUNT_1000053\u003e replied on the change","reason_account":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"}},"1000003":{"account":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2026-11-08 11:58:41.000000000","reason":"Reviewer was added"}},"removed_from_attention_set":{},"hashtags":[],"change_id":"I603321ae6893dbdb054deae5a9bff5e52cbb7429","subject":"Check the result of unchecked allocations in the server","status":"NEW","created":"2026-11-08 11:58:41.000000000","updated":"2026-11-09 13:03:10.000000000","submit_type":"CHERRY_PICK","total_comment_count":3,"unresolved_comment_count":3,"has_review_started":true,"meta_rev_id":"bb4da6c7ef9ca9c269f9d26e74ff88740030335f","_number":2155,"virtual_id_number":2155,"owner":{"_account_id":1000068,"name":"Alexandre Laroche","username":"AlexLaroche"},"actions":{},"labels":{"Code-Review":{"disliked":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"all":[{"value":-1,"date":"2026-11-09 12:53:38.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","value":-1,"default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-11-08 11:58:41.000000000","updated_by":{"_account_id":1000068,"name":"Alexandre Laroche","username":"AlexLaroche"},"real_updated_by":{"_account_id":1000068,"name":"Alexandre Laroche","username":"AlexLaroche"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2026-11-08 11:58:41.000000000","updated_by":{"_account_id":1000068,"name":"Alexandre Laroche","username":"AlexLaroche"},"real_updated_by":{"_account_id":1000068,"name":"Alexandre Laroche","username":"AlexLaroche"},"reviewer":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2026-11-09 12:53:38.000000000","updated_by":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"real_updated_by":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"reviewer":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"state":"REVIEWER"}],"messages":[{"id":"1de3aca2c830235ff453a6ff3e9282e1a90e5b82","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000068,"name":"Alexandre Laroche","username":"AlexLaroche"},"date":"2026-11-08 11:58:41.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"7cb10d7e570d1852b42f0facb130de7860bf07ff","author":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"date":"2026-11-09 12:53:38.000000000","message":"Patch Set 1: Code-Review-1\n\n(2 comments)","accounts_in_message":[],"_revision_number":1},{"id":"bb4da6c7ef9ca9c269f9d26e74ff88740030335f","author":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"date":"2026-11-09 13:03:10.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"3eba815527c82563ce47b123e60207b0a2b9aeef","revisions":{"3eba815527c82563ce47b123e60207b0a2b9aeef":{"kind":"REWORK","_number":1,"created":"2026-11-08 11:58:41.000000000","uploader":{"_account_id":1000068,"name":"Alexandre Laroche","username":"AlexLaroche"},"ref":"refs/changes/55/2155/1","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/55/2155/1","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/55/2155/1 \u0026\u0026 git checkout -b change-2155 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/55/2155/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/55/2155/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/55/2155/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/55/2155/1","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/55/2155/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"5b08a76c1a3215c9c927909e695ccd8e83eb6895","subject":"Make parameter openvpn_net_ctx_t const where possible"}],"author":{"name":"Alexandre Laroche","email":"larochealexandre@hotmail.com","date":"2026-11-08 11:58:34.000000000","tz":-300},"committer":{"name":"Alexandre Laroche","email":"larochealexandre@hotmail.com","date":"2026-11-08 11:58:38.000000000","tz":-300},"subject":"Check the result of unchecked allocations in the server","message":"Check the result of unchecked allocations in the server\n\nSeveral allocations were used without a NULL check, so a failed\nallocation crashed the server on a NULL pointer instead of stopping\nwith \"Out of Memory\" like the rest of the code:\n\n- multi_init(): calloc() of m-\u003einstances; the server started and then\n  crashed in multi_assign_peer_id() on the first client\n- generate_auth_token(), verify_user_pass(): strdup() of auth tokens;\n  generate_auth_token() then called strdup(NULL)\n- override_locked_username(): strdup() of the override username; the\n  strlcpy() from locked_username then crashed (with --auth-gen-token)\n- backend_x509_get_serial_hex(): malloc() of the serial buffer, which\n  BN_bn2binpad() then wrote to\n\nUse string_alloc(..., NULL) instead of strdup(), and add\ncheck_malloc_return() after the calloc() and malloc().\n\nGitHub: closes OpenVPN/openvpn#1142\n\nAssisted-by: Claude Code:claude-opus-5-5\nChange-Id: I603321ae6893dbdb054deae5a9bff5e52cbb7429\nSigned-off-by: Alexandre Laroche \u003clarochealexandre@hotmail.com\u003e\n"},"branch":"refs/heads/master"}},"requirements":[{"status":"NOT_READY","fallback_text":"All required checks must pass","type":"checks_pass"}],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"NOT_READY","labels":[{"label":"Code-Review","status":"NEED"}]},{"rule_name":"checks~ChecksSubmitRule","status":"NOT_READY","requirements":[{"status":"NOT_READY","fallback_text":"All required checks must pass","type":"checks_pass"}]}]}