)]}'
{"src/openvpn/crypto.c":[{"author":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"change_message_id":"8e9613afdc2023ce3249baae79682e2388208a16","unresolved":true,"context_lines":[{"line_number":855,"context_line":"crypto_max_overhead(void)"},{"line_number":856,"context_line":"{"},{"line_number":857,"context_line":"    return packet_id_size(true) + OPENVPN_MAX_IV_LENGTH + OPENVPN_MAX_CIPHER_BLOCK_SIZE"},{"line_number":858,"context_line":"           + max_uint(OPENVPN_MAX_HMAC_SIZE, OPENVPN_AEAD_TAG_LENGTH);"},{"line_number":859,"context_line":"}"},{"line_number":860,"context_line":""},{"line_number":861,"context_line":"static void"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"febc068d_0832a30c","line":858,"updated":"2026-11-10 11:41:06.000000000","message":"`packet_id_size(true)` returns `int`, so the sum still converts `int` to `unsigned int`.","commit_id":"f339a5edaaffaed82865b0ac2029c8e34a8655a6"},{"author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"689dc7a49ad34914a6c4dbba327bf2cc045d18fe","unresolved":true,"context_lines":[{"line_number":855,"context_line":"crypto_max_overhead(void)"},{"line_number":856,"context_line":"{"},{"line_number":857,"context_line":"    return packet_id_size(true) + OPENVPN_MAX_IV_LENGTH + OPENVPN_MAX_CIPHER_BLOCK_SIZE"},{"line_number":858,"context_line":"           + max_uint(OPENVPN_MAX_HMAC_SIZE, OPENVPN_AEAD_TAG_LENGTH);"},{"line_number":859,"context_line":"}"},{"line_number":860,"context_line":""},{"line_number":861,"context_line":"static void"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"84391446_ecd986b1","line":858,"in_reply_to":"febc068d_0832a30c","updated":"2026-11-10 12:25:57.000000000","message":"That part is in the next patch. The distribution into patches is sometimes a bit awkward, admittedly.","commit_id":"f339a5edaaffaed82865b0ac2029c8e34a8655a6"},{"author":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"change_message_id":"8e9613afdc2023ce3249baae79682e2388208a16","unresolved":true,"context_lines":[{"line_number":1550,"context_line":"        generate_key_random(\u0026key);"},{"line_number":1551,"context_line":""},{"line_number":1552,"context_line":"        /* format key as ascii */"},{"line_number":1553,"context_line":"        fmt \u003d format_hex_ex((const uint8_t *)\u0026key, sizeof(key), 0, bytes_per_line, \"\\n\", \u0026gc);"},{"line_number":1554,"context_line":""},{"line_number":1555,"context_line":"        /* write to holding buffer */"},{"line_number":1556,"context_line":"        buf_printf(\u0026out, \"%s\\n\", fmt);"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"f4abf554_392fb327","line":1553,"updated":"2026-11-10 11:41:06.000000000","message":"`crypto.c:1553:68: error: conversion from \u0027size_t\u0027 to \u0027unsigned int\u0027 may change value [-Werror\u003dconversion]`\n\n`const unsigned int bytes_per_line \u003d 16;` fixes it.","commit_id":"f339a5edaaffaed82865b0ac2029c8e34a8655a6"},{"author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"689dc7a49ad34914a6c4dbba327bf2cc045d18fe","unresolved":false,"context_lines":[{"line_number":1550,"context_line":"        generate_key_random(\u0026key);"},{"line_number":1551,"context_line":""},{"line_number":1552,"context_line":"        /* format key as ascii */"},{"line_number":1553,"context_line":"        fmt \u003d format_hex_ex((const uint8_t *)\u0026key, sizeof(key), 0, bytes_per_line, \"\\n\", \u0026gc);"},{"line_number":1554,"context_line":""},{"line_number":1555,"context_line":"        /* write to holding buffer */"},{"line_number":1556,"context_line":"        buf_printf(\u0026out, \"%s\\n\", fmt);"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"c1ef59ef_c4b97d88","line":1553,"in_reply_to":"f4abf554_392fb327","updated":"2026-11-10 12:25:57.000000000","message":"Done","commit_id":"f339a5edaaffaed82865b0ac2029c8e34a8655a6"}],"tests/unit_tests/openvpn/test_crypto.c":[{"author":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"change_message_id":"86785366165754878f3ae8538a57a2747cf43083","unresolved":true,"context_lines":[{"line_number":525,"context_line":"                        0xc1, 0x4c, 0x01, 0xd5, 0xc1, 0xf3, 0x43, 0x4f, 0x1d, 0x87 };"},{"line_number":526,"context_line":""},{"line_number":527,"context_line":"    uint8_t out[82] \u003d { 0xaa };"},{"line_number":528,"context_line":"    ovpn_hkdf_expand(prk, info, sizeof(info), out, L);"},{"line_number":529,"context_line":""},{"line_number":530,"context_line":"    assert_memory_equal(out, okm, L);"},{"line_number":531,"context_line":"}"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"6ea1b23f_be593c60","line":528,"updated":"2026-11-10 12:43:06.000000000","message":"`test_crypto.c:528:52: error: conversion to \u0027size_t\u0027 from \u0027int\u0027 may change the sign of the result [-Werror\u003dsign-conversion]`","commit_id":"94b2972fcbcc524c37769e2337e72a221255d075"},{"author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"c3c51f6877178d5916d28a6300c9023c210948e6","unresolved":false,"context_lines":[{"line_number":525,"context_line":"                        0xc1, 0x4c, 0x01, 0xd5, 0xc1, 0xf3, 0x43, 0x4f, 0x1d, 0x87 };"},{"line_number":526,"context_line":""},{"line_number":527,"context_line":"    uint8_t out[82] \u003d { 0xaa };"},{"line_number":528,"context_line":"    ovpn_hkdf_expand(prk, info, sizeof(info), out, L);"},{"line_number":529,"context_line":""},{"line_number":530,"context_line":"    assert_memory_equal(out, okm, L);"},{"line_number":531,"context_line":"}"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"725c6af9_641f4114","line":528,"in_reply_to":"6ea1b23f_be593c60","updated":"2026-11-10 14:13:43.000000000","message":"Done","commit_id":"94b2972fcbcc524c37769e2337e72a221255d075"},{"author":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"change_message_id":"86785366165754878f3ae8538a57a2747cf43083","unresolved":true,"context_lines":[{"line_number":527,"context_line":"    uint8_t out[82] \u003d { 0xaa };"},{"line_number":528,"context_line":"    ovpn_hkdf_expand(prk, info, sizeof(info), out, L);"},{"line_number":529,"context_line":""},{"line_number":530,"context_line":"    assert_memory_equal(out, okm, L);"},{"line_number":531,"context_line":"}"},{"line_number":532,"context_line":""},{"line_number":533,"context_line":"void"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"3c5b44a7_a19e88d3","line":530,"updated":"2026-11-10 12:43:06.000000000","message":"`test_crypto.c:530:35: error: conversion to \u0027size_t\u0027 from \u0027int\u0027 may change the sign of the result [-Werror\u003dsign-conversion]`","commit_id":"94b2972fcbcc524c37769e2337e72a221255d075"},{"author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"c3c51f6877178d5916d28a6300c9023c210948e6","unresolved":false,"context_lines":[{"line_number":527,"context_line":"    uint8_t out[82] \u003d { 0xaa };"},{"line_number":528,"context_line":"    ovpn_hkdf_expand(prk, info, sizeof(info), out, L);"},{"line_number":529,"context_line":""},{"line_number":530,"context_line":"    assert_memory_equal(out, okm, L);"},{"line_number":531,"context_line":"}"},{"line_number":532,"context_line":""},{"line_number":533,"context_line":"void"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"6c2575fc_b50af661","line":530,"in_reply_to":"3c5b44a7_a19e88d3","updated":"2026-11-10 14:13:43.000000000","message":"Done","commit_id":"94b2972fcbcc524c37769e2337e72a221255d075"}],"tests/unit_tests/openvpn/test_networking.c":[{"author":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"change_message_id":"86785366165754878f3ae8538a57a2747cf43083","unresolved":true,"context_lines":[{"line_number":43,"context_line":"static int"},{"line_number":44,"context_line":"net__iface_mtu_set(uint32_t mtu)"},{"line_number":45,"context_line":"{"},{"line_number":46,"context_line":"    printf(\"CMD: ip link set %s mtu %d\\n\", iface, mtu);"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    return net_iface_mtu_set(NULL, iface, mtu);"},{"line_number":49,"context_line":"}"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"3d3f1394_d5ed73d0","line":46,"updated":"2026-11-10 12:43:06.000000000","message":"`%u` now?","commit_id":"94b2972fcbcc524c37769e2337e72a221255d075"},{"author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"c3c51f6877178d5916d28a6300c9023c210948e6","unresolved":false,"context_lines":[{"line_number":43,"context_line":"static int"},{"line_number":44,"context_line":"net__iface_mtu_set(uint32_t mtu)"},{"line_number":45,"context_line":"{"},{"line_number":46,"context_line":"    printf(\"CMD: ip link set %s mtu %d\\n\", iface, mtu);"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    return net_iface_mtu_set(NULL, iface, mtu);"},{"line_number":49,"context_line":"}"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"0056c995_95fb14e7","line":46,"in_reply_to":"3d3f1394_d5ed73d0","updated":"2026-11-10 14:13:43.000000000","message":"Done","commit_id":"94b2972fcbcc524c37769e2337e72a221255d075"}]}