)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"change_message_id":"6d1ec62a74dc8f5b55ba581f67ad68545830afce","unresolved":true,"context_lines":[{"line_number":10,"context_line":"conversion by letting the compiler deduce the types of"},{"line_number":11,"context_line":"the literals."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"I do not think that using an intermediate variabl"},{"line_number":14,"context_line":"increases the readability."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I3bcb4cb8e17ff80a5cb8acdaf18d1072159184e5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fbe7339f_12d826a8","line":13,"updated":"2026-11-10 11:48:56.000000000","message":"Typo: \"variable\".","commit_id":"3f8d4f6fe041f8005cc926cd887cc0a2a6fe27c6"},{"author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"370598004cf2c50951a6bbfeed268716cc587dd0","unresolved":false,"context_lines":[{"line_number":10,"context_line":"conversion by letting the compiler deduce the types of"},{"line_number":11,"context_line":"the literals."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"I do not think that using an intermediate variabl"},{"line_number":14,"context_line":"increases the readability."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I3bcb4cb8e17ff80a5cb8acdaf18d1072159184e5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9cf83dae_30415119","line":13,"in_reply_to":"fbe7339f_12d826a8","updated":"2026-11-10 12:26:14.000000000","message":"Done","commit_id":"3f8d4f6fe041f8005cc926cd887cc0a2a6fe27c6"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"change_message_id":"bcfcc2bc021ba719195d394f49ad6cf5f863307e","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"91450d12_53010d3b","updated":"2026-11-10 14:33:40.000000000","message":"Changing `packet_id_size()` and `tls_crypt_buf_overhead()` to `unsigned int` adds warnings in callers that still use `int`:\n\n   - init.c:3150 (`int required_size \u003d 5 + wkc_len + tls_crypt_buf_overhead() + ...)`\n   - ssl.c:170 (`max_int(tls_crypt_buf_overhead(), packet_id_size(true) + ...)`, both arguments)\n   - ssl_pkt.c:70 (`const int hmac_size \u003d hmac_ctx_size(...) + packet_id_size(true)`)\n   \nThat may be intended, just making a note.","commit_id":"1227d6ee683501ec5609a510fed2ac855bffe802"},{"author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"0fd84c002c282aab3566260a9b37921ef50e1ec8","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"8bdc46fc_57184340","in_reply_to":"91450d12_53010d3b","updated":"2026-11-11 17:18:50.000000000","message":"Yeah, I\u0027m aware. I\u0027m trying to collect some changes for review while also not testing the whole code with -Wsign-conversion, yet. It is a trade-off.","commit_id":"1227d6ee683501ec5609a510fed2ac855bffe802"}],"src/openvpn/crypto.c":[{"author":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"change_message_id":"6d1ec62a74dc8f5b55ba581f67ad68545830afce","unresolved":true,"context_lines":[{"line_number":536,"context_line":"        }"},{"line_number":537,"context_line":"    }"},{"line_number":538,"context_line":""},{"line_number":539,"context_line":"    const uintptr_t ad_size \u003d (uintptr_t)(BPTR(buf) - ad_start);"},{"line_number":540,"context_line":""},{"line_number":541,"context_line":"    uint8_t *tag_ptr \u003d NULL;"},{"line_number":542,"context_line":"    int data_len \u003d 0;"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"e3080b51_2cd0ffb9","line":539,"updated":"2026-11-10 11:48:56.000000000","message":"`uintptr_t` doesn\u0027t sound like the right type to use here. My man page says: \"integer types wide enough to hold pointers\", but that\u0027s not what it is used for here.\n\n`size_t` would probably make more sense.","commit_id":"3f8d4f6fe041f8005cc926cd887cc0a2a6fe27c6"},{"author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"4f8f08ed0f6c2728457eab3fb96df1d7e32a70b7","unresolved":true,"context_lines":[{"line_number":536,"context_line":"        }"},{"line_number":537,"context_line":"    }"},{"line_number":538,"context_line":""},{"line_number":539,"context_line":"    const uintptr_t ad_size \u003d (uintptr_t)(BPTR(buf) - ad_start);"},{"line_number":540,"context_line":""},{"line_number":541,"context_line":"    uint8_t *tag_ptr \u003d NULL;"},{"line_number":542,"context_line":"    int data_len \u003d 0;"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"e8d213cc_27297988","line":539,"in_reply_to":"e3080b51_2cd0ffb9","updated":"2026-11-10 12:14:09.000000000","message":"But it is a difference between two pointers, so it feels appropriate to me?","commit_id":"3f8d4f6fe041f8005cc926cd887cc0a2a6fe27c6"},{"author":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"change_message_id":"00be5cc01984670e6c5b46af93bdc25aad38a179","unresolved":true,"context_lines":[{"line_number":536,"context_line":"        }"},{"line_number":537,"context_line":"    }"},{"line_number":538,"context_line":""},{"line_number":539,"context_line":"    const uintptr_t ad_size \u003d (uintptr_t)(BPTR(buf) - ad_start);"},{"line_number":540,"context_line":""},{"line_number":541,"context_line":"    uint8_t *tag_ptr \u003d NULL;"},{"line_number":542,"context_line":"    int data_len \u003d 0;"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"45fbdef0_3eaac5d1","line":539,"in_reply_to":"e8d213cc_27297988","updated":"2026-11-10 12:17:10.000000000","message":"You might be thinking of `ptrdiff_t`? Which I agree would be better than `uintptr_t`, but it\u0027s a signed type, which makes `size_t` better considering where it is being subsequently used.","commit_id":"3f8d4f6fe041f8005cc926cd887cc0a2a6fe27c6"}],"src/openvpn/crypto_epoch.c":[{"author":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"change_message_id":"bcfcc2bc021ba719195d394f49ad6cf5f863307e","unresolved":true,"context_lines":[{"line_number":41,"context_line":"#if defined(__GNUC__) || defined(__clang__)"},{"line_number":42,"context_line":"#pragma GCC diagnostic push"},{"line_number":43,"context_line":"#pragma GCC diagnostic ignored \"-Wsign-conversion\""},{"line_number":44,"context_line":"#endif"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"void"},{"line_number":47,"context_line":"ovpn_hkdf_expand(const uint8_t *secret, const uint8_t *info, size_t info_len,"}],"source_content_type":"text/x-csrc","patch_set":4,"id":"d6f0f0ec_1e2e0a38","line":44,"updated":"2026-11-10 14:33:40.000000000","message":"I think this pragma can no go away as well.","commit_id":"1227d6ee683501ec5609a510fed2ac855bffe802"},{"author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"a7fc4f044a5de3f5526176c9c2acac2ed218019a","unresolved":false,"context_lines":[{"line_number":41,"context_line":"#if defined(__GNUC__) || defined(__clang__)"},{"line_number":42,"context_line":"#pragma GCC diagnostic push"},{"line_number":43,"context_line":"#pragma GCC diagnostic ignored \"-Wsign-conversion\""},{"line_number":44,"context_line":"#endif"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"void"},{"line_number":47,"context_line":"ovpn_hkdf_expand(const uint8_t *secret, const uint8_t *info, size_t info_len,"}],"source_content_type":"text/x-csrc","patch_set":4,"id":"3458e29c_eef2e638","line":44,"in_reply_to":"d6f0f0ec_1e2e0a38","updated":"2026-11-11 17:15:54.000000000","message":"Done","commit_id":"1227d6ee683501ec5609a510fed2ac855bffe802"},{"author":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"change_message_id":"bcfcc2bc021ba719195d394f49ad6cf5f863307e","unresolved":true,"context_lines":[{"line_number":463,"context_line":""},{"line_number":464,"context_line":"#if defined(__GNUC__) || defined(__clang__)"},{"line_number":465,"context_line":"#pragma GCC diagnostic pop"},{"line_number":466,"context_line":"#endif"}],"source_content_type":"text/x-csrc","patch_set":4,"id":"4ee2f0d2_98829d0d","line":466,"updated":"2026-11-10 14:33:40.000000000","message":"This `pop` can now go away as well.","commit_id":"1227d6ee683501ec5609a510fed2ac855bffe802"},{"author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"a7fc4f044a5de3f5526176c9c2acac2ed218019a","unresolved":false,"context_lines":[{"line_number":463,"context_line":""},{"line_number":464,"context_line":"#if defined(__GNUC__) || defined(__clang__)"},{"line_number":465,"context_line":"#pragma GCC diagnostic pop"},{"line_number":466,"context_line":"#endif"}],"source_content_type":"text/x-csrc","patch_set":4,"id":"ba88f4be_3bb4af9b","line":466,"in_reply_to":"4ee2f0d2_98829d0d","updated":"2026-11-11 17:15:54.000000000","message":"Done","commit_id":"1227d6ee683501ec5609a510fed2ac855bffe802"}]}