)]}'
{"id":"openvpn~2158","triplet_id":"openvpn~master~I3bcb4cb8e17ff80a5cb8acdaf18d1072159184e5","project":"openvpn","branch":"master","full_branch":"refs/heads/master","topic":"wsign-conversion","attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2026-11-09 22:02:28.000000000","reason":"Reviewer was added"},"1000001":{"account":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2026-11-11 18:14:10.000000000","reason":"Someone else replied on the change"}},"removed_from_attention_set":{"1000053":{"account":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"last_update":"2026-11-11 18:14:10.000000000","reason":"removed on reply"}},"hashtags":[],"change_id":"I3bcb4cb8e17ff80a5cb8acdaf18d1072159184e5","subject":"crypto*: Avoid sign conversion warnings by using defines directly","status":"NEW","created":"2026-11-09 22:02:27.000000000","updated":"2026-11-12 17:11:31.000000000","submit_type":"CHERRY_PICK","total_comment_count":11,"unresolved_comment_count":2,"has_review_started":true,"meta_rev_id":"c9e47cd8bef6b7424b8a51762e2fea7aadab32e8","_number":2158,"virtual_id_number":2158,"owner":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"actions":{},"labels":{"Code-Review":{"approved":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"all":[{"value":2,"date":"2026-11-12 17:11:31.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-11-09 22:02:28.000000000","updated_by":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"real_updated_by":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2026-11-09 22:02:28.000000000","updated_by":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"real_updated_by":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2026-11-10 11:48:56.000000000","updated_by":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"real_updated_by":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"reviewer":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"state":"REVIEWER"}],"messages":[{"id":"26d835b6a22eb50c5abb4c68ba389d7e0c823058","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-11-09 22:02:27.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"8db007f58afb14eeaa1323e072987d235e19af16","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-11-10 11:24:20.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased. Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"6d1ec62a74dc8f5b55ba581f67ad68545830afce","author":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"date":"2026-11-10 11:48:56.000000000","message":"Patch Set 2: Code-Review-1\n\n(2 comments)","accounts_in_message":[],"_revision_number":2},{"id":"4f8f08ed0f6c2728457eab3fb96df1d7e32a70b7","author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-11-10 12:14:09.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"00be5cc01984670e6c5b46af93bdc25aad38a179","author":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"date":"2026-11-10 12:17:10.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"4cf6934ea361e378f2647d3311bd014c0c226ea2","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-11-10 12:25:46.000000000","message":"Uploaded patch set 3.\n\nOutdated Votes:\n* Code-Review-1 (copy condition: \"changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR is:MIN\")\n","accounts_in_message":[],"_revision_number":3},{"id":"370598004cf2c50951a6bbfeed268716cc587dd0","author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-11-10 12:26:14.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"4addcf06fc0b27a521e0c6bfe516b3e3bff73487","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-11-10 14:13:23.000000000","message":"Uploaded patch set 4: Patch Set 3 was rebased.","accounts_in_message":[],"_revision_number":4},{"id":"bcfcc2bc021ba719195d394f49ad6cf5f863307e","author":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"date":"2026-11-10 14:33:40.000000000","message":"Patch Set 4: Code-Review-1\n\n(3 comments)","accounts_in_message":[],"_revision_number":4},{"id":"be023d9c38642d3ef17fc28b64cae17558a03c5b","tag":"autogenerated:gerrit:setTopic","author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-11-10 14:36:45.000000000","message":"Topic set to wsign-conversion","accounts_in_message":[],"_revision_number":4},{"id":"2767da14cbc78b971a6ba941fbcc26ba3ec67c74","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-11-11 17:15:22.000000000","message":"Uploaded patch set 5.\n\nOutdated Votes:\n* Code-Review-1 (copy condition: \"changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR is:MIN\")\n","accounts_in_message":[],"_revision_number":5},{"id":"a7fc4f044a5de3f5526176c9c2acac2ed218019a","author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-11-11 17:15:54.000000000","message":"Patch Set 5:\n\n(2 comments)","accounts_in_message":[],"_revision_number":5},{"id":"0fd84c002c282aab3566260a9b37921ef50e1ec8","author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-11-11 17:18:50.000000000","message":"Patch Set 5:\n\n(1 comment)","accounts_in_message":[],"_revision_number":5},{"id":"8c6865c3551c4ecf41c1472bc1f9e4a75ee35b75","author":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"date":"2026-11-11 18:14:10.000000000","message":"Patch Set 5: Code-Review+2","accounts_in_message":[],"_revision_number":5},{"id":"c9e47cd8bef6b7424b8a51762e2fea7aadab32e8","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-11-12 17:11:31.000000000","message":"Uploaded patch set 6: Patch Set 5 was rebased.\n\nCopied Votes:\n* Code-Review+2 (copy condition: \"changekind:NO_CHANGE OR **changekind:TRIVIAL_REBASE** OR is:MIN\")\n","accounts_in_message":[],"_revision_number":6}],"current_revision_number":6,"current_revision":"3052fe05d7f2ff97b885b64731b76453c4e29caa","revisions":{"b97583191ad0e275731f5f2e45b70e719a68f8d6":{"kind":"REWORK","_number":1,"created":"2026-11-09 22:02:27.000000000","uploader":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/58/2158/1","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/58/2158/1","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/58/2158/1 \u0026\u0026 git checkout -b change-2158 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/58/2158/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/58/2158/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/58/2158/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/58/2158/1","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/58/2158/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"29bfe04c375fa07c0ce3ac3284b7ae4695b47b50","subject":"Various trivial -Wsign-conversion fixes"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-11-09 21:57:09.000000000","tz":60},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-11-09 22:02:06.000000000","tz":60},"subject":"crypto*: Avoid sign conversion warnings by using defines directly","message":"crypto*: Avoid sign conversion warnings by using defines directly\n\nUsing the defines directly avoids the issue with sign\nconversion by letting the compiler deduce the types of\nthe literals.\n\nChange-Id: I3bcb4cb8e17ff80a5cb8acdaf18d1072159184e5\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"3f8d4f6fe041f8005cc926cd887cc0a2a6fe27c6":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":2,"created":"2026-11-10 11:24:20.000000000","uploader":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/58/2158/2","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/58/2158/2","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/58/2158/2 \u0026\u0026 git checkout -b change-2158 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/58/2158/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/58/2158/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/58/2158/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/58/2158/2","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/58/2158/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"f339a5edaaffaed82865b0ac2029c8e34a8655a6","subject":"Various trivial -Wsign-conversion fixes"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-11-09 21:57:09.000000000","tz":60},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-11-10 11:22:09.000000000","tz":60},"subject":"crypto*: Avoid sign conversion warnings by using defines directly","message":"crypto*: Avoid sign conversion warnings by using defines directly\n\nUsing the defines directly avoids the issue with sign\nconversion by letting the compiler deduce the types of\nthe literals.\n\nI do not think that using an intermediate variabl\nincreases the readability.\n\nChange-Id: I3bcb4cb8e17ff80a5cb8acdaf18d1072159184e5\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"b1d16692afbcdf6728ef30b156274f378696b554":{"kind":"REWORK","_number":3,"created":"2026-11-10 12:25:46.000000000","uploader":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/58/2158/3","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/58/2158/3","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/58/2158/3 \u0026\u0026 git checkout -b change-2158 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/58/2158/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/58/2158/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/58/2158/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/58/2158/3","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/58/2158/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"94b2972fcbcc524c37769e2337e72a221255d075","subject":"Various trivial -Wsign-conversion fixes"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-11-09 21:57:09.000000000","tz":60},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-11-10 12:22:39.000000000","tz":60},"subject":"crypto*: Avoid sign conversion warnings by using defines directly","message":"crypto*: Avoid sign conversion warnings by using defines directly\n\nUsing the defines directly avoids the issue with sign\nconversion by letting the compiler deduce the types of\nthe literals.\n\nI do not think that using an intermediate variable\nincreases the readability.\n\nChange-Id: I3bcb4cb8e17ff80a5cb8acdaf18d1072159184e5\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"1227d6ee683501ec5609a510fed2ac855bffe802":{"kind":"TRIVIAL_REBASE","_number":4,"created":"2026-11-10 14:13:23.000000000","uploader":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/58/2158/4","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/58/2158/4","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/58/2158/4 \u0026\u0026 git checkout -b change-2158 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/58/2158/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/58/2158/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/58/2158/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/58/2158/4","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/58/2158/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"b4ea722bae1c48a481b79713c37a670264e4c61c","subject":"Various trivial -Wsign-conversion fixes"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-11-09 21:57:09.000000000","tz":60},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-11-10 14:11:37.000000000","tz":60},"subject":"crypto*: Avoid sign conversion warnings by using defines directly","message":"crypto*: Avoid sign conversion warnings by using defines directly\n\nUsing the defines directly avoids the issue with sign\nconversion by letting the compiler deduce the types of\nthe literals.\n\nI do not think that using an intermediate variable\nincreases the readability.\n\nChange-Id: I3bcb4cb8e17ff80a5cb8acdaf18d1072159184e5\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"19f2ddf9de29e73f657ea877c51e3418c71ff33d":{"kind":"REWORK","_number":5,"created":"2026-11-11 17:15:22.000000000","uploader":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/58/2158/5","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/58/2158/5","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/58/2158/5 \u0026\u0026 git checkout -b change-2158 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/58/2158/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/58/2158/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/58/2158/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/58/2158/5","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/58/2158/5 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"b4ea722bae1c48a481b79713c37a670264e4c61c","subject":"Various trivial -Wsign-conversion fixes"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-11-09 21:57:09.000000000","tz":60},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-11-11 17:15:08.000000000","tz":60},"subject":"crypto*: Avoid sign conversion warnings by using defines directly","message":"crypto*: Avoid sign conversion warnings by using defines directly\n\nUsing the defines directly avoids the issue with sign\nconversion by letting the compiler deduce the types of\nthe literals.\n\nI do not think that using an intermediate variable\nincreases the readability.\n\nChange-Id: I3bcb4cb8e17ff80a5cb8acdaf18d1072159184e5\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"3052fe05d7f2ff97b885b64731b76453c4e29caa":{"kind":"TRIVIAL_REBASE","_number":6,"created":"2026-11-12 17:11:31.000000000","uploader":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/58/2158/6","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/58/2158/6","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/58/2158/6 \u0026\u0026 git checkout -b change-2158 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/58/2158/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/58/2158/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/58/2158/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/58/2158/6","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/58/2158/6 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"ee2457d7ba689b5be0ecbf1dbc67e72047e21628","subject":"Various trivial -Wsign-conversion fixes"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-11-09 21:57:09.000000000","tz":60},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-11-12 16:40:49.000000000","tz":60},"subject":"crypto*: Avoid sign conversion warnings by using defines directly","message":"crypto*: Avoid sign conversion warnings by using defines directly\n\nUsing the defines directly avoids the issue with sign\nconversion by letting the compiler deduce the types of\nthe literals.\n\nI do not think that using an intermediate variable\nincreases the readability.\n\nChange-Id: I3bcb4cb8e17ff80a5cb8acdaf18d1072159184e5\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"OK","labels":[{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"}}]},{"rule_name":"checks~ChecksSubmitRule","status":"OK"}]}