)]}'
{"id":"openvpn~2159","triplet_id":"openvpn~master~I57469ca50c551ad475510690ecfa2d5e7cf9cfcf","project":"openvpn","branch":"master","full_branch":"refs/heads/master","attention_set":{"1000007":{"account":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"last_update":"2026-11-12 08:26:27.000000000","reason":"Vote got outdated and was removed: Code-Review+2"},"1000053":{"account":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"last_update":"2026-11-12 20:04:38.000000000","reason":"Someone else replied on the change"},"1000003":{"account":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2026-11-10 08:52:52.000000000","reason":"Reviewer was added"}},"removed_from_attention_set":{"1000006":{"account":{"_account_id":1000006,"name":"Heiko Hund","display_name":"Heiko Hund","email":"heiko@ist.eigentlich.net","username":"d12fk"},"last_update":"2026-11-12 20:04:38.000000000","reason":"removed on reply"}},"hashtags":[],"change_id":"I57469ca50c551ad475510690ecfa2d5e7cf9cfcf","subject":"openvpnserv: reject a config file passed without --config","status":"NEW","created":"2026-11-10 08:52:52.000000000","updated":"2026-11-12 20:04:38.000000000","submit_type":"CHERRY_PICK","total_comment_count":12,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"cded6e5062972072374a246f075fe8378a5311ec","_number":2159,"virtual_id_number":2159,"owner":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"actions":{},"labels":{"Code-Review":{"approved":{"_account_id":1000006,"name":"Heiko Hund","display_name":"Heiko Hund","email":"heiko@ist.eigentlich.net","username":"d12fk"},"all":[{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},{"value":2,"date":"2026-11-12 20:04:38.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":1000006,"name":"Heiko Hund","display_name":"Heiko Hund","email":"heiko@ist.eigentlich.net","username":"d12fk"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"_account_id":1000006,"name":"Heiko Hund","display_name":"Heiko Hund","email":"heiko@ist.eigentlich.net","username":"d12fk"},{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-11-10 08:52:52.000000000","updated_by":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"real_updated_by":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2026-11-10 08:52:52.000000000","updated_by":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"real_updated_by":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"reviewer":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2026-11-11 10:03:04.000000000","updated_by":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"real_updated_by":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"reviewer":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"state":"CC"},{"updated":"2026-11-11 10:08:37.000000000","updated_by":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"real_updated_by":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"reviewer":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"state":"REVIEWER"},{"updated":"2026-11-12 04:27:52.000000000","updated_by":{"_account_id":1000006,"name":"Heiko Hund","display_name":"Heiko Hund","email":"heiko@ist.eigentlich.net","username":"d12fk"},"real_updated_by":{"_account_id":1000006,"name":"Heiko Hund","display_name":"Heiko Hund","email":"heiko@ist.eigentlich.net","username":"d12fk"},"reviewer":{"_account_id":1000006,"name":"Heiko Hund","display_name":"Heiko Hund","email":"heiko@ist.eigentlich.net","username":"d12fk"},"state":"CC"},{"updated":"2026-11-12 18:02:57.000000000","updated_by":{"_account_id":1000006,"name":"Heiko Hund","display_name":"Heiko Hund","email":"heiko@ist.eigentlich.net","username":"d12fk"},"real_updated_by":{"_account_id":1000006,"name":"Heiko Hund","display_name":"Heiko Hund","email":"heiko@ist.eigentlich.net","username":"d12fk"},"reviewer":{"_account_id":1000006,"name":"Heiko Hund","display_name":"Heiko Hund","email":"heiko@ist.eigentlich.net","username":"d12fk"},"state":"REVIEWER"}],"messages":[{"id":"efc76b5404eda56cf2434f86cfb51524f8d3f68e","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"date":"2026-11-10 08:52:52.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"64136cb33cb7b8ee1c3dc13ba64f848e565ea1bc","author":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"date":"2026-11-11 10:03:04.000000000","message":"Patch Set 1:\n\n(2 comments)","accounts_in_message":[],"_revision_number":1},{"id":"064e4ca0efc3246101aa7d64865999d10f4486fb","author":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"date":"2026-11-11 10:08:37.000000000","message":"Patch Set 1: Code-Review-1","accounts_in_message":[],"_revision_number":1},{"id":"2e5d63e47f4efe5b41b8f9a1635b2309db560f04","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"date":"2026-11-11 10:44:58.000000000","message":"Uploaded patch set 2.\n\nOutdated Votes:\n* Code-Review-1 (copy condition: \"changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR is:MIN\")\n","accounts_in_message":[],"_revision_number":2},{"id":"50b4a3792cf9246b74ece266a654cb521425f09a","author":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"date":"2026-11-11 10:45:41.000000000","message":"Patch Set 2:\n\n(3 comments)","accounts_in_message":[],"_revision_number":2},{"id":"eeea3915be08c34576ddc00a5b134324f6fcc75e","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"date":"2026-11-11 11:03:08.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"cbdb2f8d1ee1c1954566ec53d766f2451b0ba1b7","author":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"date":"2026-11-11 11:03:48.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"4066a1e2a304efcf9c080f6fb277661863c4283b","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"date":"2026-11-11 11:08:46.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"f25a2b927bab82073d1d4cfac6853b1180e07b57","author":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"date":"2026-11-11 11:20:20.000000000","message":"Patch Set 4: Code-Review+2","accounts_in_message":[],"_revision_number":4},{"id":"894c923d3d06741edcf47e309f47bdaec5d040d8","author":{"_account_id":1000006,"name":"Heiko Hund","display_name":"Heiko Hund","email":"heiko@ist.eigentlich.net","username":"d12fk"},"date":"2026-11-12 04:27:52.000000000","message":"Patch Set 4:\n\n(1 comment)","accounts_in_message":[],"_revision_number":4},{"id":"116f238e08a75ef743bae761da2f5320b9407d94","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"date":"2026-11-12 08:26:27.000000000","message":"Uploaded patch set 5.\n\nOutdated Votes:\n* Code-Review+2 (copy condition: \"changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR is:MIN\")\n","accounts_in_message":[],"_revision_number":5},{"id":"3656dfaae01dec84a535ec92c16a31f182f3af04","author":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"date":"2026-11-12 08:27:30.000000000","message":"Patch Set 5:\n\n(1 comment)","accounts_in_message":[],"_revision_number":5},{"id":"30d90d02fc66993f9498f04c818dc97b40a73ac4","author":{"_account_id":1000006,"name":"Heiko Hund","display_name":"Heiko Hund","email":"heiko@ist.eigentlich.net","username":"d12fk"},"date":"2026-11-12 17:54:09.000000000","message":"Patch Set 5:\n\n(1 comment)","accounts_in_message":[],"_revision_number":5},{"id":"f17d9d7d899f8f15cfb5ecca4155693cacb66ee5","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"date":"2026-11-12 18:01:08.000000000","message":"Uploaded patch set 6.","accounts_in_message":[],"_revision_number":6},{"id":"f7e1a8c0d331c33471fdbfdd63dada0cff9151e4","author":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"date":"2026-11-12 18:02:04.000000000","message":"Patch Set 6:\n\n(1 comment)","accounts_in_message":[],"_revision_number":6},{"id":"6b2c839363725b75cacb5c185e6ec9e776168da3","author":{"_account_id":1000006,"name":"Heiko Hund","display_name":"Heiko Hund","email":"heiko@ist.eigentlich.net","username":"d12fk"},"date":"2026-11-12 18:02:57.000000000","message":"Patch Set 6: Code-Review+2","accounts_in_message":[],"_revision_number":6},{"id":"0414108db462654d04189be602cee749c0d6d0ee","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"date":"2026-11-12 19:42:29.000000000","message":"Uploaded patch set 7.\n\nOutdated Votes:\n* Code-Review+2 (copy condition: \"changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR is:MIN\")\n","accounts_in_message":[],"_revision_number":7},{"id":"e03264980efcc25bc16dd1a91c5132b9978c058c","author":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"date":"2026-11-12 20:04:17.000000000","message":"Patch Set 7:\n\n(1 comment)","accounts_in_message":[],"_revision_number":7},{"id":"cded6e5062972072374a246f075fe8378a5311ec","author":{"_account_id":1000006,"name":"Heiko Hund","display_name":"Heiko Hund","email":"heiko@ist.eigentlich.net","username":"d12fk"},"date":"2026-11-12 20:04:38.000000000","message":"Patch Set 7: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":7}],"current_revision_number":7,"current_revision":"e4663828f40e1184bff8ec0801bc7f1b2ae3cf28","revisions":{"3ac6ba619e4e2bebdc5f54b0e80b79f0dcdf225a":{"kind":"REWORK","_number":1,"created":"2026-11-10 08:52:52.000000000","uploader":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"ref":"refs/changes/59/2159/1","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/59/2159/1","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/59/2159/1 \u0026\u0026 git checkout -b change-2159 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/59/2159/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/59/2159/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/59/2159/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/59/2159/1","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/59/2159/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"83c988d49fddc7e0ad9c40741ab6f391f236ed45","subject":"Remove unused gc_arena variables"}],"author":{"name":"Razvan Cojocaru","email":"razvanc@mailbox.org","date":"2026-11-10 08:49:30.000000000","tz":120},"committer":{"name":"Razvan Cojocaru","email":"razvanc@mailbox.org","date":"2026-11-10 08:49:30.000000000","tz":120},"subject":"openvpnserv: accept a lone config file that passes validation","message":"openvpnserv: accept a lone config file that passes validation\n\nWhen the only option is a config file, ValidateOptions() checked it\nwith CheckOption() but returned FALSE even when the check passed. The\nservice then fell back to IsAuthorizedUser(), so users outside the\nadmin group could not start a config from the global config directory,\nand got an empty error message.\n\nBroken since f3c8a04d (\"Restrict options/configs for startup through\ninteractive service\").\n\nChange-Id: I57469ca50c551ad475510690ecfa2d5e7cf9cfcf\nSigned-off-by: Razvan Cojocaru \u003crazvanc@mailbox.org\u003e\n"},"branch":"refs/heads/master"},"f4af39057c64d44f868638c8bf1f5614b184bbd2":{"kind":"REWORK","_number":2,"created":"2026-11-11 10:44:58.000000000","uploader":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"ref":"refs/changes/59/2159/2","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/59/2159/2","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/59/2159/2 \u0026\u0026 git checkout -b change-2159 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/59/2159/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/59/2159/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/59/2159/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/59/2159/2","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/59/2159/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"83c988d49fddc7e0ad9c40741ab6f391f236ed45","subject":"Remove unused gc_arena variables"}],"author":{"name":"Razvan Cojocaru","email":"razvanc@mailbox.org","date":"2026-11-10 08:49:30.000000000","tz":120},"committer":{"name":"Razvan Cojocaru","email":"razvanc@mailbox.org","date":"2026-11-11 10:35:24.000000000","tz":120},"subject":"openvpnserv: pass a lone config file to openvpn with --config","message":"openvpnserv: pass a lone config file to openvpn with --config\n\nopenvpn.exe takes a lone argument as the config file only when there\nare no other arguments, but the service adds --msg-channel. Before\nc139e82d openvpn.exe rejected the config file for lacking a leading\n\"--\", since then it takes it as an extra parameter of --msg-channel and\nignores it. ValidateOptions() treated it as the config file, but only\never returned FALSE for it.\n\nPut --config in front of a lone non-option when building the command\nline, so that ValidateOptions() checks what openvpn.exe gets, and drop\nits special case for a lone argument.\n\nChange-Id: I57469ca50c551ad475510690ecfa2d5e7cf9cfcf\nSigned-off-by: Razvan Cojocaru \u003crazvanc@mailbox.org\u003e\n"},"branch":"refs/heads/master"},"cfcfa546220d8c080dd4b07f6cd326808e2ae37b":{"kind":"REWORK","_number":3,"created":"2026-11-11 11:03:08.000000000","uploader":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"ref":"refs/changes/59/2159/3","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/59/2159/3","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/59/2159/3 \u0026\u0026 git checkout -b change-2159 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/59/2159/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/59/2159/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/59/2159/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/59/2159/3","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/59/2159/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"83c988d49fddc7e0ad9c40741ab6f391f236ed45","subject":"Remove unused gc_arena variables"}],"author":{"name":"Razvan Cojocaru","email":"razvanc@mailbox.org","date":"2026-11-10 08:49:30.000000000","tz":120},"committer":{"name":"Razvan Cojocaru","email":"razvanc@mailbox.org","date":"2026-11-11 11:02:34.000000000","tz":120},"subject":"openvpnserv: pass a lone config file to openvpn with --config","message":"openvpnserv: pass a lone config file to openvpn with --config\n\nopenvpn.exe takes a lone argument as the config file only when there\nare no other arguments, but the service adds --msg-channel. Before\nc139e82d openvpn.exe rejected the config file for lacking a leading\n\"--\", since then it takes it as an extra parameter of --msg-channel and\nignores it. ValidateOptions() treated it as the config file, but only\never returned FALSE for it.\n\nPut --config in front of a lone non-option when building the command\nline, so that ValidateOptions() checks what openvpn.exe gets, and drop\nits special case for a lone argument.\n\nChange-Id: I57469ca50c551ad475510690ecfa2d5e7cf9cfcf\nSigned-off-by: Razvan Cojocaru \u003crazvanc@mailbox.org\u003e\n"},"branch":"refs/heads/master"},"5d019414bc457a8c6d3e9d4bffeb2fe456a44ec0":{"kind":"REWORK","_number":4,"created":"2026-11-11 11:08:46.000000000","uploader":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"ref":"refs/changes/59/2159/4","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/59/2159/4","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/59/2159/4 \u0026\u0026 git checkout -b change-2159 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/59/2159/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/59/2159/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/59/2159/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/59/2159/4","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/59/2159/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"83c988d49fddc7e0ad9c40741ab6f391f236ed45","subject":"Remove unused gc_arena variables"}],"author":{"name":"Razvan Cojocaru","email":"razvanc@mailbox.org","date":"2026-11-10 08:49:30.000000000","tz":120},"committer":{"name":"Razvan Cojocaru","email":"razvanc@mailbox.org","date":"2026-11-11 11:08:44.000000000","tz":120},"subject":"openvpnserv: pass a lone config file to openvpn with --config","message":"openvpnserv: pass a lone config file to openvpn with --config\n\nopenvpn.exe takes a lone argument as the config file only when there\nare no other arguments, but the service adds --msg-channel. Before\nc139e82d openvpn.exe rejected the config file for lacking a leading\n\"--\", since then it takes it as an extra parameter of --msg-channel and\nignores it. ValidateOptions() treated it as the config file, but only\never returned FALSE for it.\n\nPut --config in front of a lone non-option when building the command\nline, so that ValidateOptions() checks what openvpn.exe gets, and drop\nits special case for a lone argument.\n\nChange-Id: I57469ca50c551ad475510690ecfa2d5e7cf9cfcf\nSigned-off-by: Razvan Cojocaru \u003crazvanc@mailbox.org\u003e\n"},"branch":"refs/heads/master"},"840b0bd7cbeb34ecb479f1d12302b8c037337bb0":{"kind":"REWORK","_number":5,"created":"2026-11-12 08:26:27.000000000","uploader":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"ref":"refs/changes/59/2159/5","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/59/2159/5","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/59/2159/5 \u0026\u0026 git checkout -b change-2159 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/59/2159/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/59/2159/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/59/2159/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/59/2159/5","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/59/2159/5 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"83c988d49fddc7e0ad9c40741ab6f391f236ed45","subject":"Remove unused gc_arena variables"}],"author":{"name":"Razvan Cojocaru","email":"razvanc@mailbox.org","date":"2026-11-10 08:49:30.000000000","tz":120},"committer":{"name":"Razvan Cojocaru","email":"razvanc@mailbox.org","date":"2026-11-12 08:25:42.000000000","tz":120},"subject":"openvpnserv: reject a config file passed without --config","message":"openvpnserv: reject a config file passed without --config\n\nopenvpn.exe takes a lone argument as the config file only when there\nare no other arguments, but the service adds --msg-channel. Since\nc139e82d openvpn.exe takes the config file as an extra parameter of\n--msg-channel and ignores it. ValidateOptions() treated it as the\nconfig file, but only ever returned FALSE for it, with an empty error\nmessage if the path was fine.\n\nReturn an error to all users when the options don\u0027t start with an\noption, and drop the lone argument special case in ValidateOptions(),\nso that a lone option is checked against the white list.\n\nChange-Id: I57469ca50c551ad475510690ecfa2d5e7cf9cfcf\nSigned-off-by: Razvan Cojocaru \u003crazvanc@mailbox.org\u003e\n"},"branch":"refs/heads/master"},"a8daf527aea3e6b2ba8405f3fd2fb14b961414a8":{"kind":"REWORK","_number":6,"created":"2026-11-12 18:01:08.000000000","uploader":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"ref":"refs/changes/59/2159/6","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/59/2159/6","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/59/2159/6 \u0026\u0026 git checkout -b change-2159 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/59/2159/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/59/2159/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/59/2159/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/59/2159/6","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/59/2159/6 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"83c988d49fddc7e0ad9c40741ab6f391f236ed45","subject":"Remove unused gc_arena variables"}],"author":{"name":"Razvan Cojocaru","email":"razvanc@mailbox.org","date":"2026-11-10 08:49:30.000000000","tz":120},"committer":{"name":"Razvan Cojocaru","email":"razvanc@mailbox.org","date":"2026-11-12 17:59:06.000000000","tz":120},"subject":"openvpnserv: reject a config file passed without --config","message":"openvpnserv: reject a config file passed without --config\n\nopenvpn.exe takes a lone argument as the config file only when there\nare no other arguments, but the service adds --msg-channel. Since\nc139e82d openvpn.exe takes the config file as an extra parameter of\n--msg-channel and ignores it. ValidateOptions() treated it as the\nconfig file, but only ever returned FALSE for it, with an empty error\nmessage if the path was fine.\n\nReturn an error to all users when the options don\u0027t start with an\noption, and drop the lone argument special case in ValidateOptions(),\nso that a lone option is checked against the white list.\n\nChange-Id: I57469ca50c551ad475510690ecfa2d5e7cf9cfcf\nSigned-off-by: Razvan Cojocaru \u003crazvanc@mailbox.org\u003e\n"},"branch":"refs/heads/master"},"e4663828f40e1184bff8ec0801bc7f1b2ae3cf28":{"kind":"REWORK","_number":7,"created":"2026-11-12 19:42:29.000000000","uploader":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"ref":"refs/changes/59/2159/7","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/59/2159/7","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/59/2159/7 \u0026\u0026 git checkout -b change-2159 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/59/2159/7 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/59/2159/7 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/59/2159/7 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/59/2159/7","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/59/2159/7 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"83c988d49fddc7e0ad9c40741ab6f391f236ed45","subject":"Remove unused gc_arena variables"}],"author":{"name":"Razvan Cojocaru","email":"razvanc@mailbox.org","date":"2026-11-10 08:49:30.000000000","tz":120},"committer":{"name":"Razvan Cojocaru","email":"razvanc@mailbox.org","date":"2026-11-12 19:42:13.000000000","tz":120},"subject":"openvpnserv: reject a config file passed without --config","message":"openvpnserv: reject a config file passed without --config\n\nopenvpn.exe takes a lone argument as the config file only when there\nare no other arguments, but the service adds --msg-channel. Since\nc139e82d openvpn.exe takes the config file as an extra parameter of\n--msg-channel and ignores it. ValidateOptions() treated it as the\nconfig file, but only ever returned FALSE for it, with an empty error\nmessage if the path was fine.\n\nReturn an error to all users when the options don\u0027t start with an\noption, and drop the lone argument special case in ValidateOptions(),\nso that a lone option is checked against the white list.\n\nChange-Id: I57469ca50c551ad475510690ecfa2d5e7cf9cfcf\nSigned-off-by: Razvan Cojocaru \u003crazvanc@mailbox.org\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"OK","labels":[{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000006,"name":"Heiko Hund","display_name":"Heiko Hund","email":"heiko@ist.eigentlich.net","username":"d12fk"}}]},{"rule_name":"checks~ChecksSubmitRule","status":"OK"}]}