)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"change_message_id":"8a13a39532905724cc273e4bf8a1c2643022ecef","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"192ae6ac_e0c5da88","updated":"2026-11-11 09:58:28.000000000","message":"I have a suggestion below in the code. However, the patch is also fine this way, so it gets my +2.\nI leave to Razvan the decision.","commit_id":"092ca65bdb0605e88656d822621a8ceb3b5eb15d"},{"author":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"change_message_id":"a4c8762b57502efb8187af8a01e2fdc1db4ea1a4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"3a476a16_d3452589","updated":"2026-11-11 10:34:49.000000000","message":"thanks!","commit_id":"193f1deedeb81851852f64a578c1e8518fd05343"}],"src/openvpnserv/interactive.c":[{"author":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"change_message_id":"8a13a39532905724cc273e4bf8a1c2643022ecef","unresolved":true,"context_lines":[{"line_number":1823,"context_line":"        strncpy_s(undo_data-\u003eitf_name, sizeof(undo_data-\u003eitf_name), itf_name, _TRUNCATE);"},{"line_number":1824,"context_line":"        undo_data-\u003edomains \u003d wide_domains;"},{"line_number":1825,"context_line":""},{"line_number":1826,"context_line":"        const BOOL added \u003d AddDnsSearchDomains(list_key, have_list, wide_domains);"},{"line_number":1827,"context_line":"        if (!added || AddListItem(\u0026(*lists)[undo_domains], undo_data) !\u003d NO_ERROR)"},{"line_number":1828,"context_line":"        {"},{"line_number":1829,"context_line":"            if (added)"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"86815028_6d75c77a","line":1826,"updated":"2026-11-11 09:58:28.000000000","message":"wouldn\u0027t be cleaner (and safer, so we don\u0027t risk re-introducing similar bugs) to take the same approach as done below around line 3020?\nThere we first add the item to the list and only then we touch the registry.\nIf AddListItem() fails, we don\u0027t need to roll back anything.\n\nDoes it make sense? This way we also re-use the same coding pattern.","commit_id":"092ca65bdb0605e88656d822621a8ceb3b5eb15d"},{"author":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"change_message_id":"007d3cd0b6b504df93c9fa473f7d0887a4edbe4f","unresolved":false,"context_lines":[{"line_number":1823,"context_line":"        strncpy_s(undo_data-\u003eitf_name, sizeof(undo_data-\u003eitf_name), itf_name, _TRUNCATE);"},{"line_number":1824,"context_line":"        undo_data-\u003edomains \u003d wide_domains;"},{"line_number":1825,"context_line":""},{"line_number":1826,"context_line":"        const BOOL added \u003d AddDnsSearchDomains(list_key, have_list, wide_domains);"},{"line_number":1827,"context_line":"        if (!added || AddListItem(\u0026(*lists)[undo_domains], undo_data) !\u003d NO_ERROR)"},{"line_number":1828,"context_line":"        {"},{"line_number":1829,"context_line":"            if (added)"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"cf8087ab_032b3022","line":1826,"in_reply_to":"86815028_6d75c77a","updated":"2026-11-11 10:16:58.000000000","message":"Makes sense, done. Thanks!","commit_id":"092ca65bdb0605e88656d822621a8ceb3b5eb15d"}]}