)]}'
{"id":"openvpn~2161","triplet_id":"openvpn~master~I7ffae4da3b29521844a31d234fe6a9dd08954cf4","project":"openvpn","branch":"master","full_branch":"refs/heads/master","attention_set":{},"removed_from_attention_set":{"1000007":{"account":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"last_update":"2026-11-11 10:34:49.000000000","reason":"\u003cGERRIT_ACCOUNT_1000007\u003e replied on the change","reason_account":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"}},"1000053":{"account":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"last_update":"2026-11-13 16:57:57.000000000","reason":"Change was submitted"},"1000003":{"account":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2026-11-13 16:57:57.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I7ffae4da3b29521844a31d234fe6a9dd08954cf4","subject":"openvpnserv: only remove search domains that were added","status":"MERGED","created":"2026-11-10 09:09:42.000000000","updated":"2026-11-13 16:57:57.000000000","submitted":"2026-11-13 16:57:57.000000000","submitter":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":4,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"2161","meta_rev_id":"1371635bfc048d0170644265043594b6e3a20ff7","_number":2161,"virtual_id_number":2161,"owner":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},{"value":0,"_account_id":1000006,"name":"Heiko Hund","display_name":"Heiko Hund","email":"heiko@ist.eigentlich.net","username":"d12fk"},{"value":0,"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"reviewers":{"REVIEWER":[{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"_account_id":1000006,"name":"Heiko Hund","display_name":"Heiko Hund","email":"heiko@ist.eigentlich.net","username":"d12fk"},{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-11-10 09:09:42.000000000","updated_by":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"real_updated_by":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2026-11-10 09:09:42.000000000","updated_by":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"real_updated_by":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"reviewer":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2026-11-11 09:58:28.000000000","updated_by":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"real_updated_by":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"reviewer":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"state":"REVIEWER"},{"updated":"2026-11-12 04:31:12.000000000","updated_by":{"_account_id":1000006,"name":"Heiko Hund","display_name":"Heiko Hund","email":"heiko@ist.eigentlich.net","username":"d12fk"},"real_updated_by":{"_account_id":1000006,"name":"Heiko Hund","display_name":"Heiko Hund","email":"heiko@ist.eigentlich.net","username":"d12fk"},"reviewer":{"_account_id":1000006,"name":"Heiko Hund","display_name":"Heiko Hund","email":"heiko@ist.eigentlich.net","username":"d12fk"},"state":"REVIEWER"}],"messages":[{"id":"d6e2d1ec1c37e87669dbda497f228547cff29c9b","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"date":"2026-11-10 09:09:42.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"8a13a39532905724cc273e4bf8a1c2643022ecef","author":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"date":"2026-11-11 09:58:28.000000000","message":"Patch Set 1: Code-Review+2\n\n(2 comments)","accounts_in_message":[],"_revision_number":1},{"id":"bd0e8db527f01c76bf16e32d5c51479b1178bc93","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"date":"2026-11-11 10:16:29.000000000","message":"Uploaded patch set 2.\n\nOutdated Votes:\n* Code-Review+2 (copy condition: \"changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR is:MIN\")\n","accounts_in_message":[],"_revision_number":2},{"id":"007d3cd0b6b504df93c9fa473f7d0887a4edbe4f","author":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"date":"2026-11-11 10:16:58.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"a4c8762b57502efb8187af8a01e2fdc1db4ea1a4","author":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"date":"2026-11-11 10:34:49.000000000","message":"Patch Set 2: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"9619b1dacdf437f478350dac19c2c0e96f3e5831","author":{"_account_id":1000006,"name":"Heiko Hund","display_name":"Heiko Hund","email":"heiko@ist.eigentlich.net","username":"d12fk"},"date":"2026-11-12 04:31:12.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"1371635bfc048d0170644265043594b6e3a20ff7","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2026-11-13 16:57:57.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"09c4f4a189c989fe6aa9ba59237b3440d4619af9","revisions":{"092ca65bdb0605e88656d822621a8ceb3b5eb15d":{"kind":"REWORK","_number":1,"created":"2026-11-10 09:09:42.000000000","uploader":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"ref":"refs/changes/61/2161/1","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/61/2161/1","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/61/2161/1 \u0026\u0026 git checkout -b change-2161 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/61/2161/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/61/2161/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/61/2161/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/61/2161/1","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/61/2161/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"83c988d49fddc7e0ad9c40741ab6f391f236ed45","subject":"Remove unused gc_arena variables"}],"author":{"name":"Razvan Cojocaru","email":"razvanc@mailbox.org","date":"2026-11-10 09:07:12.000000000","tz":120},"committer":{"name":"Razvan Cojocaru","email":"razvanc@mailbox.org","date":"2026-11-10 09:07:12.000000000","tz":120},"subject":"openvpnserv: only remove search domains that were added","message":"openvpnserv: only remove search domains that were added\n\nWhen AddDnsSearchDomains() failed, SetDnsSearchDomains() still called\nRemoveDnsSearchDomains() with the new domains, which removes matching\ndomains already in the search list, e.g. ones configured before the\nVPN connected. Only remove them if they were added and recording the\nundo data failed.\n\nBroken since ae90cbad (\"dns: support multiple domains without DHCP\").\n\nChange-Id: I7ffae4da3b29521844a31d234fe6a9dd08954cf4\nSigned-off-by: Razvan Cojocaru \u003crazvanc@mailbox.org\u003e\n"},"branch":"refs/heads/master"},"193f1deedeb81851852f64a578c1e8518fd05343":{"kind":"REWORK","_number":2,"created":"2026-11-11 10:16:29.000000000","uploader":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"ref":"refs/changes/61/2161/2","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/61/2161/2","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/61/2161/2 \u0026\u0026 git checkout -b change-2161 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/61/2161/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/61/2161/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/61/2161/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/61/2161/2","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/61/2161/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"83c988d49fddc7e0ad9c40741ab6f391f236ed45","subject":"Remove unused gc_arena variables"}],"author":{"name":"Razvan Cojocaru","email":"razvanc@mailbox.org","date":"2026-11-11 10:10:56.000000000","tz":120},"committer":{"name":"Razvan Cojocaru","email":"razvanc@mailbox.org","date":"2026-11-11 10:10:56.000000000","tz":120},"subject":"openvpnserv: only remove search domains that were added","message":"openvpnserv: only remove search domains that were added\n\nWhen AddDnsSearchDomains() failed, SetDnsSearchDomains() still called\nRemoveDnsSearchDomains() with the new domains, which removes matching\ndomains already in the search list, e.g. ones configured before the\nVPN connected. Record the undo data first, as done for NRPT rules, and\ndrop it if adding the domains fails.\n\nBroken since ae90cbad (\"dns: support multiple domains without DHCP\").\n\nChange-Id: I7ffae4da3b29521844a31d234fe6a9dd08954cf4\nSigned-off-by: Razvan Cojocaru \u003crazvanc@mailbox.org\u003e\n"},"branch":"refs/heads/master"},"09c4f4a189c989fe6aa9ba59237b3440d4619af9":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":3,"created":"2026-11-13 16:57:57.000000000","uploader":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/61/2161/3","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/61/2161/3","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/61/2161/3 \u0026\u0026 git checkout -b change-2161 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/61/2161/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/61/2161/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/61/2161/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/61/2161/3","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/61/2161/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"412477ce0eb1da475c688dece6c65b300f1edeb1","subject":"httpdigest: replace IN/OUT macros with plain const"}],"author":{"name":"Razvan Cojocaru","email":"razvanc@mailbox.org","date":"2026-11-12 06:32:26.000000000","tz":60},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2026-11-13 16:50:07.000000000","tz":60},"subject":"openvpnserv: only remove search domains that were added","message":"openvpnserv: only remove search domains that were added\n\nWhen AddDnsSearchDomains() failed, SetDnsSearchDomains() still called\nRemoveDnsSearchDomains() with the new domains, which removes matching\ndomains already in the search list, e.g. ones configured before the\nVPN connected. Record the undo data first, as done for NRPT rules, and\ndrop it if adding the domains fails.\n\nBroken since ae90cbad (\"dns: support multiple domains without DHCP\").\n\nChange-Id: I7ffae4da3b29521844a31d234fe6a9dd08954cf4\nSigned-off-by: Razvan Cojocaru \u003crazvanc@mailbox.org\u003e\nAcked-by: Antonio Quartulli \u003cantonio@mandelbit.com\u003e\nAcked-by: Heiko Hund \u003cheiko@ist.eigentlich.net\u003e\nGerrit URL: https://gerrit.openvpn.net/c/openvpn/+/2161\nMessage-Id: \u003c20261112063232.23999-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg41181.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[]}