)]}'
{"id":"openvpn~2163","triplet_id":"openvpn~master~I5c52cc5c3aaad21d1c22f36f6451235302ea6c4f","project":"openvpn","branch":"master","full_branch":"refs/heads/master","attention_set":{},"removed_from_attention_set":{"1000007":{"account":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"last_update":"2026-11-10 11:13:54.000000000","reason":"\u003cGERRIT_ACCOUNT_1000007\u003e replied on the change","reason_account":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"}},"1000053":{"account":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"last_update":"2026-11-12 17:43:09.000000000","reason":"Change was submitted"},"1000003":{"account":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2026-11-12 17:43:09.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I5c52cc5c3aaad21d1c22f36f6451235302ea6c4f","subject":"sitnl: clear inet_address_t locals with CLEAR()","status":"MERGED","created":"2026-11-10 10:48:18.000000000","updated":"2026-11-12 17:43:09.000000000","submitted":"2026-11-12 17:43:09.000000000","submitter":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"2163","meta_rev_id":"8f515b48e1c4e75f0068136f463f84f43cc2a873","_number":2163,"virtual_id_number":2163,"owner":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},{"value":0,"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"reviewers":{"REVIEWER":[{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-11-10 10:48:19.000000000","updated_by":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"real_updated_by":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2026-11-10 10:48:19.000000000","updated_by":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"real_updated_by":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"reviewer":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2026-11-10 10:57:08.000000000","updated_by":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"real_updated_by":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"reviewer":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"state":"REVIEWER"}],"messages":[{"id":"e311e6066a960fcdbd411d9cb2a5420174ea7634","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"date":"2026-11-10 10:48:18.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"1ccc4f13adb30762f404aac47196b4233c5b260b","author":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"date":"2026-11-10 10:57:08.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"d5ae4b7a98b664ebaf9cfa2431de0cdebd0c7ae1","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"date":"2026-11-10 11:08:36.000000000","message":"Uploaded patch set 2.\n\nOutdated Votes:\n* Code-Review-1 (copy condition: \"changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR is:MIN\")\n","accounts_in_message":[],"_revision_number":2},{"id":"b5eca27f6e1f209fdc5cfc2422f65fffec26ed80","author":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"date":"2026-11-10 11:13:54.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"8f515b48e1c4e75f0068136f463f84f43cc2a873","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2026-11-12 17:43:09.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"2a59209487d37e8d28ee4394bfa4de6e011a3c05","revisions":{"0f6899deddd6d9cf92cd27ed4feaa20ba7745a81":{"kind":"REWORK","_number":1,"created":"2026-11-10 10:48:18.000000000","uploader":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"ref":"refs/changes/63/2163/1","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/63/2163/1","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/63/2163/1 \u0026\u0026 git checkout -b change-2163 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/63/2163/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/63/2163/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/63/2163/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/63/2163/1","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/63/2163/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"83c988d49fddc7e0ad9c40741ab6f391f236ed45","subject":"Remove unused gc_arena variables"}],"author":{"name":"Razvan Cojocaru","email":"razvanc@mailbox.org","date":"2026-11-10 10:19:03.000000000","tz":120},"committer":{"name":"Razvan Cojocaru","email":"razvanc@mailbox.org","date":"2026-11-10 10:35:27.000000000","tz":120},"subject":"sitnl: put the IPv6 member first in inet_address_t","message":"sitnl: put the IPv6 member first in inet_address_t\n\nThe inet_address_t locals are initialized with \"\u003d { 0 }\", which only\ninitializes the first union member, the 4 byte ipv4. GCC 15 and later\nno longer clear the rest of the union for this, so the IPv6 addresses\nof these locals keep up to 12 bytes of stack garbage when the caller\npasses no address.\n\nnet_route_v6_del() then sends a garbage RTA_GATEWAY for routes without\na gateway, and the kernel refuses to delete them. net_route_v6_best_gw()\nlooks up a garbage destination when asked for the default route.\n\nWith ipv6 first, \"\u003d { 0 }\" clears the whole union.\n\nLatent since c6542257 (\"introduce sitnl: Simplified Interface To\nNetLink\").\n\nChange-Id: I5c52cc5c3aaad21d1c22f36f6451235302ea6c4f\nSigned-off-by: Razvan Cojocaru \u003crazvanc@mailbox.org\u003e\n"},"branch":"refs/heads/master"},"4cec021e663787b962dc818dec3af846fcc88b78":{"kind":"REWORK","_number":2,"created":"2026-11-10 11:08:36.000000000","uploader":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"ref":"refs/changes/63/2163/2","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/63/2163/2","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/63/2163/2 \u0026\u0026 git checkout -b change-2163 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/63/2163/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/63/2163/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/63/2163/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/63/2163/2","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/63/2163/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"83c988d49fddc7e0ad9c40741ab6f391f236ed45","subject":"Remove unused gc_arena variables"}],"author":{"name":"Razvan Cojocaru","email":"razvanc@mailbox.org","date":"2026-11-10 10:19:03.000000000","tz":120},"committer":{"name":"Razvan Cojocaru","email":"razvanc@mailbox.org","date":"2026-11-10 11:08:02.000000000","tz":120},"subject":"sitnl: clear inet_address_t locals with CLEAR()","message":"sitnl: clear inet_address_t locals with CLEAR()\n\nThe inet_address_t locals were initialized with \"\u003d { 0 }\", which only\ninitializes the first union member, the 4 byte ipv4. GCC 15 and later\nno longer clear the rest of the union for this, so the IPv6 addresses\nof these locals keep up to 12 bytes of stack garbage when the caller\npasses no address.\n\nnet_route_v6_del() then sends a garbage RTA_GATEWAY for routes without\na gateway, and the kernel refuses to delete them. net_route_v6_best_gw()\nlooks up a garbage destination when asked for the default route.\n\nClear the whole union with CLEAR() instead. The other inet_address_t\nlocals are cleared the same way, so none relies on the partial\ninitialization.\n\nLatent since c6542257 (\"introduce sitnl: Simplified Interface To\nNetLink\").\n\nChange-Id: I5c52cc5c3aaad21d1c22f36f6451235302ea6c4f\nSigned-off-by: Razvan Cojocaru \u003crazvanc@mailbox.org\u003e\n"},"branch":"refs/heads/master"},"2a59209487d37e8d28ee4394bfa4de6e011a3c05":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":3,"created":"2026-11-12 17:43:09.000000000","uploader":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/63/2163/3","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/63/2163/3","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/63/2163/3 \u0026\u0026 git checkout -b change-2163 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/63/2163/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/63/2163/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/63/2163/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/63/2163/3","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/63/2163/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"4b241185d75f61be9137220e18742c1e6912820f","subject":"Adjust ACC_MAX_MSG_LEN, fix ACC in p2p mode and improve documentation"}],"author":{"name":"Razvan Cojocaru","email":"razvanc@mailbox.org","date":"2026-11-10 11:20:53.000000000","tz":60},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2026-11-12 17:26:28.000000000","tz":60},"subject":"sitnl: clear inet_address_t locals with CLEAR()","message":"sitnl: clear inet_address_t locals with CLEAR()\n\nThe inet_address_t locals were initialized with \"\u003d { 0 }\", which only\ninitializes the first union member, the 4 byte ipv4. GCC 15 and later\nno longer clear the rest of the union for this, so the IPv6 addresses\nof these locals keep up to 12 bytes of stack garbage when the caller\npasses no address.\n\nnet_route_v6_del() then sends a garbage RTA_GATEWAY for routes without\na gateway, and the kernel refuses to delete them. net_route_v6_best_gw()\nlooks up a garbage destination when asked for the default route.\n\nClear the whole union with CLEAR() instead. The other inet_address_t\nlocals are cleared the same way, so none relies on the partial\ninitialization.\n\nLatent since c6542257 (\"introduce sitnl: Simplified Interface To\nNetLink\").\n\nChange-Id: I5c52cc5c3aaad21d1c22f36f6451235302ea6c4f\nSigned-off-by: Razvan Cojocaru \u003crazvanc@mailbox.org\u003e\nAcked-by: Antonio Quartulli \u003cantonio@mandelbit.com\u003e\nGerrit URL: https://gerrit.openvpn.net/c/openvpn/+/2163\nMessage-Id: \u003c20261110112059.30832-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg41061.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[]}