)]}'
{"id":"openvpn~2166","triplet_id":"openvpn~master~I2490a0780a6e7c98a270e97b415b0387093d37be","project":"openvpn","branch":"master","full_branch":"refs/heads/master","attention_set":{},"removed_from_attention_set":{"1000035":{"account":{"_account_id":1000035,"name":"Steffan Karger","display_name":"Steffan Karger","email":"steffan@karger.me","username":"syzzer","status":"Commits and comments are my own views, not those of my employer."},"last_update":"2026-11-13 16:36:57.000000000","reason":"Change was submitted"},"1000003":{"account":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2026-11-11 10:07:18.000000000","reason":"removed on reply"}},"hashtags":[],"change_id":"I2490a0780a6e7c98a270e97b415b0387093d37be","subject":"httpdigest: replace IN/OUT macros with plain const","status":"MERGED","created":"2026-11-10 13:07:14.000000000","updated":"2026-11-13 16:36:57.000000000","submitted":"2026-11-13 16:36:57.000000000","submitter":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"2166","meta_rev_id":"415f93c2727260025b4bd9bbce00fea5767a9ad7","_number":2166,"virtual_id_number":2166,"owner":{"_account_id":1000035,"name":"Steffan Karger","display_name":"Steffan Karger","email":"steffan@karger.me","username":"syzzer","status":"Commits and comments are my own views, not those of my employer."},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},{"value":0,"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"value":0,"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-11-10 13:07:15.000000000","updated_by":{"_account_id":1000035,"name":"Steffan Karger","display_name":"Steffan Karger","email":"steffan@karger.me","username":"syzzer","status":"Commits and comments are my own views, not those of my employer."},"real_updated_by":{"_account_id":1000035,"name":"Steffan Karger","display_name":"Steffan Karger","email":"steffan@karger.me","username":"syzzer","status":"Commits and comments are my own views, not those of my employer."},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2026-11-10 13:07:15.000000000","updated_by":{"_account_id":1000035,"name":"Steffan Karger","display_name":"Steffan Karger","email":"steffan@karger.me","username":"syzzer","status":"Commits and comments are my own views, not those of my employer."},"real_updated_by":{"_account_id":1000035,"name":"Steffan Karger","display_name":"Steffan Karger","email":"steffan@karger.me","username":"syzzer","status":"Commits and comments are my own views, not those of my employer."},"reviewer":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2026-11-10 13:24:01.000000000","updated_by":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"real_updated_by":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"reviewer":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"state":"REVIEWER"}],"messages":[{"id":"af3813b61e24c511113ece1dfad64c2461a48f87","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000035,"name":"Steffan Karger","display_name":"Steffan Karger","email":"steffan@karger.me","username":"syzzer","status":"Commits and comments are my own views, not those of my employer."},"date":"2026-11-10 13:07:14.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"2adc1eb8ce4bde090a7dd4fd096a86b7d6971d55","author":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"date":"2026-11-10 13:24:01.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"7b8594189d7bfab41e0a974fa91c69cd64617f09","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000035,"name":"Steffan Karger","display_name":"Steffan Karger","email":"steffan@karger.me","username":"syzzer","status":"Commits and comments are my own views, not those of my employer."},"date":"2026-11-10 14:08:20.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.\n\nCopied Votes:\n* Code-Review+2 (copy condition: \"changekind:NO_CHANGE OR **changekind:TRIVIAL_REBASE** OR is:MIN\")\n","accounts_in_message":[],"_revision_number":2},{"id":"0e65a1374a50364a8714efa54d23a45a9da658b9","author":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2026-11-11 10:07:18.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"415f93c2727260025b4bd9bbce00fea5767a9ad7","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2026-11-13 16:36:57.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"412477ce0eb1da475c688dece6c65b300f1edeb1","revisions":{"4fa7e6bf9bac91e2a040030ae7c4ff13407c78b7":{"kind":"REWORK","_number":1,"created":"2026-11-10 13:07:14.000000000","uploader":{"_account_id":1000035,"name":"Steffan Karger","display_name":"Steffan Karger","email":"steffan@karger.me","username":"syzzer","status":"Commits and comments are my own views, not those of my employer."},"ref":"refs/changes/66/2166/1","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/66/2166/1","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/66/2166/1 \u0026\u0026 git checkout -b change-2166 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/66/2166/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/66/2166/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/66/2166/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/66/2166/1","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/66/2166/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"15a1465f981bb3f1950056a8f82b91dfe5f3fdbc","subject":"Make CRL reload EOF detection independent of stale error queue entries"}],"author":{"name":"Steffan Karger","email":"steffan@karger.me","date":"2026-11-10 12:52:25.000000000","tz":0},"committer":{"name":"Steffan Karger","email":"steffan@karger.me","date":"2026-11-10 13:04:45.000000000","tz":60},"subject":"httpdigest: replace IN/OUT macros with plain const","message":"httpdigest: replace IN/OUT macros with plain const\n\nhttpdigest.h defines IN as const, and never undefines it. This leaks\ninto the pkcs11-helper headers that proxy.c includes later on, which\nuse IN/OUT as empty annotations and only define them if not defined\nyet. That changes the pkcs11-helper declarations proxy.c sees (\u0027IN\nvoid * const\u0027 becomes \u0027const void * const\u0027), and makes clang spit out\nover a hundred -Wduplicate-decl-specifier warnings.\n\nJust use const where we used IN, and drop OUT. No functional change.\n\nChange-Id: I2490a0780a6e7c98a270e97b415b0387093d37be\nSigned-off-by: Steffan Karger \u003csteffan@karger.me\u003e\n"},"branch":"refs/heads/master"},"cea5993c3ebbba40f6cd97e3b9143842d136dfc3":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2026-11-10 14:08:20.000000000","uploader":{"_account_id":1000035,"name":"Steffan Karger","display_name":"Steffan Karger","email":"steffan@karger.me","username":"syzzer","status":"Commits and comments are my own views, not those of my employer."},"ref":"refs/changes/66/2166/2","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/66/2166/2","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/66/2166/2 \u0026\u0026 git checkout -b change-2166 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/66/2166/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/66/2166/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/66/2166/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/66/2166/2","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/66/2166/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"83c988d49fddc7e0ad9c40741ab6f391f236ed45","subject":"Remove unused gc_arena variables"}],"author":{"name":"Steffan Karger","email":"steffan@karger.me","date":"2026-11-10 12:52:25.000000000","tz":0},"committer":{"name":"Steffan Karger","email":"steffan@karger.me","date":"2026-11-10 14:08:02.000000000","tz":60},"subject":"httpdigest: replace IN/OUT macros with plain const","message":"httpdigest: replace IN/OUT macros with plain const\n\nhttpdigest.h defines IN as const, and never undefines it. This leaks\ninto the pkcs11-helper headers that proxy.c includes later on, which\nuse IN/OUT as empty annotations and only define them if not defined\nyet. That changes the pkcs11-helper declarations proxy.c sees (\u0027IN\nvoid * const\u0027 becomes \u0027const void * const\u0027), and makes clang spit out\nover a hundred -Wduplicate-decl-specifier warnings.\n\nJust use const where we used IN, and drop OUT. No functional change.\n\nChange-Id: I2490a0780a6e7c98a270e97b415b0387093d37be\nSigned-off-by: Steffan Karger \u003csteffan@karger.me\u003e\n"},"branch":"refs/heads/master"},"412477ce0eb1da475c688dece6c65b300f1edeb1":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":3,"created":"2026-11-13 16:36:57.000000000","uploader":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/66/2166/3","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/66/2166/3","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/66/2166/3 \u0026\u0026 git checkout -b change-2166 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/66/2166/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/66/2166/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/66/2166/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/66/2166/3","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/66/2166/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"f6f035bca56e3b7da845f6e08c7b8bff6bfa97e8","subject":"Silence remaining cppcheck warnings on macOS and FreeBSD"}],"author":{"name":"Steffan Karger","email":"steffan@karger.me","date":"2026-11-11 16:39:30.000000000","tz":60},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2026-11-13 16:19:55.000000000","tz":60},"subject":"httpdigest: replace IN/OUT macros with plain const","message":"httpdigest: replace IN/OUT macros with plain const\n\nhttpdigest.h defines IN as const, and never undefines it. This leaks\ninto the pkcs11-helper headers that proxy.c includes later on, which\nuse IN/OUT as empty annotations and only define them if not defined\nyet. That changes the pkcs11-helper declarations proxy.c sees (\u0027IN\nvoid * const\u0027 becomes \u0027const void * const\u0027), and makes clang spit out\nover a hundred -Wduplicate-decl-specifier warnings.\n\nJust use const where we used IN, and drop OUT. No functional change.\n\nChange-Id: I2490a0780a6e7c98a270e97b415b0387093d37be\nSigned-off-by: Steffan Karger \u003csteffan@karger.me\u003e\nAcked-by: Razvan Cojocaru \u003crazvanc@mailbox.org\u003e\nAcked-by: Arne Schwabe \u003carne-openvpn@rfc2549.org\u003e\nGerrit URL: https://gerrit.openvpn.net/c/openvpn/+/2166\nMessage-Id: \u003c20261111163935.6604-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg41166.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[]}