)]}'
{"id":"openvpn~2173","triplet_id":"openvpn~master~I0705cff831cbd18686721dffbe5960976e3489da","project":"openvpn","branch":"master","full_branch":"refs/heads/master","attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2026-11-11 08:54:48.000000000","reason":"Reviewer was added"}},"removed_from_attention_set":{},"hashtags":[],"change_id":"I0705cff831cbd18686721dffbe5960976e3489da","subject":"tun_afunix: reap the child process on close","status":"NEW","created":"2026-11-11 08:54:47.000000000","updated":"2026-11-13 13:54:26.000000000","submit_type":"CHERRY_PICK","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"87a1cc7c8b413f6ce3c5f5c3a665b059e4994933","_number":2173,"virtual_id_number":2173,"owner":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-11-11 08:54:48.000000000","updated_by":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"real_updated_by":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2026-11-11 08:54:48.000000000","updated_by":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"real_updated_by":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"reviewer":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"}],"messages":[{"id":"67b701d39cd8bd190b82dead2e13ab9c1550281b","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"date":"2026-11-11 08:54:47.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"1dd937974adfbc67645009e6882e34ea7795cbcb","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"date":"2026-11-13 12:41:54.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"87a1cc7c8b413f6ce3c5f5c3a665b059e4994933","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"date":"2026-11-13 13:54:26.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"c720d24931f9a06276cf841a0c8832b80dce48b7","revisions":{"49a91a2aa35287d1a5361a8bb21507d4f38f5347":{"kind":"REWORK","_number":1,"created":"2026-11-11 08:54:47.000000000","uploader":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"ref":"refs/changes/73/2173/1","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/73/2173/1","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/73/2173/1 \u0026\u0026 git checkout -b change-2173 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/73/2173/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/73/2173/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/73/2173/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/73/2173/1","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/73/2173/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"83c988d49fddc7e0ad9c40741ab6f391f236ed45","subject":"Remove unused gc_arena variables"}],"author":{"name":"Razvan Cojocaru","email":"razvanc@mailbox.org","date":"2026-11-11 08:54:16.000000000","tz":120},"committer":{"name":"Razvan Cojocaru","email":"razvanc@mailbox.org","date":"2026-11-11 08:54:16.000000000","tz":120},"subject":"tun_afunix: reap the child process on close","message":"tun_afunix: reap the child process on close\n\nclose_tun_afunix() sent SIGINT to the child but never waited for it,\nleaving a zombie on every restart.\n\nChange-Id: I0705cff831cbd18686721dffbe5960976e3489da\nSigned-off-by: Razvan Cojocaru \u003crazvanc@mailbox.org\u003e\n"},"branch":"refs/heads/master"},"4ad58c89a30bc5c11262ce5837ad8ff0560b9951":{"kind":"REWORK","_number":2,"created":"2026-11-13 12:41:54.000000000","uploader":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"ref":"refs/changes/73/2173/2","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/73/2173/2","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/73/2173/2 \u0026\u0026 git checkout -b change-2173 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/73/2173/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/73/2173/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/73/2173/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/73/2173/2","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/73/2173/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"83c988d49fddc7e0ad9c40741ab6f391f236ed45","subject":"Remove unused gc_arena variables"}],"author":{"name":"Razvan Cojocaru","email":"razvanc@mailbox.org","date":"2026-11-11 08:54:16.000000000","tz":120},"committer":{"name":"Razvan Cojocaru","email":"razvanc@mailbox.org","date":"2026-11-13 12:21:57.000000000","tz":120},"subject":"tun_afunix: reap the child process on close","message":"tun_afunix: reap the child process on close\n\nclose_tun_afunix() sent SIGINT to the child but never waited for it,\nleaving a zombie on every restart.\n\nPoll for up to a second for it to exit, then SIGKILL it and poll for\nanother second. Don\u0027t wait when SIGINT can\u0027t be delivered: a child\nstarted before --user dropped privileges would block close forever.\n\nChange-Id: I0705cff831cbd18686721dffbe5960976e3489da\nSigned-off-by: Razvan Cojocaru \u003crazvanc@mailbox.org\u003e\n"},"branch":"refs/heads/master"},"c720d24931f9a06276cf841a0c8832b80dce48b7":{"kind":"REWORK","_number":3,"created":"2026-11-13 13:54:26.000000000","uploader":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"ref":"refs/changes/73/2173/3","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/73/2173/3","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/73/2173/3 \u0026\u0026 git checkout -b change-2173 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/73/2173/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/73/2173/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/73/2173/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/73/2173/3","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/73/2173/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"83c988d49fddc7e0ad9c40741ab6f391f236ed45","subject":"Remove unused gc_arena variables"}],"author":{"name":"Razvan Cojocaru","email":"razvanc@mailbox.org","date":"2026-11-11 08:54:16.000000000","tz":120},"committer":{"name":"Razvan Cojocaru","email":"razvanc@mailbox.org","date":"2026-11-13 13:52:22.000000000","tz":120},"subject":"tun_afunix: reap the child process on close","message":"tun_afunix: reap the child process on close\n\nclose_tun_afunix() sent SIGINT to the child but never waited for it,\nleaving a zombie on every restart.\n\nAdd openvpn_stop_child() next to openvpn_waitpid_check(). It waits up\nto a second for the child to exit, then SIGKILLs it and waits up to\nanother second. It doesn\u0027t wait when SIGINT can\u0027t be delivered, e.g. to\na child started before --user dropped privileges.\n\nopenvpn_waitpid_check() now returns false and logs why when waitpid()\nfails, as documented, instead of reporting a process that isn\u0027t our\nchild as running. A clean exit is no longer logged as an error status.\n\nChange-Id: I0705cff831cbd18686721dffbe5960976e3489da\nSigned-off-by: Razvan Cojocaru \u003crazvanc@mailbox.org\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"NOT_READY","labels":[{"label":"Code-Review","status":"NEED"}]},{"rule_name":"checks~ChecksSubmitRule","status":"OK"}]}