)]}'
{"id":"openvpn~2174","triplet_id":"openvpn~master~Ia99aacf7ad7b6863b2f2a7297d0229faae529d9f","project":"openvpn","branch":"master","full_branch":"refs/heads/master","attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2026-11-11 09:08:49.000000000","reason":"Reviewer was added"}},"removed_from_attention_set":{},"hashtags":[],"change_id":"Ia99aacf7ad7b6863b2f2a7297d0229faae529d9f","subject":"openvpnserv: don\u0027t leave stale domains in unused NRPT exclude slot","status":"NEW","created":"2026-11-11 09:08:49.000000000","updated":"2026-11-11 09:08:49.000000000","submit_type":"CHERRY_PICK","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"4c2d366975bf9784f95a2cc6cd57bfa0e0dece84","_number":2174,"virtual_id_number":2174,"owner":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-11-11 09:08:49.000000000","updated_by":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"real_updated_by":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2026-11-11 09:08:49.000000000","updated_by":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"real_updated_by":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"reviewer":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"}],"messages":[{"id":"a456c1467c1608693ed69535c71a375cdb0063eb","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"date":"2026-11-11 09:08:49.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"d03d45e235cc417983829e81c8a5d3ef98ff380d","revisions":{"d03d45e235cc417983829e81c8a5d3ef98ff380d":{"kind":"REWORK","_number":1,"created":"2026-11-11 09:08:49.000000000","uploader":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"ref":"refs/changes/74/2174/1","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/74/2174/1","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/74/2174/1 \u0026\u0026 git checkout -b change-2174 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/74/2174/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/74/2174/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/74/2174/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/74/2174/1","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/74/2174/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"83c988d49fddc7e0ad9c40741ab6f391f236ed45","subject":"Remove unused gc_arena variables"}],"author":{"name":"Antonio Quartulli","email":"antonio@mandelbit.com","date":"2026-11-11 09:03:37.000000000","tz":60},"committer":{"name":"Antonio Quartulli","email":"antonio@mandelbit.com","date":"2026-11-11 09:03:37.000000000","tz":60},"subject":"openvpnserv: don\u0027t leave stale domains in unused NRPT exclude slot","message":"openvpnserv: don\u0027t leave stale domains in unused NRPT exclude slot\n\nGetNrptExcludeData() fills data[i].domains before it knows whether the\ninterface will be used. If the interface is then skipped, because it\nhas no name servers or reading them fails, i is not advanced and the\ndomains stay in data[i] until the next interface overwrites them.\n\nWhen the skipped interface is the last one enumerated, nothing\noverwrites them. SetNrptExcludeRules() stops at the first entry with\ndomains_size \u003d\u003d 0, so it then creates an exclude rule from the stale\ndomains, with an empty or incomplete name server list.\n\nClear domains_size of the unused slot on the way out.\n\nBroken since 0f3b7d17 (\"win: implement --dns option support with\nNRPT\").\n\nChange-Id: Ia99aacf7ad7b6863b2f2a7297d0229faae529d9f\nSigned-off-by: Antonio Quartulli \u003cantonio@mandelbit.com\u003e\n"},"branch":"refs/heads/master"}},"requirements":[{"status":"NOT_READY","fallback_text":"All required checks must pass","type":"checks_pass"}],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"NOT_READY","labels":[{"label":"Code-Review","status":"NEED"}]},{"rule_name":"checks~ChecksSubmitRule","status":"NOT_READY","requirements":[{"status":"NOT_READY","fallback_text":"All required checks must pass","type":"checks_pass"}]}]}