)]}'
{"id":"openvpn~2175","triplet_id":"openvpn~master~I230b3b2483e15477b179b277dc8f7c91c53fa0c0","project":"openvpn","branch":"master","full_branch":"refs/heads/master","attention_set":{},"removed_from_attention_set":{"1000053":{"account":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"last_update":"2026-11-11 14:32:11.000000000","reason":"removed on reply"},"1000003":{"account":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2026-11-13 17:44:54.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I230b3b2483e15477b179b277dc8f7c91c53fa0c0","subject":"Extract tls_pre_decrypt_extract_session_id and pre_decrypt_find_session","status":"MERGED","created":"2026-11-11 11:06:26.000000000","updated":"2026-11-13 17:44:54.000000000","submitted":"2026-11-13 17:44:54.000000000","submitter":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":4,"unresolved_comment_count":4,"has_review_started":true,"submission_id":"2175","meta_rev_id":"1cdb13ca2bdaff21e4de94e96dea5be0ecb9a36c","_number":2175,"virtual_id_number":2175,"owner":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},{"value":0,"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-11-11 11:06:27.000000000","updated_by":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"real_updated_by":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2026-11-11 13:43:29.000000000","updated_by":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"real_updated_by":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"reviewer":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"state":"REVIEWER"}],"messages":[{"id":"461dad90de7da1292067f8a7ba6d02d0fbbf2f22","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2026-11-11 11:06:26.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"f620267679b41f6ec8c6fe90ed4697b85dbd234a","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2026-11-11 12:29:12.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"8f37ffdbe77a879b5525aefe643ca9c7ee2ddabf","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2026-11-11 13:30:40.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"2740d355ee721e734f5a92aae4e460a4190846c7","author":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"date":"2026-11-11 13:43:29.000000000","message":"Patch Set 3: Code-Review+2\n\n(2 comments)","accounts_in_message":[],"_revision_number":3},{"id":"799162532dbbb391e6f54a9816e48c2958939c6c","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2026-11-11 14:26:16.000000000","message":"Uploaded patch set 4.\n\nOutdated Votes:\n* Code-Review+2 (copy condition: \"changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR is:MIN\")\n","accounts_in_message":[],"_revision_number":4},{"id":"397172b7368a131aeac71933c24cc39f70de0718","author":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"date":"2026-11-11 14:32:11.000000000","message":"Patch Set 4: Code-Review+2\n\n(2 comments)","accounts_in_message":[],"_revision_number":4},{"id":"1cdb13ca2bdaff21e4de94e96dea5be0ecb9a36c","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2026-11-13 17:44:54.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":5}],"current_revision_number":5,"current_revision":"2a6784b2e2ae52b53379945fc5a88fb33a30142d","revisions":{"1693290a2e19497da1a033a50cd189e7d254ef86":{"kind":"REWORK","_number":1,"created":"2026-11-11 11:06:26.000000000","uploader":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"ref":"refs/changes/75/2175/1","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/75/2175/1","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/75/2175/1 \u0026\u0026 git checkout -b change-2175 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/75/2175/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/75/2175/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/75/2175/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/75/2175/1","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/75/2175/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"07f6f57e5f8ddd13fe97d81397579999a4e84442","subject":"Extract tls_pre_decrypt_verify_opcode from tls_pre_decrypt"}],"author":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2026-11-11 11:04:22.000000000","tz":60},"committer":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2026-11-11 11:05:58.000000000","tz":60},"subject":"Extract tls_pre_decrypt_extract_session_id and pre_decrypt_find_session","message":"Extract tls_pre_decrypt_extract_session_id and pre_decrypt_find_session\n\nThese functions fulfil steps that can be easily moved to their own\nfunctions to make tls_pre_decrypt a bit more readable.\n\nChange-Id: I230b3b2483e15477b179b277dc8f7c91c53fa0c0\nSigned-off-by: Arne Schwabe \u003carne@rfc2549.org\u003e\n"},"branch":"refs/heads/master"},"0ffe080f1b9cebead744a2b185351866d2d6a46e":{"kind":"REWORK","_number":2,"created":"2026-11-11 12:29:12.000000000","uploader":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"ref":"refs/changes/75/2175/2","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/75/2175/2","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/75/2175/2 \u0026\u0026 git checkout -b change-2175 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/75/2175/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/75/2175/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/75/2175/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/75/2175/2","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/75/2175/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"07f6f57e5f8ddd13fe97d81397579999a4e84442","subject":"Extract tls_pre_decrypt_verify_opcode from tls_pre_decrypt"}],"author":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2026-11-11 11:04:22.000000000","tz":60},"committer":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2026-11-11 12:29:04.000000000","tz":60},"subject":"Extract tls_pre_decrypt_extract_session_id and pre_decrypt_find_session","message":"Extract tls_pre_decrypt_extract_session_id and pre_decrypt_find_session\n\nThese functions fulfil steps that can be easily moved to their own\nfunctions to make tls_pre_decrypt a bit more readable.\n\nChange-Id: I230b3b2483e15477b179b277dc8f7c91c53fa0c0\nSigned-off-by: Arne Schwabe \u003carne@rfc2549.org\u003e\n"},"branch":"refs/heads/master"},"7c26995119d4b1dbaf696843e8017ef7fa1cea33":{"kind":"REWORK","_number":3,"created":"2026-11-11 13:30:40.000000000","uploader":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"ref":"refs/changes/75/2175/3","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/75/2175/3","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/75/2175/3 \u0026\u0026 git checkout -b change-2175 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/75/2175/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/75/2175/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/75/2175/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/75/2175/3","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/75/2175/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"07f6f57e5f8ddd13fe97d81397579999a4e84442","subject":"Extract tls_pre_decrypt_verify_opcode from tls_pre_decrypt"}],"author":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2026-11-11 11:04:22.000000000","tz":60},"committer":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2026-11-11 13:30:28.000000000","tz":60},"subject":"Extract tls_pre_decrypt_extract_session_id and pre_decrypt_find_session","message":"Extract tls_pre_decrypt_extract_session_id and pre_decrypt_find_session\n\nThese functions fulfil steps that can be easily moved to their own\nfunctions to make tls_pre_decrypt a bit more readable.\n\nChange-Id: I230b3b2483e15477b179b277dc8f7c91c53fa0c0\nSigned-off-by: Arne Schwabe \u003carne@rfc2549.org\u003e\n"},"branch":"refs/heads/master"},"0ec30f1a1fd63034dc8d2fda869c97e1efbfa474":{"kind":"REWORK","_number":4,"created":"2026-11-11 14:26:16.000000000","uploader":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"ref":"refs/changes/75/2175/4","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/75/2175/4","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/75/2175/4 \u0026\u0026 git checkout -b change-2175 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/75/2175/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/75/2175/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/75/2175/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/75/2175/4","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/75/2175/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"07f6f57e5f8ddd13fe97d81397579999a4e84442","subject":"Extract tls_pre_decrypt_verify_opcode from tls_pre_decrypt"}],"author":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2026-11-11 11:04:22.000000000","tz":60},"committer":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2026-11-11 14:26:08.000000000","tz":60},"subject":"Extract tls_pre_decrypt_extract_session_id and pre_decrypt_find_session","message":"Extract tls_pre_decrypt_extract_session_id and pre_decrypt_find_session\n\nThese functions fulfil steps that can be easily moved to their own\nfunctions to make tls_pre_decrypt a bit more readable.\n\nChange-Id: I230b3b2483e15477b179b277dc8f7c91c53fa0c0\nSigned-off-by: Arne Schwabe \u003carne@rfc2549.org\u003e\n"},"branch":"refs/heads/master"},"2a6784b2e2ae52b53379945fc5a88fb33a30142d":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":5,"created":"2026-11-13 17:44:54.000000000","uploader":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/75/2175/5","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/75/2175/5","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/75/2175/5 \u0026\u0026 git checkout -b change-2175 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/75/2175/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/75/2175/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/75/2175/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/75/2175/5","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/75/2175/5 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"26bb86bb2ccbc6280c159db19597e02e19e684fb","subject":"openvpnserv: always free the domains in UndoDnsSearchDomains()"}],"author":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2026-11-13 10:49:24.000000000","tz":60},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2026-11-13 17:07:46.000000000","tz":60},"subject":"Extract tls_pre_decrypt_extract_session_id and pre_decrypt_find_session","message":"Extract tls_pre_decrypt_extract_session_id and pre_decrypt_find_session\n\nThese functions fulfil steps that can be easily moved to their own\nfunctions to make tls_pre_decrypt a bit more readable.\n\nChange-Id: I230b3b2483e15477b179b277dc8f7c91c53fa0c0\nSigned-off-by: Arne Schwabe \u003carne@rfc2549.org\u003e\nAcked-by: Razvan Cojocaru \u003crazvanc@mailbox.org\u003e\nGerrit URL: https://gerrit.openvpn.net/c/openvpn/+/2175\nMessage-Id: \u003c20261113104930.25197-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg41246.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[]}