)]}'
{"id":"openvpn~2182","triplet_id":"openvpn~master~Iefcfd9f29244d9ae6a5a68b6e9b507b55e3bf448","project":"openvpn","branch":"master","full_branch":"refs/heads/master","attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2026-11-13 12:27:08.000000000","reason":"\u003cGERRIT_ACCOUNT_1000035\u003e replied on the change","reason_account":{"_account_id":1000035,"name":"Steffan Karger","display_name":"Steffan Karger","email":"steffan@karger.me","username":"syzzer","status":"Commits and comments are my own views, not those of my employer."}}},"removed_from_attention_set":{},"hashtags":[],"change_id":"Iefcfd9f29244d9ae6a5a68b6e9b507b55e3bf448","subject":"mbedtls: print peer certificate details like the OpenSSL backend","status":"NEW","created":"2026-11-12 13:32:36.000000000","updated":"2026-11-13 12:27:08.000000000","submit_type":"CHERRY_PICK","total_comment_count":1,"unresolved_comment_count":1,"has_review_started":true,"meta_rev_id":"cf303145d03e66de2de96919551e814d931aaf1d","_number":2182,"virtual_id_number":2182,"owner":{"_account_id":1000035,"name":"Steffan Karger","display_name":"Steffan Karger","email":"steffan@karger.me","username":"syzzer","status":"Commits and comments are my own views, not those of my employer."},"actions":{},"labels":{"Code-Review":{"rejected":{"_account_id":1000035,"name":"Steffan Karger","display_name":"Steffan Karger","email":"steffan@karger.me","username":"syzzer","status":"Commits and comments are my own views, not those of my employer."},"all":[{"value":-2,"date":"2026-11-13 12:27:08.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":1000035,"name":"Steffan Karger","display_name":"Steffan Karger","email":"steffan@karger.me","username":"syzzer","status":"Commits and comments are my own views, not those of my employer."},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0,"blocking":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"_account_id":1000035,"name":"Steffan Karger","display_name":"Steffan Karger","email":"steffan@karger.me","username":"syzzer","status":"Commits and comments are my own views, not those of my employer."}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-11-12 13:32:36.000000000","updated_by":{"_account_id":1000035,"name":"Steffan Karger","display_name":"Steffan Karger","email":"steffan@karger.me","username":"syzzer","status":"Commits and comments are my own views, not those of my employer."},"real_updated_by":{"_account_id":1000035,"name":"Steffan Karger","display_name":"Steffan Karger","email":"steffan@karger.me","username":"syzzer","status":"Commits and comments are my own views, not those of my employer."},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2026-11-12 13:32:36.000000000","updated_by":{"_account_id":1000035,"name":"Steffan Karger","display_name":"Steffan Karger","email":"steffan@karger.me","username":"syzzer","status":"Commits and comments are my own views, not those of my employer."},"real_updated_by":{"_account_id":1000035,"name":"Steffan Karger","display_name":"Steffan Karger","email":"steffan@karger.me","username":"syzzer","status":"Commits and comments are my own views, not those of my employer."},"reviewer":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"}],"messages":[{"id":"b34788f01e42adefd8ea3eb173f3b0f1210e2138","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000035,"name":"Steffan Karger","display_name":"Steffan Karger","email":"steffan@karger.me","username":"syzzer","status":"Commits and comments are my own views, not those of my employer."},"date":"2026-11-12 13:32:36.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"02aca49059ff9fa99019c7f1b4d721df67ce27f7","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000035,"name":"Steffan Karger","display_name":"Steffan Karger","email":"steffan@karger.me","username":"syzzer","status":"Commits and comments are my own views, not those of my employer."},"date":"2026-11-12 13:34:34.000000000","message":"Uploaded patch set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"523b2d37d1870053268b2d53d871efa3b62fc639","tag":"autogenerated:gerrit:setWorkInProgress","author":{"_account_id":1000035,"name":"Steffan Karger","display_name":"Steffan Karger","email":"steffan@karger.me","username":"syzzer","status":"Commits and comments are my own views, not those of my employer."},"date":"2026-11-13 12:23:47.000000000","message":"Set Work In Progress","accounts_in_message":[],"_revision_number":2},{"id":"cf303145d03e66de2de96919551e814d931aaf1d","author":{"_account_id":1000035,"name":"Steffan Karger","display_name":"Steffan Karger","email":"steffan@karger.me","username":"syzzer","status":"Commits and comments are my own views, not those of my employer."},"date":"2026-11-13 12:27:08.000000000","message":"Patch Set 2: Code-Review-2\n\n(1 comment)\n\nThis change is ready for review.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"0a9a9b27bc1a2477fa608774c78096ac787ffaea","revisions":{"a315869e791d8c7063a885b93d8d03379792ea76":{"kind":"REWORK","_number":1,"created":"2026-11-12 13:32:36.000000000","uploader":{"_account_id":1000035,"name":"Steffan Karger","display_name":"Steffan Karger","email":"steffan@karger.me","username":"syzzer","status":"Commits and comments are my own views, not those of my employer."},"ref":"refs/changes/82/2182/1","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/82/2182/1","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/82/2182/1 \u0026\u0026 git checkout -b change-2182 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/82/2182/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/82/2182/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/82/2182/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/82/2182/1","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/82/2182/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"83c988d49fddc7e0ad9c40741ab6f391f236ed45","subject":"Remove unused gc_arena variables"}],"author":{"name":"Steffan Karger","email":"steffan@karger.me","date":"2026-11-11 10:26:34.000000000","tz":0},"committer":{"name":"Steffan Karger","email":"steffan@karger.me","date":"2026-11-12 13:26:51.000000000","tz":0},"subject":"mbedtls: print peer certificate details like the OpenSSL backend","message":"mbedtls: print peer certificate details like the OpenSSL backend\n\nThe OpenSSL backend logs the type, size and curve of the peer\u0027s\ncertificate key, and the certificate signature algorithm. The mbed TLS\nbackend only logged the key size, which makes it harder to compare logs\nof the two backends.\n\nPrint the key type, curve and signature algorithm for mbed TLS too, using\nthe OpenSSL short names for the signature algorithms.\n\nmbed TLS 4 no longer offers functions to get curve or digest names, so\nadd the PSA curve family and size to our --tls-groups table, and a reverse\nlookup to the digest table. While at it, add secp256k1 to the groups table\n(used by our EC sample keys), which also makes it usable in --tls-groups.\n\nChange-Id: Iefcfd9f29244d9ae6a5a68b6e9b507b55e3bf448\n"},"branch":"refs/heads/master"},"0a9a9b27bc1a2477fa608774c78096ac787ffaea":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2026-11-12 13:34:34.000000000","uploader":{"_account_id":1000035,"name":"Steffan Karger","display_name":"Steffan Karger","email":"steffan@karger.me","username":"syzzer","status":"Commits and comments are my own views, not those of my employer."},"ref":"refs/changes/82/2182/2","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/82/2182/2","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/82/2182/2 \u0026\u0026 git checkout -b change-2182 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/82/2182/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/82/2182/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/82/2182/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/82/2182/2","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/82/2182/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"83c988d49fddc7e0ad9c40741ab6f391f236ed45","subject":"Remove unused gc_arena variables"}],"author":{"name":"Steffan Karger","email":"steffan@karger.me","date":"2026-11-11 10:26:34.000000000","tz":0},"committer":{"name":"Steffan Karger","email":"steffan@karger.me","date":"2026-11-12 13:34:25.000000000","tz":60},"subject":"mbedtls: print peer certificate details like the OpenSSL backend","message":"mbedtls: print peer certificate details like the OpenSSL backend\n\nThe OpenSSL backend logs the type, size and curve of the peer\u0027s\ncertificate key, and the certificate signature algorithm. The mbed TLS\nbackend only logged the key size, which makes it harder to compare logs\nof the two backends.\n\nPrint the key type, curve and signature algorithm for mbed TLS too, using\nthe OpenSSL short names for the signature algorithms.\n\nmbed TLS 4 no longer offers functions to get curve or digest names, so\nadd the PSA curve family and size to our --tls-groups table, and a reverse\nlookup to the digest table. While at it, add secp256k1 to the groups table\n(used by our EC sample keys), which also makes it usable in --tls-groups.\n\nChange-Id: Iefcfd9f29244d9ae6a5a68b6e9b507b55e3bf448\nSigned-off-by: Steffan Karger \u003csteffan@karger.me\u003e\n"},"branch":"refs/heads/master"}},"requirements":[{"status":"NOT_READY","fallback_text":"All required checks must pass","type":"checks_pass"}],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"NOT_READY","labels":[{"label":"Code-Review","status":"REJECT","applied_by":{"_account_id":1000035,"name":"Steffan Karger","display_name":"Steffan Karger","email":"steffan@karger.me","username":"syzzer","status":"Commits and comments are my own views, not those of my employer."}}]},{"rule_name":"checks~ChecksSubmitRule","status":"NOT_READY","requirements":[{"status":"NOT_READY","fallback_text":"All required checks must pass","type":"checks_pass"}]}]}
