)]}'
{"id":"openvpn~2188","triplet_id":"openvpn~master~I14ad4e4511bd9933b89f48ae5a3ac6d2a5e0f2d8","project":"openvpn","branch":"master","full_branch":"refs/heads/master","attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2026-11-16 10:33:52.000000000","reason":"Reviewer was added"}},"removed_from_attention_set":{},"hashtags":[],"change_id":"I14ad4e4511bd9933b89f48ae5a3ac6d2a5e0f2d8","subject":"openvpnserv: check for a leading non-option in the startup data","status":"NEW","created":"2026-11-16 10:33:52.000000000","updated":"2026-11-17 11:22:05.000000000","submit_type":"CHERRY_PICK","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"7ef5e72e54a69b62c6da79242c84088475947bd4","_number":2188,"virtual_id_number":2188,"owner":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-11-16 10:33:52.000000000","updated_by":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"real_updated_by":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2026-11-16 10:33:52.000000000","updated_by":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"real_updated_by":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"reviewer":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"}],"messages":[{"id":"edaf9fd8633904d4a313f46556e03c4d03971210","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"date":"2026-11-16 10:33:52.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"7ef5e72e54a69b62c6da79242c84088475947bd4","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"date":"2026-11-17 11:22:05.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"a1bb251ca077225e246bd77bff2cd92112043438","revisions":{"6b7b1d11b70f4cc74e7d99f234b086ab1e08535b":{"kind":"REWORK","_number":1,"created":"2026-11-16 10:33:52.000000000","uploader":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"ref":"refs/changes/88/2188/1","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/88/2188/1","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/88/2188/1 \u0026\u0026 git checkout -b change-2188 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/88/2188/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/88/2188/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/88/2188/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/88/2188/1","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/88/2188/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"ad4e3b4921c520e187a27d8014d953e8e294130d","subject":"openvpnserv: reject a config file passed without --config"}],"author":{"name":"Razvan Cojocaru","email":"razvanc@mailbox.org","date":"2026-11-16 09:49:22.000000000","tz":120},"committer":{"name":"Razvan Cojocaru","email":"razvanc@mailbox.org","date":"2026-11-16 10:02:02.000000000","tz":120},"subject":"openvpnserv: check for a leading non-option in the startup data","message":"openvpnserv: check for a leading non-option in the startup data\n\nCheck sud.options directly before doing any other work, instead of\nbuilding the openvpn.exe command line and parsing it back. This also\nrejects empty options.\n\nChange-Id: I14ad4e4511bd9933b89f48ae5a3ac6d2a5e0f2d8\nSigned-off-by: Razvan Cojocaru \u003crazvanc@mailbox.org\u003e\n"},"branch":"refs/heads/master"},"a1bb251ca077225e246bd77bff2cd92112043438":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2026-11-17 11:22:05.000000000","uploader":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"ref":"refs/changes/88/2188/2","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/88/2188/2","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/88/2188/2 \u0026\u0026 git checkout -b change-2188 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/88/2188/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/88/2188/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/88/2188/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/88/2188/2","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/88/2188/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"823653286f82e2fbcd1ff1687a8a01b3fb6302e6","subject":"buffer: Switch buf_forward_capacity and buf_set_write to size_t"}],"author":{"name":"Razvan Cojocaru","email":"razvanc@mailbox.org","date":"2026-11-16 09:49:22.000000000","tz":120},"committer":{"name":"Razvan Cojocaru","email":"razvanc@mailbox.org","date":"2026-11-17 11:20:46.000000000","tz":120},"subject":"openvpnserv: check for a leading non-option in the startup data","message":"openvpnserv: check for a leading non-option in the startup data\n\nCheck sud.options directly before doing any other work, instead of\nbuilding the openvpn.exe command line and parsing it back. This also\nrejects empty options.\n\nChange-Id: I14ad4e4511bd9933b89f48ae5a3ac6d2a5e0f2d8\nSigned-off-by: Razvan Cojocaru \u003crazvanc@mailbox.org\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"NOT_READY","labels":[{"label":"Code-Review","status":"NEED"}]},{"rule_name":"checks~ChecksSubmitRule","status":"OK"}]}
