)]}'
{"id":"openvpn~2192","triplet_id":"openvpn~master~Ic3e13e414b3c64cdafb57dcfe9d396159f8f5f44","project":"openvpn","branch":"master","full_branch":"refs/heads/master","attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2026-11-16 12:36:54.000000000","reason":"Reviewer was added"}},"removed_from_attention_set":{},"hashtags":[],"change_id":"Ic3e13e414b3c64cdafb57dcfe9d396159f8f5f44","subject":"socks: convert service port to host byte order","status":"NEW","created":"2026-11-16 12:36:54.000000000","updated":"2026-11-17 11:22:19.000000000","submit_type":"CHERRY_PICK","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"b71cfed38001e27c28f00e4a35b192cffa8e25ff","_number":2192,"virtual_id_number":2192,"owner":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-11-16 12:36:54.000000000","updated_by":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"real_updated_by":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2026-11-16 12:36:54.000000000","updated_by":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"real_updated_by":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"reviewer":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"}],"messages":[{"id":"0c75bdbe08e6e34df24d238dbed02df90b304429","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"date":"2026-11-16 12:36:54.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"bd924f02fad66fc7ee1fe9f9b5014ae8845f17c6","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"date":"2026-11-16 19:18:59.000000000","message":"Uploaded patch set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"b71cfed38001e27c28f00e4a35b192cffa8e25ff","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"date":"2026-11-17 11:22:19.000000000","message":"Uploaded patch set 3: Patch Set 2 was rebased.","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"b892b64838c5bcb347f4b81ef9cff6bbddb857dd","revisions":{"b7c57b8c107c08e7243dae9b11b817508a1d6bb2":{"kind":"REWORK","_number":1,"created":"2026-11-16 12:36:54.000000000","uploader":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"ref":"refs/changes/92/2192/1","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/92/2192/1","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/92/2192/1 \u0026\u0026 git checkout -b change-2192 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/92/2192/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/92/2192/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/92/2192/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/92/2192/1","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/92/2192/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"2d1014eaf4112c9d3d002523ab40671cf32931c7","subject":"openvpnserv: keep IPv6 name servers in NRPT exclude rules"}],"author":{"name":"Razvan Cojocaru","email":"razvanc@mailbox.org","date":"2026-11-16 12:11:21.000000000","tz":120},"committer":{"name":"Razvan Cojocaru","email":"razvanc@mailbox.org","date":"2026-11-16 12:11:21.000000000","tz":120},"subject":"socks: convert service port to host byte order","message":"socks: convert service port to host byte order\n\ngetservbyname() returns s_port in network byte order, but the caller\nsplits the port as a host-order value. On little-endian hosts a remote\nport given as a service name (e.g. \"https\") was sent byte-swapped in the\nSOCKS5 CONNECT request.\n\nChange-Id: Ic3e13e414b3c64cdafb57dcfe9d396159f8f5f44\nSigned-off-by: Razvan Cojocaru \u003crazvanc@mailbox.org\u003e\n"},"branch":"refs/heads/master"},"8e294f40da919fde860ebb545ea215c49108ea15":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2026-11-16 19:18:59.000000000","uploader":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"ref":"refs/changes/92/2192/2","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/92/2192/2","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/92/2192/2 \u0026\u0026 git checkout -b change-2192 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/92/2192/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/92/2192/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/92/2192/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/92/2192/2","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/92/2192/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"2d1014eaf4112c9d3d002523ab40671cf32931c7","subject":"openvpnserv: keep IPv6 name servers in NRPT exclude rules"}],"author":{"name":"Razvan Cojocaru","email":"razvanc@mailbox.org","date":"2026-11-16 12:11:21.000000000","tz":120},"committer":{"name":"Razvan Cojocaru","email":"razvanc@mailbox.org","date":"2026-11-16 19:18:37.000000000","tz":120},"subject":"socks: convert service port to host byte order","message":"socks: convert service port to host byte order\n\ngetservbyname() returns s_port in network byte order, but the caller\nsplits the port as a host-order value. On little-endian hosts a remote\nport given as a service name (e.g. \"https\") was sent byte-swapped in the\nSOCKS5 CONNECT request.\n\nTo test, connect with \"--remote foobar https --socks-proxy \u003chost\u003e \u003cport\u003e\"\nand check the port the SOCKS proxy is asked to connect to: 443 with the\nfix, 47873 (0xbb01) without it.\n\nChange-Id: Ic3e13e414b3c64cdafb57dcfe9d396159f8f5f44\nSigned-off-by: Razvan Cojocaru \u003crazvanc@mailbox.org\u003e\n"},"branch":"refs/heads/master"},"b892b64838c5bcb347f4b81ef9cff6bbddb857dd":{"kind":"TRIVIAL_REBASE","_number":3,"created":"2026-11-17 11:22:19.000000000","uploader":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"ref":"refs/changes/92/2192/3","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/92/2192/3","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/92/2192/3 \u0026\u0026 git checkout -b change-2192 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/92/2192/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/92/2192/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/92/2192/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/92/2192/3","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/92/2192/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"823653286f82e2fbcd1ff1687a8a01b3fb6302e6","subject":"buffer: Switch buf_forward_capacity and buf_set_write to size_t"}],"author":{"name":"Razvan Cojocaru","email":"razvanc@mailbox.org","date":"2026-11-16 12:11:21.000000000","tz":120},"committer":{"name":"Razvan Cojocaru","email":"razvanc@mailbox.org","date":"2026-11-17 11:20:46.000000000","tz":120},"subject":"socks: convert service port to host byte order","message":"socks: convert service port to host byte order\n\ngetservbyname() returns s_port in network byte order, but the caller\nsplits the port as a host-order value. On little-endian hosts a remote\nport given as a service name (e.g. \"https\") was sent byte-swapped in the\nSOCKS5 CONNECT request.\n\nTo test, connect with \"--remote foobar https --socks-proxy \u003chost\u003e \u003cport\u003e\"\nand check the port the SOCKS proxy is asked to connect to: 443 with the\nfix, 47873 (0xbb01) without it.\n\nChange-Id: Ic3e13e414b3c64cdafb57dcfe9d396159f8f5f44\nSigned-off-by: Razvan Cojocaru \u003crazvanc@mailbox.org\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"NOT_READY","labels":[{"label":"Code-Review","status":"NEED"}]},{"rule_name":"checks~ChecksSubmitRule","status":"OK"}]}
