)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"change_message_id":"13abf839811480e959d17a09be3703e376dce78a","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2026-11-16 15:37:29 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"buffer: Switch buf_forward_capacity and buf_write_set to size_t"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"To make them consistent with buf_forward_capacity_total"},{"line_number":10,"context_line":"and buf_read_set that were already switched."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"20db7c65_846f6381","line":7,"updated":"2026-11-16 14:58:44.000000000","message":"The function name is buf_set_write().","commit_id":"f876009b2802561292d654c16f7fffa1616bbd1d"},{"author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"11b647115b2506c9f0bfb10d84e5ff15517cb7db","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2026-11-16 15:37:29 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"buffer: Switch buf_forward_capacity and buf_write_set to size_t"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"To make them consistent with buf_forward_capacity_total"},{"line_number":10,"context_line":"and buf_read_set that were already switched."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5e25f6d1_43c1994a","line":7,"in_reply_to":"20db7c65_846f6381","updated":"2026-11-17 10:13:13.000000000","message":"Done","commit_id":"f876009b2802561292d654c16f7fffa1616bbd1d"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"change_message_id":"c0815fdc76031919063bd48b93c0239eb1af350c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"99362866_302076d3","updated":"2026-11-16 15:00:30.000000000","message":"Patch version changed while I was reviewing, but the comments for v1 still stand.","commit_id":"4a4389a2ae44a3ce9b24bfba4bc64dfccecfa83d"}],"src/openvpn/ssl_ncp.c":[{"author":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"change_message_id":"13abf839811480e959d17a09be3703e376dce78a","unresolved":true,"context_lines":[{"line_number":563,"context_line":"    uint8_t *ncp_ciphers \u003d gc_malloc(ncp_ciphers_len, true, \u0026o-\u003egc);"},{"line_number":564,"context_line":""},{"line_number":565,"context_line":"    struct buffer ncp_ciphers_buf;"},{"line_number":566,"context_line":"    ASSERT(ncp_ciphers_len \u003c\u003d INT_MAX);"},{"line_number":567,"context_line":"    buf_set_write(\u0026ncp_ciphers_buf, ncp_ciphers, ncp_ciphers_len);"},{"line_number":568,"context_line":""},{"line_number":569,"context_line":"    const char *def \u003d strstr(o-\u003encp_ciphers, search);"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"b9962930_56ddd144","line":566,"updated":"2026-11-16 14:58:44.000000000","message":"Do we still need the `ASSERT()` if we are no longer casting to `int`?","commit_id":"f876009b2802561292d654c16f7fffa1616bbd1d"},{"author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"11b647115b2506c9f0bfb10d84e5ff15517cb7db","unresolved":false,"context_lines":[{"line_number":563,"context_line":"    uint8_t *ncp_ciphers \u003d gc_malloc(ncp_ciphers_len, true, \u0026o-\u003egc);"},{"line_number":564,"context_line":""},{"line_number":565,"context_line":"    struct buffer ncp_ciphers_buf;"},{"line_number":566,"context_line":"    ASSERT(ncp_ciphers_len \u003c\u003d INT_MAX);"},{"line_number":567,"context_line":"    buf_set_write(\u0026ncp_ciphers_buf, ncp_ciphers, ncp_ciphers_len);"},{"line_number":568,"context_line":""},{"line_number":569,"context_line":"    const char *def \u003d strstr(o-\u003encp_ciphers, search);"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"c4f74e55_013e7857","line":566,"in_reply_to":"b9962930_56ddd144","updated":"2026-11-17 10:13:13.000000000","message":"Done","commit_id":"f876009b2802561292d654c16f7fffa1616bbd1d"}]}
