)]}'
{"id":"openvpn~2198","triplet_id":"openvpn~master~I9c2403c21ef8f21a0fbd998346c8ad719b4b9972","project":"openvpn","branch":"master","full_branch":"refs/heads/master","topic":"wsign-conversion","attention_set":{},"removed_from_attention_set":{"1000053":{"account":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"last_update":"2026-11-17 10:14:30.000000000","reason":"removed on reply"},"1000003":{"account":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2026-11-17 11:16:00.000000000","reason":"Change was submitted"},"1000001":{"account":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2026-11-17 11:16:00.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I9c2403c21ef8f21a0fbd998346c8ad719b4b9972","subject":"buffer: Switch buf_forward_capacity and buf_set_write to size_t","status":"MERGED","created":"2026-11-16 14:37:35.000000000","updated":"2026-11-17 11:16:00.000000000","submitted":"2026-11-17 11:16:00.000000000","submitter":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":5,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"2198-wsign-conversion","meta_rev_id":"ad6eb75aab8ed151d3e513f563352edc53d1b680","_number":2198,"virtual_id_number":2198,"owner":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},{"value":0,"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"reviewers":{"REVIEWER":[{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-11-16 14:37:38.000000000","updated_by":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"real_updated_by":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2026-11-16 14:37:38.000000000","updated_by":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"real_updated_by":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2026-11-16 14:58:44.000000000","updated_by":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"real_updated_by":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"reviewer":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"state":"REVIEWER"}],"messages":[{"id":"623a184a37574f574ee91fdea5c4feb7d02eb3bb","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-11-16 14:37:35.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"8b85b657082c77265077127192822c8cb1df3f68","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-11-16 14:51:12.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"13abf839811480e959d17a09be3703e376dce78a","author":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"date":"2026-11-16 14:58:44.000000000","message":"Patch Set 1: Code-Review-1\n\n(2 comments)","accounts_in_message":[],"_revision_number":1},{"id":"c0815fdc76031919063bd48b93c0239eb1af350c","author":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"date":"2026-11-16 15:00:30.000000000","message":"Patch Set 2: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"71a4467477b2463e3fc678c4affe50d01f83c8b9","author":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"date":"2026-11-17 10:10:39.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"c3de2a73601be86da0c1ca526b8f77e8ac5456ae","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-11-17 10:12:28.000000000","message":"Uploaded patch set 3.\n\nOutdated Votes:\n* Code-Review+2 (copy condition: \"changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR is:MIN\")\n","accounts_in_message":[],"_revision_number":3},{"id":"11b647115b2506c9f0bfb10d84e5ff15517cb7db","author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-11-17 10:13:13.000000000","message":"Patch Set 3:\n\n(2 comments)","accounts_in_message":[],"_revision_number":3},{"id":"ac870b7dde36ed0a920d62fbf531f35fb9a2ca42","author":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"date":"2026-11-17 10:14:30.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"ad6eb75aab8ed151d3e513f563352edc53d1b680","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2026-11-17 11:16:00.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"823653286f82e2fbcd1ff1687a8a01b3fb6302e6","revisions":{"f876009b2802561292d654c16f7fffa1616bbd1d":{"kind":"REWORK","_number":1,"created":"2026-11-16 14:37:35.000000000","uploader":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/98/2198/1","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/98/2198/1","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/98/2198/1 \u0026\u0026 git checkout -b change-2198 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/98/2198/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/98/2198/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/98/2198/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/98/2198/1","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/98/2198/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"7647a2f0f3d4696d9af9d973063eb76add07a39d","subject":"Various trivial -Wsign-conversion fixes (part 2)"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-11-16 14:10:37.000000000","tz":60},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-11-16 14:37:29.000000000","tz":60},"subject":"buffer: Switch buf_forward_capacity and buf_write_set to size_t","message":"buffer: Switch buf_forward_capacity and buf_write_set to size_t\n\nTo make them consistent with buf_forward_capacity_total\nand buf_read_set that were already switched.\n\nReview call sites.\n\nChange-Id: I9c2403c21ef8f21a0fbd998346c8ad719b4b9972\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"4a4389a2ae44a3ce9b24bfba4bc64dfccecfa83d":{"kind":"REWORK","_number":2,"created":"2026-11-16 14:51:12.000000000","uploader":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/98/2198/2","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/98/2198/2","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/98/2198/2 \u0026\u0026 git checkout -b change-2198 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/98/2198/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/98/2198/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/98/2198/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/98/2198/2","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/98/2198/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"e7a1fc7dac733dcc0f3f5d3f6dc90f67ad2d7209","subject":"Various trivial -Wsign-conversion fixes (part 2)"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-11-16 14:10:37.000000000","tz":60},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-11-16 14:50:11.000000000","tz":60},"subject":"buffer: Switch buf_forward_capacity and buf_write_set to size_t","message":"buffer: Switch buf_forward_capacity and buf_write_set to size_t\n\nTo make them consistent with buf_forward_capacity_total\nand buf_read_set that were already switched.\n\nReview call sites.\n\nChange-Id: I9c2403c21ef8f21a0fbd998346c8ad719b4b9972\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"6fd15e316f10888e29a439d4da99e1ff4b032f5c":{"kind":"REWORK","_number":3,"created":"2026-11-17 10:12:28.000000000","uploader":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/98/2198/3","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/98/2198/3","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/98/2198/3 \u0026\u0026 git checkout -b change-2198 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/98/2198/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/98/2198/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/98/2198/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/98/2198/3","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/98/2198/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"4721ed8df56c8d2e97da0079d01e5e2a87054fb8","subject":"Various trivial -Wsign-conversion fixes (part 2)"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-11-16 14:10:37.000000000","tz":60},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-11-17 10:12:04.000000000","tz":60},"subject":"buffer: Switch buf_forward_capacity and buf_set_write to size_t","message":"buffer: Switch buf_forward_capacity and buf_set_write to size_t\n\nTo make them consistent with buf_forward_capacity_total\nand buf_set_read that were already switched.\n\nReview call sites.\n\nChange-Id: I9c2403c21ef8f21a0fbd998346c8ad719b4b9972\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"823653286f82e2fbcd1ff1687a8a01b3fb6302e6":{"kind":"NO_CODE_CHANGE","_number":4,"created":"2026-11-17 11:16:00.000000000","uploader":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/98/2198/4","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/98/2198/4","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/98/2198/4 \u0026\u0026 git checkout -b change-2198 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/98/2198/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/98/2198/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/98/2198/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/98/2198/4","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/98/2198/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"4721ed8df56c8d2e97da0079d01e5e2a87054fb8","subject":"Various trivial -Wsign-conversion fixes (part 2)"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-11-17 10:19:01.000000000","tz":60},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2026-11-17 11:03:44.000000000","tz":60},"subject":"buffer: Switch buf_forward_capacity and buf_set_write to size_t","message":"buffer: Switch buf_forward_capacity and buf_set_write to size_t\n\nTo make them consistent with buf_forward_capacity_total\nand buf_set_read that were already switched.\n\nReview call sites.\n\nChange-Id: I9c2403c21ef8f21a0fbd998346c8ad719b4b9972\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\nAcked-by: Razvan Cojocaru \u003crazvanc@mailbox.org\u003e\nGerrit URL: https://gerrit.openvpn.net/c/openvpn/+/2198\nMessage-Id: \u003c20261117101909.30743-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg41509.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[]}
